From patchwork Thu Sep 29 15:16:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 676646 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3slJ9p1sYSz9s8x for ; Fri, 30 Sep 2016 01:18:22 +1000 (AEST) Received: from localhost ([::1]:38718 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpd6I-0002VE-OR for incoming@patchwork.ozlabs.org; Thu, 29 Sep 2016 11:18:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpd5A-0001kr-9W for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:17:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpd52-0004CB-MB for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:17:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpd52-0004C7-GH for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:17:00 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F34F9D6D28; Thu, 29 Sep 2016 15:16:59 +0000 (UTC) Received: from [10.36.112.30] (ovpn-112-30.ams2.redhat.com [10.36.112.30]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8TFGuD3031081; Thu, 29 Sep 2016 11:16:57 -0400 To: "Michael S. Tsirkin" , Thomas Huth References: <20160909220057-mutt-send-email-mst@kernel.org> <718d4b1f-2b2f-fefb-1175-73f07d962343@redhat.com> <20160910003052-mutt-send-email-mst@kernel.org> From: Laurent Vivier Message-ID: Date: Thu, 29 Sep 2016 17:16:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160910003052-mutt-send-email-mst@kernel.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 29 Sep 2016 15:17:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] kvm test warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Marcel Apfelbaum , qemu-devel@nongnu.org, David Gibson , pbonzini@redhat.com, =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On 09/09/2016 23:31, Michael S. Tsirkin wrote: > On Fri, Sep 09, 2016 at 09:24:45PM +0200, Thomas Huth wrote: >> On 09.09.2016 21:03, Michael S. Tsirkin wrote: >>> I am running make test on a box without kvm, and I am seeing these warnings: >>> >>> GTESTER check-qtest-ppc64 >>> "kvm" accelerator not found. >>> "kvm" accelerator not found. >>> GTESTER check-qtest-x86_64 >>> Could not access KVM kernel module: No such file or directory >>> failed to initialize KVM: No such file or directory >>> Back to tcg accelerator. >>> Could not access KVM kernel module: No such file or directory >>> failed to initialize KVM: No such file or directory >>> Back to tcg accelerator. >>> >>> This is with >>> commit c2a57aae9a1c3dd7de77daf5478df10379aeeebf >>> Merge: 5f31bbf f8042de >>> Author: Peter Maydell >>> Date: Fri Sep 9 12:49:41 2016 +0100 >>> >>> I originally thought this is due to Marcel's test change, >>> but it triggers without ask well. >>> >>> Help will be appreciated. >> >> See this thread here: >> >> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg05809.html >> >> It's not so easy to avoid this warning ... suggestions are welcome... >> >> Thomas > > > Really, we just need to add a command line argument > "--suppress-test-warnings" and pass it in from test framework. > What do you think of only displaying the error on the last accelerator of the list? The accelerator list can be seen as a failover list, so I don't think we have to display an error in this case as it is the expected behavior. Laurent --- a/accel.c +++ b/accel.c @@ -99,7 +99,12 @@ void configure_accelerator(MachineState *ms) p = get_opt_name(buf, sizeof(buf), p, ':'); acc = accel_find(buf); if (!acc) { - fprintf(stderr, "\"%s\" accelerator not found.\n", buf); + if (*p != ':') { + /* to avoid to pollute logs, display error only + * on the last accelerator of the list + */ + fprintf(stderr, "\"%s\" accelerator not found.\n", buf); + } continue; } if (acc->available && !acc->available()) {