Message ID | d7dc0682f5cb549ea9afdc418f95412e83cc5e8c.1697966402.git.mst@redhat.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TOX3SVC+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SCtDd2tx1z1ygT for <incoming@patchwork.ozlabs.org>; Sun, 22 Oct 2023 20:24:01 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces@nongnu.org>) id 1quUfm-0001hK-8n; Sun, 22 Oct 2023 05:23:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mst@redhat.com>) id 1quUfi-0001b5-MP for qemu-devel@nongnu.org; Sun, 22 Oct 2023 05:22:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mst@redhat.com>) id 1quUff-0000GC-84 for qemu-devel@nongnu.org; Sun, 22 Oct 2023 05:22:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697966574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ySJRsoNBBcgqyKONkpVDvYCkflnLmxrOPirjci4NdfM=; b=TOX3SVC+QOxR5I8HE/vfhtHysK/O5bGq0YAMGAue8eCSBE5DPGgNWeAlYBGQIYqgufILAu r/4lqO4wG7B6qralDZBK1uOGDTdGhL7Hyf1lL4yroxRNrPp6iDDD4ueYHkllgG+aO4n/9N io2uVGlb68+Rm+wS1g0PyXaSE1x69Ik= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-diWT7_bhPn6LGWJHl0NznA-1; Sun, 22 Oct 2023 05:22:51 -0400 X-MC-Unique: diWT7_bhPn6LGWJHl0NznA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32db9cd71d7so1134120f8f.0 for <qemu-devel@nongnu.org>; Sun, 22 Oct 2023 02:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697966569; x=1698571369; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ySJRsoNBBcgqyKONkpVDvYCkflnLmxrOPirjci4NdfM=; b=N6yt/lnrOQl6buaRop0F8kTrzl//Its92j7vLf0fof5ahvGnQxClBTH0kbqxE/9Xq7 rDeYfufPmtmWsrp93IV1Zge8LpSZAeFz1di/8w2zofhl/IUuDCkfi30OWNMQkwSg9xZP JgTOOfSzGz+hXRVVYgC3DQYY5UZWjfyynEwhDQaThsPLBhatXJ9HhThFklbqLcANqiYd Sg7t1QISgL66zvox+ii+6erKRVkm5K9gg7F+O7Wt0d9U3v7aE6D6U4ID5B3FMbcja5k2 eP/CDHdYrmB+tz7dQWmgqbFUzBI4js1aFBRkweieQsIU7uV8meE6nbs7VJCq4iFcOqk0 773Q== X-Gm-Message-State: AOJu0YxxTB+MeVQjISpUWmHNTObBiRzKRA5/bw6y4cBvNFxnFchf8j+L rRbW9WMFZJdgxgZ/g8YkEhMFOp+JAZa0IcBC7ARbCCc9gsX/QGShTygH4EB70SSQP3yQ7QL/LRe VNIFsLQeKA1G8iaS6CEwYq0IAFFxGG0QR3SkbfVUW9+dg8QmCQi5o7qJChWthj8cYtaiV X-Received: by 2002:adf:b346:0:b0:32d:cb21:4e99 with SMTP id k6-20020adfb346000000b0032dcb214e99mr8337509wrd.13.1697966569408; Sun, 22 Oct 2023 02:22:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5lKvmfRR8knKYSSJQjtYGRBvoOltrKKbiKVXLLbsoaJVjyzUzpi/SGoU6QGVZczFD13itww== X-Received: by 2002:adf:b346:0:b0:32d:cb21:4e99 with SMTP id k6-20020adfb346000000b0032dcb214e99mr8337493wrd.13.1697966569084; Sun, 22 Oct 2023 02:22:49 -0700 (PDT) Received: from redhat.com ([2.52.1.53]) by smtp.gmail.com with ESMTPSA id c16-20020a05600c0ad000b004063c9f68f2sm6464206wmr.26.2023.10.22.02.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 02:22:48 -0700 (PDT) Date: Sun, 22 Oct 2023 05:22:45 -0400 From: "Michael S. Tsirkin" <mst@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Maydell <peter.maydell@linaro.org>, Laszlo Ersek <lersek@redhat.com>, Eugenio Perez Martin <eperezma@redhat.com>, German Maglione <gmaglione@redhat.com>, Liu Jiang <gerry@linux.alibaba.com>, Sergio Lopez Pascual <slp@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Albert Esteve <aesteve@redhat.com> Subject: [PULL v3 14/62] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously Message-ID: <d7dc0682f5cb549ea9afdc418f95412e83cc5e8c.1697966402.git.mst@redhat.com> References: <cover.1697966402.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <cover.1697966402.git.mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org |
Series |
[PULL,v3,01/62] vdpa: Use iovec for vhost_vdpa_net_cvq_add()
|
expand
|
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 7e452849fa..427ee0ebfb 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -1225,7 +1225,21 @@ static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable) .num = enable, }; - ret = vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state, false); + /* + * SET_VRING_ENABLE travels from guest to QEMU to vhost-user backend / + * control plane thread via unix domain socket. Virtio requests travel + * from guest to vhost-user backend / data plane thread via eventfd. + * Even if the guest enables the ring first, and pushes its first virtio + * request second (conforming to the virtio spec), the data plane thread + * in the backend may see the virtio request before the control plane + * thread sees the queue enablement. This causes (in fact, requires) the + * data plane thread to discard the virtio request (it arrived on a + * seemingly disabled queue). To prevent this out-of-order delivery, + * don't let the guest proceed to pushing the virtio request until the + * backend control plane acknowledges enabling the queue -- IOW, pass + * wait_for_reply=true below. + */ + ret = vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state, true); if (ret < 0) { /* * Restoring the previous state is likely infeasible, as well as