From patchwork Thu Oct 19 16:16:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 828229 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="yOGFaDry"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yHvpq3SxZz9s2G for ; Fri, 20 Oct 2017 03:42:11 +1100 (AEDT) Received: from localhost ([::1]:50167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5DtZ-0005SD-Ed for incoming@patchwork.ozlabs.org; Thu, 19 Oct 2017 12:42:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5DYs-0004my-Qs for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5DYp-0001Ro-KH for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:20:46 -0400 Received: from mail-bn3nam01on0057.outbound.protection.outlook.com ([104.47.33.57]:58688 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5DYp-0001RO-D3 for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:20:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=71ajmO0VbL5klbGQQT4VmfLLhKEsbLj/aDnQhbSxDkA=; b=yOGFaDryI1snpK9nj2Rgtsi7RL/LaOwlFqJyeBlY/O0R7mqQYwA+2oN2IvCgkWU4J4TXSPKd0s7A3W4g7jLpdP1MP/DLvaJjAUWSN1UvV0PR7zNRbWvqcjnMIcntjpFGHmKdaHHrdmRRkJoi6uOiXQI5arklGFIU5Ht1F2qQxZQ= Received: from MWHPR02CA0014.namprd02.prod.outlook.com (10.168.209.152) by CY1PR02MB1334.namprd02.prod.outlook.com (10.161.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 19 Oct 2017 16:20:41 +0000 Received: from SN1NAM02FT055.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::208) by MWHPR02CA0014.outlook.office365.com (2603:10b6:300:4b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Thu, 19 Oct 2017 16:20:41 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT055.mail.protection.outlook.com (10.152.72.174) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 19 Oct 2017 16:20:40 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:37950 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1e5DYm-0007wN-34; Thu, 19 Oct 2017 09:20:40 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1e5DYl-0002zV-V2; Thu, 19 Oct 2017 09:20:40 -0700 Received: from xsj-pvapsmtp01 (mailhub.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v9JGKZKr006671; Thu, 19 Oct 2017 09:20:36 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1e5DYh-0002z2-TL; Thu, 19 Oct 2017 09:20:35 -0700 From: Alistair Francis To: Date: Thu, 19 Oct 2017 09:16:42 -0700 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23404.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(2980300002)(438002)(199003)(189002)(81166006)(6666003)(54906003)(4326008)(2950100002)(50226002)(478600001)(47776003)(23676002)(106002)(316002)(6916009)(5820100001)(39060400002)(77096006)(2351001)(81156014)(8936002)(106466001)(36756003)(33646002)(8676002)(63266004)(5660300001)(76176999)(50986999)(36386004)(50466002)(2906002)(9786002)(305945005)(2870700001)(118296001)(189998001)(356003)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR02MB1334; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT055; 1:WEXM4hadYQqSjhr75VQl5I1nPjrzGCAa/44oAKYWEl0uINbK4eIg7YBDLO05OMmwbjOMXS2QYh6TazH1yFeD9d5jCQRRb3KSdEJ8xF7pbsAuIS2NixccVO6T0HXWuS7U X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64230775-0809-408a-0b0b-08d5170d572a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CY1PR02MB1334; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 3:jHdQoD+Ut6qGovfWQb7DlI8F/YsO7kFqdJszrABvrUwsIzC+LamJWK6CQdZLx+QE6AnMDaU+4MfE2jBhe2sF/WndDYEwODKFCTA1bNbZ9fU7TxQa9CL0Yl1b7q4f1Ayo3LfEGH9vVb8xP/wKzt6SD2xqN9h3WCDWvhjMWSsJXwhCznu/r0owJrIJvZQ7MTYFp3tXmysCjvVVwWX9lgEAinOKkGlENPIyYvfzbfQn+/ryAjtkM/qumtltx0Lra2l/wXk4TM+dZnAylUiIDMRJklWh9Td8+ZoaDIoXQB9qU7mMymTNVLQjut2acud4ZwQfmRNgdTAD/njyVi7iEwJBC0sFd6bwqP4afzxna7rqANA=; 25:4Fm/bpI5IJakirMe5dp7cq91o86KJcfTXrtVIb43eZX0NnPcJU4/7SbN8swh44uvWyv2vION/w9k6q6iDT8oQwyJx+U31xTVil6hpGjqYpuU6YNOMi8L8rdaSbXBaYj10lQ/AC5SBszwNkDzACMlOarArAd9Fgvut9FLvaJAmB3kEtre2w4Ueamg/U14LzQEjtM3Xip+DRTd5oFiH6u7jbrJXK+tj07Ho5lI7wm6CRaoRnrSO1RVRZQ2icZ4gfFfSgtcmmyNVk/lZm10/SjGxrNjcYzjQD1l3krTr1c1HYH2gErFD+SCb7oshqrcdkRnyIKBnfhdlQQ72b92hD+JcA== X-MS-TrafficTypeDiagnostic: CY1PR02MB1334: X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 31:RsrdyUspshrdJOIXfmzDnI4iV8O4yZTrC3hvEkIeOGNtXWiknR/vj6IbrOIjzibMfn995rPPr+yoy0z8Qr/mjP4Qru0l+euBERqjbGncBD70ckXV5MCFtEHuakiwSD5SKlWy9AiSNd2sI1s/ePzrp+z+E+UFU6mWrE5MWOtnGvI6lVHyWEjr9zIzlazWUhh1eCVNBf19CFQScyoQ6yGZ3mSCmWu+g2hfQkM/f0iHFdg=; 20:CzgLvt9oWIULsboDsPG3bWHEAqnUjqJ6h30LOVg+H74mOJeGIi/eOJidljFJ7TUtlgkp4uPfw/LCj5IwkcCGiEi7ZsqrN64eKiI4KbNjPAMobf2Uf9iut720boLu5hKgXn1WQodXHtowGVL9jTC3VSxVVwWs7q2WSMv0X0EqJfBYS9OJ8m1TqN85sn4VZeVR9cLaHfVAAmoJxsh+mGqKQIU+NHRkzzKg1b602t/6pRXToY5ySrFEf9jOQihbPtq9vcWkFmseLOmCTwOQAM+bAcZMxa5tqePWlmBso96Q5J31hIqjKOLffSLuah/VuFOpcVhlFqVBRACsxXFH/2wLKoaBKbErsxqVtFyZnWSX9WwGx3HTnpqWAF8N732jXh5eoPvBdUfXXMk/dE6qifp31t6F4diPb6734NTG26t5eH4BxV+YOayCZo+ZHiVD/NIgjMOKNZOP4gVO7UtiMRogAKSHx56wVwqpMX5oj7VB8PECEWW/PW+Tk46nzjiY/V26 X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93004095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR02MB1334; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR02MB1334; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 4:CBLifrCFWnba+JGET1cYCdVAtCfkxVyQvFY0tXyd740AIIj7h8lCsu3Jku+tcCScYUHzx9cHDLMSdxhEyiETG0fp0QxisAVLwn4GTw43VeccV63lBy8MoVJQ0cZaLJ3qnfBPVIZkdMdWdWXjg/m6LfYUX5Pd2nEzGkBH+V6gRcp6SQt69CjK34R9rxL48lmwaNdrgMZr6phmCI3lyUcAktjeQfXBMEl0of4PWVMKG5wusI6ucGMibaROAR2TBK6xgDeJMmJTfRL2bUBRsgwMqMl1lROKYWfHQvK9Mfpa+yfskDfEVGxmB4Xgtvg88E620VtKOqeSaQfBOlpgV0yXNg== X-Forefront-PRVS: 0465429B7F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR02MB1334; 23:10s2Jp50y0Y8w/wCq24DlV5SVjkQWdc3HqG8o0Jw1?= F4hgRZgJmTgpEjNDMg1UzQOdZa1HbDi2JQOogvY+jkNcnjtrWVEomeBKYdgoGv5DWCHsJ6gcTkr4r6DFPDBFr6fhydlp37u6MgfReqfOdgT4fgW5ecBbfpGesS6LRXuJp8X9/iRs7qrykGAYhwPLrc04V6S6EPZDJT3z/TEdoL5SLjArK8IOUke5nbZPlRRCJIdQh9LcHbf1ALP0ywxySzGH2ALOQjLAvpuiyWUMUd3QRATPQiiCoQy7yBBlonKFQQv6gyTDZbSi/su5omIygcJrXmIRBe/fE0zaFuaWADEGEaI4GYtnkvIeMXn6nCESJAppYvNWU2rbfMdvVUwK50FkFFCYJoWbm1s1rDZFd8ZMzC5nG3XCIL8d030Q638yz7DfBTmFaNGm5QGTyBZBuBsmkpZQdQh8a+mxxOFsBfGUc4kc9nrpOGhAjieePF60jpzE9pcdhqRzxuYt8a00bero/WzRqrrTYOSmAf4B7WP78eUbQDd8neIAuoW00FN8pAr+WYtUmm6YFIaT3atoH+2i7OIVaQH5FOof4k4WvaX+IvFY4lU/5ZQoJqsil33u0bgGZ3ZD2t4Bdfwo6buD/9W7hdRs4GIpBc2urwLSTZcy6HcjzlX3sVhRlZUkSI4fwAa0ZtLJsb1kc6DaAqQ5uB/It0FTytKtRrfPXCr0V1ZCLBlLosENdStwqbcWakEbwqUkWWnVCDuyFl0Tn1VpoL+JwIV6Zh3rhFOX76RBChsAKvu4lpozwcsGO+jQA2CxHLJ13a/5UJHhQdhEBvcCOZB9/DSATzHfLAlj8WrjfFgTj5KUG5pZdpBXiclRk+3/0S4XQMteNReY0NbyIRmTmhK6kui7syWF73aDvZ4vz8k5Q1382yPfnuHwfIRdEWH8Ij/P8VaLHdSjEzE5kKEI/UoqxbaVNwZx62M44D8pR1muM6ecgy+pkl6vjdSiKvzGBj96cuitwJDNNNfKfGAhlNUByohSBPXnaTQ2n9DZjdFbUuhATL1bAps67+0XBeE/Frd5esRrw7xst+US0G4t6KJ X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 6:Fjek7PheQ0/uvgzWDsIlHSXRkkGOWJgx2aciMneerv6CKd1rhceP2UDZ3clh2K+xEg0aER51ToXrpHn35Djm4Z3t1SYNCNx1S43HDtdJAB5yjPn7+LKcshGu814PLu6ZRZGswVd4rIG2uo5S+932hia9wNNwergwmOmaFPxJCfwG5cs5fpKYq3E7l6aif5CAqBbaSzPQ6oLDXHHl6dEWEpLPWQPBdTL3o36waqu6BojzdextG5xhaBuiILBCnh/V6A4OAL0brccxNyjAtLxYhgkM32qnu4GG4AG1Y+Zgur+nnyhLHO2xa0bk/Ivlv/R2ANROLPTydkf8veFU6W3FcA==; 5:P9CMd6xWuSC3MzC+zmQ/3lxR74vVA5WguHWTFKbn8d/RoN4AnTFv10FilVk8F5HFg4Y4zmHIPON4hGJO+Sd6xixJTK0NYvmRcXvcpNaZq+b/MrQdMNpUhPW603qTUdwHUDJGBWyZzRRSx9/MT0ahtw==; 24:DPWZ7FGXZVvT2FwEHgrz42xfrXSGfd0H8/o0wz/XORZGOZYD44fuSQtYpfqnCG4sMTUhB7NdCFo9O5qZ+6oypYx+egKx4ZIhyiVHigHH9aE=; 7:RZZY4MoZiF5MC4GPPw0S/tsD7jHU7sz88/WXiZ5Cnd512tMFw488qlREEQL7EvpmroDCzbsQaor8A0k854A278UewJePkFOXzjvfQMDci2TVwy9kRCmg4j1HDAj/g2MiyFG2jJ/Asl20I1PrFuJWFg8uz0MIxKQfrR3UL19NBfqh8ZO6VDD9nOQjc1YWsgS4a9buzXEhNE+HRP9rIUhHgII1sgqfZOO4GUzlGDttXXU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2017 16:20:40.4992 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1334 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.57 Subject: [Qemu-devel] [PATCH v3 19/46] hw/ipmi: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- V3: - Remove left over include V2: - Split hw patch into individual directories hw/ipmi/ipmi_bmc_extern.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index abab3bba4f..8c0535d3dd 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -28,6 +28,7 @@ */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "qemu/timer.h" #include "chardev/char-fe.h" @@ -194,8 +195,8 @@ static void ipmi_bmc_extern_handle_command(IPMIBmc *b, if (ibe->outlen) { /* We already have a command queued. Shouldn't ever happen. */ - fprintf(stderr, "IPMI KCS: Got command when not finished with the" - " previous command\n"); + error_report("IPMI KCS: Got command when not finished with the" + " previous command"); abort(); }