Message ID | cfcddf08122ccaa91a312b7ae3806c664b93de99.1508390588.git.alistair.francis@xilinx.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="ipghdOx8"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yHvlD23Rcz9tX8 for <incoming@patchwork.ozlabs.org>; Fri, 20 Oct 2017 03:38:57 +1100 (AEDT) Received: from localhost ([::1]:50150 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1e5DqR-0002iC-Io for incoming@patchwork.ozlabs.org; Thu, 19 Oct 2017 12:38:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1e5DZj-0005WX-9N for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1e5DZg-0001xl-3O for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:21:39 -0400 Received: from mail-sn1nam01on0055.outbound.protection.outlook.com ([104.47.32.55]:51986 helo=NAM01-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1e5DZf-0001xL-S6 for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:21:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MLDtmzh9d3ZkTIM7UCOC88YXbJcXnS3/xvvYSfnR3OE=; b=ipghdOx85Rj6C6UJ4TWk8QMLk8k4/T+wdFeXp/TQ36ZfwViwNO1gE1be2r6HFozS29o8o2NLDcWZsioYOJU6jtMhRNc5W9prTaoCijAPGogfPpch/7PDMTeiggv8YW3vTjqPLIKnIBB3N8wfOHAQ0xQHmWOcqvpyMJAlRxueccM= Received: from BY2PR02CA0006.namprd02.prod.outlook.com (10.163.44.144) by CY4PR02MB3383.namprd02.prod.outlook.com (10.165.89.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 19 Oct 2017 16:21:33 +0000 Received: from SN1NAM02FT004.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::208) by BY2PR02CA0006.outlook.office365.com (2a01:111:e400:5261::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.156.4 via Frontend Transport; Thu, 19 Oct 2017 16:21:32 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT004.mail.protection.outlook.com (10.152.72.175) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 19 Oct 2017 16:21:32 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:38626 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from <alistair.francis@xilinx.com>) id 1e5DZb-0007xI-Sc; Thu, 19 Oct 2017 09:21:31 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from <alistair.francis@xilinx.com>) id 1e5DZb-00037b-OJ; Thu, 19 Oct 2017 09:21:31 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v9JGLNhg006818; Thu, 19 Oct 2017 09:21:24 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <alistair.francis@xilinx.com>) id 1e5DZT-00036l-SH; Thu, 19 Oct 2017 09:21:23 -0700 From: Alistair Francis <alistair.francis@xilinx.com> To: <qemu-devel@nongnu.org> Date: Thu, 19 Oct 2017 09:17:31 -0700 Message-ID: <cfcddf08122ccaa91a312b7ae3806c664b93de99.1508390588.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <cover.1508390588.git.alistair.francis@xilinx.com> References: <cover.1508390588.git.alistair.francis@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23404.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(39860400002)(346002)(376002)(2980300002)(438002)(189002)(199003)(478600001)(4326008)(81166006)(81156014)(63266004)(39060400002)(8676002)(23676002)(305945005)(189998001)(118296001)(356003)(6666003)(47776003)(50226002)(5820100001)(36386004)(9786002)(36756003)(2351001)(2906002)(106466001)(33646002)(77096006)(50986999)(316002)(2870700001)(106002)(2950100002)(50466002)(5660300001)(6916009)(54906003)(76176999)(8936002)(107986001)(5001870100001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR02MB3383; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT004; 1:pJVYL0kNnEaaG/a0IdhotGjiGE30QozY/KfsXO4jf4YdiPIgFA5Uk5/sQDH8742LzG6mgL68rENtBj3JT1vEFkn/mivDTEknXKLaFxM6Hn/jtrDZfZq0dt+yIjI2mh3E X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 635d5f7a-2a0e-406c-3a83-08d5170d7627 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CY4PR02MB3383; X-Microsoft-Exchange-Diagnostics: 1; CY4PR02MB3383; 3:ZCRGBXPiVtc0ApLTJNVAPmlwwTQEEC+fCqWCN3O8a0YL+WsrQSAatyvrir1lJFWb+pgkxKCwXFrMjJQ2OX4F3BucfDfDR+R66B/cOMjnGCgUNA8qZndYWng+YHr2jXyiuOTXXKPNmgVBNk8Y34q95ud2zEHcigc44cfci0U7lUDDah50kvEtIgFHKO7JS4fLHgS8R9fflqcU9ZRVGPXTBiXPcWajyCioa3/AH8TGPbO6mvMVQJDXDFnknn4CIr0pEZeoDMOe4Nt3DvvqrdsQkH3yccTJoWvEPrfRexU8dOlrLF51kQId1LDqmsHQgwxQJbsaTqJ2UAZZuBIB3oGP1EmoYltiWW65GjtX0OV6bzQ=; 25:AekzY+/tPwffyTjglupHhWrIrExhyzcbCLwdwaDNNUVpdabWo2encrjeQeiRZ/Aw5Y9304HKNcmiSxxQNMKLnTdhgyiN+QzdJESoOP8Mm8HuwQm4msg1BIiNrmawfbg2Lse2JglOdyEw1DqtFfWgXYMRsRHybo7YlFMY5KK92UKVe4VcJh94+WPwezkepRvq7kKJ0l+6/QolHa9z60sckacdKvehOdwSjKGgGmWSxcdO5hhvFxfTu9VMlpUT2BXK05vJ9apcifcDEHmvwyDrPrq5mZGnH7uBU+58eh4zMwztRtSxNEZDiGXTgXVeGn3++fIkIZF6JQJ1gI8oFCDANg== X-MS-TrafficTypeDiagnostic: CY4PR02MB3383: X-Microsoft-Exchange-Diagnostics: 1; CY4PR02MB3383; 31:mNVIUItW0TYbYZ05TJQUTWJjhwNx2+2zRyJn66RJ8qXX8HjQb8QrlNxhSAXm/9QCNDHKwRRw7YeelMh0ip1xiloVLF7XaiF9YvxJrPP+so0F6QEN0VPdAj5VQCHQ2EiGtaUXA8oVmlN43KQjy6q0nVKdQ4iRbtgjBmeACaZziCkRNF3O5DJj9yALNUN4oCwBZ0cQR3TVs9yNK0Zf4X2Fjj7J2+HUUey1fNuRTSJus0I=; 20:Dn4ZGgvqtVspZ6wp8+i9+EzhQ+sESY8lRJsxkAlRRZmwFTtN4K82Iy7R+KtMTKCvUgbfeanUijcWDMmWZ92yuX2jTskA1fHwjob7xW6bD1pVfiMGtKclWNUeHiy8QqcKFijK9JDBr4J56CfiZD9uLpqLZYKf3oQ6txvYspaTYPneqaxu2xNFRjNHaQYwDjYiK29gvKmmQAYIB+BhHwgtnd7jGV0RrdFa/KnsTMkBrcU6Vr5xnvjjUXwj2PisTRKlDgtmVowv8kgN+lIC7hkdAb+kqYYBcSc6Jyp8YKg/g86VjYow58FUfuKRo2LawRnT0XR0G32sM5TotsyVzGTnt7ACwXgOSWyMEB/a8WKZBoZKXsa74HJq+qyw/b0x+J/WT9oIQXuKFoLSGINQxTxiluMbMd1AqTFnMM+x2mRD1UhxIET8UhNN2QzWx8uUY09sxro/2JAIYu+yBW7WMi7uck24DX5N5B+KzqT+omZpm2vW6XGl4wi5O5eqCdREvsAL X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: <CY4PR02MB3383CCD4D28AEB58D4C2062BDC420@CY4PR02MB3383.namprd02.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93004095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR02MB3383; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR02MB3383; X-Microsoft-Exchange-Diagnostics: 1; CY4PR02MB3383; 4:ggqEXfqUtQABeKNgQ1WfBdVhWsujQ8L+q70E+cHAAFn6yeJhU2EYDzMb1aTUDYB+wLeScORBpXz2clM8Lx4bYHXaulH6+nN5f6UPBbhGIgU2DhenhqsFv5cE7Y3Cj4K8vJXPC09uW3W7V2jOcsCj7+KwBCr8GF0DEVFQr0KEWcllJH3WsI4de5nPEZfyGzgE9B9Vk/qv4Q69xHHRHmT1lt190i4BLFTEVpkVVmHbCj5II31V4LbSYRjIknpUI9VgYz7mJQH2YNRBMpVGFprMJZfCJCTRTXZ2kyOf09klZ0TyLXUX7SEqAco/Vb4C/CucWEPi7B5Y+jyVOwXqDFhNRw== X-Forefront-PRVS: 0465429B7F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR02MB3383; 23:bS/AZdS4YrrxmUgKHGjF66V4gvdk5A3e6sG/AAHtr?= ICXE2rR6OGLyhz03d+QIFZoerDCUC1SkLeWNDG6jgFSRQ2hBDvDBD6mZQclhX47M32EStr2sO6pBMa9JlCnew092QTKCGTj5DbBLRP1wBb6etSL+XK7oJS5pCNd9DKV1Mw22X/hWRN2dZIaxxqWoTqgzQujHwHKHXE9hxoxJM0gMuhmWNoea3G8hnodu5m8hb9DsbLUUfbuohbLiJ02X3xRSSs4bCXT4wbUeNb2ChJLfIM+VcdACzDOJAsILGHVHEeWESakJ2Gs99fwMzmBrvOoVulH60IY+NTOxqR9so1SMu/RC62ZeXJTjSyGpYrtLYMfQUitgbjRo2AoUqyiHGEYO9Axd+k6dMyqWNnySGQ0ol6UrC9VGWEnsIQNRcTpqHwXeDwJOPigxarHiOh6nuw/nkg6rtnwwlVsZDvAjJ64HtIT7P/Lbwbs/3sRRZ/4P4FKTcuJRyXYY3uPTkSq6q35v4O4dqbHo9tlqwFFXUMcZmDgC+z76Pg186+HwVtWN6JWGcReom03I1ZNmWNHoylM6lHhj6A9YBSTRqebfYLwZG9WchjZE96sOOlLllGSOt8ObqbOfrHb4Dx5DewoaZ4AC6gjHPcBymQToUKX/uH5SOxG5AaaY89lovVQXd/lx+pqwmV7yTQoD7EZqQI+eS/5/pDh0gziMW/gJLnaASUy9D2JkWA88Ct6rNid9/qLLcfloD5FVtkKQggMVS9nP2EYADTgG84LNVlGv1qlbqond65Mb1LSm0eIBvKMKrj/KIU3kOPMDfQBXU8fEX94GFZesP076vnPV5oJcRjUOLV2Oa3I1XOZEwtWay/7h2sL4tMbshts5AnpBAqzFtcaViquq6CWueqPIAesLgHuri4tVhJ/mIIexk92xVWmAw3gjuvhuzQXIMEUQhkxc428pP9Yretwl5faxqsPplydApRRj5O0hR4S2PBqrIjcCy8IDI1eVo/TxwZViT/TPpl0UT6AQPuASaro8Z1lCWYniHx2asuEx5VDNg9OC+wTyTsbAP58ax6SVjUnv39Afp0EQBfy+FnDa9AOVBoy+4UOQh8kF4IfDYrMqOyfkXUFiun2ahEURX5Q4JSay6q3WoF452hQ1jdXI0tqnMlnQTnFP6iIiNoJkv6OZNTtYc7jlWEte30= X-Microsoft-Exchange-Diagnostics: 1; CY4PR02MB3383; 6:qYiPyq9+yM6q7Y2MolAiq0N2F+GoDpy2Ce3aH/ptwsxVK6WvPhbqlX5mlKrA8aFnMRCPNdKFz4UhpJ18Ydare/haf2qhfzvMJacw3AovyFSYmyFX4d6kLG4+uoRl8SeihPdRlEnw319Ob+ESGZ3Ecs7Q28fGTkzLRccWTK1RiVCw2Vn4F/kH6jSYMZ0gVHOllqD56UXN+XMGXP18prrBFLpVzpFOl7h75ROQDfg0jUzjVvsRr1jq0UyrkhZJe8cgMCyU7JY/BGwx4NfewUpAaVX1nAPWq4IYKOlhncodxfAXVzrsrDvgmO/gnEyKqcj+Q61qWNVLJ3FG7jusRN6HQw==; 5:O5bGTqHbzsXZpoA5K78/pIEGyMttmfPyPKiOfkeQXP3YAe1ZaR8gZqyH9LNdDG77sod+e74JCQW5ZnoWVynsVYXzQUjLThsWdawbxhfYNoweVMPzXOR523LxxW0DbXhbzak1E+fMbDCnhEVmJ3uAIA==; 24:O+Pb/WLQCQsNwXi2wRrm2JLnw59N7fsEpkm9DvDhh7zHMrRKyD3QSsF0Mx4rcNE1iUkTI+12ITol87uX8F0aQuhYwIDYcKHC1E9MFrQtcXE=; 7:50vaRqPQEpfrwr/BP+ww4VOU/BwTtYptxhbwgvynjXlprXbq9muEmBUcOGmmykZpHixDWYT7XM5K0q5LpggMZuYY/kCXhQWwWeqm/nAWd52rWn8ULXe+ieHBRM04AAFkhFAcLGcAE7NfhUSTsGtns0vndP4U6eS2khgOaQJJsXlS7eZpbpUNZa8NnyCr9JF4O/2O9GR5oZUXvuof0rmqeAfwR66x14IszuzF/vqhPso= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2017 16:21:32.4432 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB3383 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.32.55 Subject: [Qemu-devel] [PATCH v3 30/46] hw/pci*: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Marcel Apfelbaum <marcel@redhat.com>, alistair23@gmail.com, "Michael S. Tsirkin" <mst@redhat.com>, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
Remove some of the fprintf(stderr, "*
|
expand
|
diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index 2ebeab5d90..6f2e589bee 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -38,7 +38,7 @@ */ #include "qemu/osdep.h" - +#include "qemu/error-report.h" #include "hw/hw.h" #include "hw/pci/pci.h" #include "hw/i386/pc.h" @@ -449,8 +449,8 @@ static uint32_t bonito_sbridge_pciaddr(void *opaque, hwaddr addr) regno = (cfgaddr & BONITO_PCICONF_REG_MASK) >> BONITO_PCICONF_REG_OFFSET; if (idsel == 0) { - fprintf(stderr, "error in bonito pci config address " TARGET_FMT_plx - ",pcimap_cfg=%x\n", addr, s->regs[BONITO_PCIMAP_CFG]); + error_report("error in bonito pci config address " TARGET_FMT_plx + ",pcimap_cfg=%x", addr, s->regs[BONITO_PCIMAP_CFG]); exit(1); } pciaddr = PCI_ADDR(pci_bus_num(phb->bus), devno, funno, regno); diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 5ed3c8dca4..948d4e04ee 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -525,8 +525,8 @@ static int get_pci_irq_state(QEMUFile *f, void *pv, size_t size, for (i = 0; i < PCI_NUM_PINS; ++i) { irq_state[i] = qemu_get_be32(f); if (irq_state[i] != 0x1 && irq_state[i] != 0) { - fprintf(stderr, "irq state %d: must be 0 or 1.\n", - irq_state[i]); + error_report("irq state %d: must be 0 or 1", + irq_state[i]); return -EINVAL; } } @@ -688,7 +688,7 @@ static PCIBus *pci_get_bus_devfn(int *devfnp, PCIBus *root, unsigned slot; if (!root) { - fprintf(stderr, "No primary PCI bus\n"); + error_report("No primary PCI bus"); return NULL; } @@ -704,7 +704,7 @@ static PCIBus *pci_get_bus_devfn(int *devfnp, PCIBus *root, } if (dom != 0) { - fprintf(stderr, "No support for non-zero PCI domains\n"); + error_report("No support for non-zero PCI domains"); return NULL; } @@ -1128,8 +1128,8 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num, assert(region_num >= 0); assert(region_num < PCI_NUM_REGIONS); if (size & (size-1)) { - fprintf(stderr, "ERROR: PCI region size must be pow2 " - "type=0x%x, size=0x%"FMT_PCIBUS"\n", type, size); + error_report("ERROR: PCI region size must be pow2 " + "type=0x%x, size=0x%"FMT_PCIBUS"", type, size); exit(1); }