From patchwork Tue Dec 12 18:54:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 847603 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="VW8aZPjm"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yx8Mp6Csnz9t3F for ; Wed, 13 Dec 2017 06:02:30 +1100 (AEDT) Received: from localhost ([::1]:60038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOpoz-0004kr-1k for incoming@patchwork.ozlabs.org; Tue, 12 Dec 2017 14:02:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOplK-0002UH-LO for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOplG-0008Q4-RO for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:42 -0500 Received: from mail-dm3nam03on0063.outbound.protection.outlook.com ([104.47.41.63]:61155 helo=NAM03-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOplG-0008P0-JD for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UL47o2+CIP2+8fiiwdRAJNhk6FCxEx4hmCAhpdlfEAI=; b=VW8aZPjmyv9pDmoVXNKVDE+8jtheLOkPG4NuzQn+hFCtuRioIGXC+fTObLaDJq9JTM0nI8cifV7QS4TMKDcADBHS1hZjIKzT9uYJ37EAeG2tnC7/GT1AC81S9rN1N4SZaSbDTd+zKn99ZmK5xim0i3gFKDNj4vAVDeBeW9OLGEI= Received: from SN4PR0201CA0016.namprd02.prod.outlook.com (10.161.238.154) by SN1PR02MB1344.namprd02.prod.outlook.com (10.162.0.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 18:58:35 +0000 Received: from SN1NAM02FT010.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::203) by SN4PR0201CA0016.outlook.office365.com (2603:10b6:803:2b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Tue, 12 Dec 2017 18:58:35 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; adacore.com; dkim=none (message not signed) header.d=none;adacore.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT010.mail.protection.outlook.com (10.152.72.86) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.302.6 via Frontend Transport; Tue, 12 Dec 2017 18:58:35 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1eOplC-0003FH-QK; Tue, 12 Dec 2017 10:58:34 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eOplC-0007hl-Nk; Tue, 12 Dec 2017 10:58:34 -0800 Received: from xsj-pvapsmtp01 (smtp2.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vBCIwSHi032227; Tue, 12 Dec 2017 10:58:28 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eOpl5-0007h0-TD; Tue, 12 Dec 2017 10:58:27 -0800 From: Alistair Francis To: , , Date: Tue, 12 Dec 2017 10:54:18 -0800 Message-ID: X-Mailer: git-send-email 2.14.1 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23524.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(2980300002)(438002)(199004)(189003)(9786002)(63266004)(77096006)(39060400002)(4326008)(36756003)(54906003)(106466001)(110136005)(356003)(81166006)(16586007)(7696005)(2906002)(305945005)(81156014)(6666003)(50226002)(2950100002)(51416003)(47776003)(8676002)(76176011)(8936002)(5660300001)(106002)(478600001)(36386004)(2201001)(50466002)(48376002)(316002)(118296001)(107986001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR02MB1344; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT010; 1:EoP0viZ6t9Gjgbl33F+rVN2gBxMxC336OyLgjKwDje296p4zEwBsVKhJ5JwZFWsipnLIBkwm4v+UxicZqRMB5h59wACfKrwJrZO67hQ11syAITaMnOKhPp3/dChkjjBy MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55f22089-b4f7-4844-cc16-08d5419258cd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307); SRVR:SN1PR02MB1344; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 3:zJ1jELdKO5qhxPK2lf4kQNPhgBPRaZAOvOEE4SOCBXUwlII+ANCqKvKfK61X4YY4Dn5JceHE4qezOeKqF2feIz/CxVMYY6m+fsuXkRE0mGeCPXSmBBp4HAtmqeDj+hIQ8nA/AlDndEeLBkz0k5ezCxFb6L01VKfSzWMloo0Mia73TrVtNd/bSVedBg19m64gESmhJeUKA58XI26WTIzyUVx4tTbKnFOgqtUiMLA03Va01MHrqQSxsKi7gEPQcrax4bwrAhN4bQPZ/xVaDnVnSzI8SOE6u9igxOuYt1xLw8wAhb8EEF/ZgqWnV8O6YzhoMFNFFEKhnWPLL9gBq+0L9YLa0isatlkMI9dZxiB1qvQ=; 25:mOXvd0LAGC7wcfAa4aKL5xrnpsIh0FZMKqwsvzTqi1pD7h7SI6AQF30406oMK9Kit9kunPnq+fTSzUzmz2EreM5eS58EgPSN192eIi4MtDFTEZgWni6LsCY0ZWqEoxzGk9aaCgXKKGDOiJ4hCfuvN+eknZYEEhcPGQerv0Khd9YsD+ynd3XQKHFdEAlYhPG0Q5p1Z905MyiIPM05cpJXJuPgzU5R5QwzCXQY0FXEhXNeLqnYa14vR63CowvVSBUpg8PI4VYdyARhiI/QAa8AMqgUvSId0+5uZhb+xPasWAhSK44DW3Gy+qHA9LGjnDcgdTMdKrtyAWEvCUtS+OTr1w== X-MS-TrafficTypeDiagnostic: SN1PR02MB1344: X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 31:pUXyA7z6CsKJnFeG2E3MzLSZA8+aAfCI/lIVYbzjqkl2+qNR6uk8nKTJpZWZSS6vhLO1Pewm2h4QOSRZeNUvEOlc6ie9gH2eOR8ojXwPeVoAK4Mr1cA4hOax8+kU7MechhVyaTesGOwoeMfUFvWhJro6yws+r4oviCIOvZkbwCgQpsiGveezkXXAFu9jDLv+crk+lf3r+QjIf9wwDsMD/JNByUFTQTkQsgjbGINtLN8=; 20:fll73IjkE/QjO8YYe0/jr+6X6yam1SiOc0WWouU5RrC7yilwUs++0p6c9swvAMs4ywPS3fIeZ+ecXSmbPWH1pNoxzgQwfejo0d9njwcWN/V1KniChlqwLjbw3kdEt0X/onPkNe49rGFauyrWbmP74VPWnw/lGr3q6O+snu59ImbcMPEU9UlooT6Xw25lxl5NfRfZIbq2lc/bMFui31/C2qyIYHqM8PclN+6AD1bxY5nq08Ki5uxymkUzJAqsOalC0ZoMUof8KCtWTkzjponNz0PJRw4NgkRZTcPat9/Qhjb9WEt9e628j1381e/oI3AQRNUWme+htkzMAcNSb+C90XqXOiVjN5UtPFWsRxZWkfbcSLvi13yi5O5Yw7OemZxR8X0r6V/kWgox6Mr2sLW0L8/4jTM+HVNMmkwIzXqh8S6ULq8IDJSmqaf1rsJndwWAS9I++O6qYa6i6bOPjuQce6QH6cTze3eibqgfN/iV5uqcxOM2/+qmb9ru+agHMcOY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(3002001)(3231023)(10201501046)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011); SRVR:SN1PR02MB1344; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN1PR02MB1344; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 4:p2uJnztlEU7l8nBO3uwlOIJsTPb+9OxkrpOWNMgc/X8ofemYQMh2RI/FDp0a0xh06JEZx1Osz6WFBuqm0vffY2J0b1x6XZ6Mnq3YoNSRddqDGDeDNFP5liEYX4Ng3yXyH/7Cu5EGzJrmqEaJc3ud/BJIsnKctgufWaqnJkSZpyVjgpaTew6Qz/kTMITZNSaKFmEOCjjzj3YS+p9XhIv0ixFFL8QFz1UytbBlPxiYxHSU9EI7Jp/8w8IaEcDs2OjoPKZa1caSqUuoU13nyxYcRIL0AV/v7dWHCFMxGYLTSOXBCnjOzL0of8JChtp4kXtL X-Forefront-PRVS: 051900244E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR02MB1344; 23:G1dejsxJ1IrUFHbkVEsCEAYSeyroQJrDYZyBJjxYD?= xXFm85PzaqIU4tW4/bALxkO1SgQzFhwK3fAEWObguT9gRF6AZjbjkI7U63K5fO3ahutZLH2m3ASXzgFpFJAYMumjpEucXOBE+nh8pHXc01Kqd6c+FTT8xzT0QvIZ/3iuXr9ADtNXloBAi8XyrsuI2mZZ33dhFKWdrhiTpw9iNVXU56lEUImcDrBrYn7NapqJtLOmy7EDzpE6uUBSiB/bAmUBX4Ce737oOyNVz3ZU+zZDL6XHgoYEEVy2wzc6Mm+vwbRny1DqZ+Kqj9A+QGMCyNOyqqCyLZZXMINKzo8dxzSSIbf6ObYc9cvHmXycMJyheQKU+zeiohU2+57OJnIAOPbDR6IdFs7I/YH/uxztIJ5bezrnEG44bJV4gVcrwejdvGkpGS54ZDbIda55BYhi2+McrqQVcUpP5cJUt5muuk0W7yb8vN10UZXEG4RaaPGqpMs+VXOYADucgQVFMkeHYX+TgPc881c0UEV+6mPo+bNPvU/9L/OUW8pdn6+5/631/fyrMEN3XvA8guSGh3MKtqh30qsCKD7+Uio9mEllHkg2ra7v8pon2Wbyy3QR3u82++ICDgdtpt1Xke0hkhZwnlePmji+NzLVv/WEr3EcKAexXVMOCIdxk3WsDzBo0RFXr3Ifb2lRMEuprfSDtceI4JKVskc7u3jtPEKXkq9pdB6cRvI3x6ZU9q0v2450jr3KHaIZ1rpOioMTV+oWQqxKwqscngLphYyz8Mv11CeO6KLh59+6XRU3sJiDSHucUiv+XAWPK1XkxLVQ4uEHQ/4iMNSmlDSdzfW2fZxm021RE0ol1U8VXyIssIge17cVKeiJyiSIFy/yyod/NvEe6ZGkRZ3erByhWM/pAMjvzOk/VR9EbUcO01Mr9IMc+W+lnttop0+ckjRugME+5fO4JSt9GiDfnq1pacS79+B6u8+l1w2+j97AKur//VhiLQRMRf3umQ= X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 6:KYPvOvgaZNZBLLddUP9HqnOC8DfZKsqWDxefCpcdG9/bei/HsBR/qF/iTQGPjvRgeqxrhJzIM4ITlDBg60IZx/2xOl3PjbtorcoO86ghPkdAby8yLNWRWN3zDUkj7oOrufuLWB2AsHNk9M+fdJaEDpzRk+0JT9LryHhAhBeYEZBN3xBNDAG0MM9eKWni826a+8jca3UBrSpFM9G/QNefnBI6helpHABJF7RwxVD96otThI2CU/I+A8BBaZl/WscCbky5OmPLgDt928kqytZ3+/LSCnWQRXtDPqCxaUBmZNvM7O1+Yj4NNLrLFMjruq1BJNqWhURCRwCEwaIU7YO/MKKip9IxlWY6e2x4u/qmXR8=; 5:GMoL3ZlGXkh5/J4q2xA1uPxl2vcCkrZyrpJT5HjiDPFARyKMdCKYCdyCPAapRLxqDelIca+F/C5NnpPgJTIl9+arz8OZIdHc1PRC/cGf73abA4VtwHpYvFTzstrDwvWvZMy9Bda0MUvhBJlxGIb/oIzAPgWpsv3C7Y6FhWJSDRw=; 24:htqW2cFQN6KiHBBnQjyTyBYGgMgRiNSdpKQl+3aCv974xGHzF27ECP4yvvh6tWAsr8/Z7YPKIG5r3yfFCKlNPYQoI6w2eESoPpoQl9s6pBw=; 7:W8Fe38kgyKwyg4w1+Uc2GHSSJ+pgH8UH8LFAi926EXRx7LA/qFevwPNItNM2u3G/zHap6Dbk71sItw/0Aam6Hj3dbAOcnjLj6Bu1IEzwElDpSeYQHsPD2rNPxPrhu2O4rnwZFI3Ea5Dhb3VUM+Omt3MjVeKHAqEQ/+LcIy1oBuZeAzV7QvnRBGMDw6nwvofBvwtGI8QEGV76wcyvvMlHD4ZJwKos21WO7xEcrG85iRPMlysKfsIlEBvLPo57wUaN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 18:58:35.1674 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55f22089-b4f7-4844-cc16-08d5419258cd X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1344 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.41.63 Subject: [Qemu-devel] [PATCH-2.12 v3 3/3] xilinx_spips: Use memset instead of a for loop to zero registers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, frederic.konrad@adacore.com, frasse.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Use memset() instead of a for loop to zero all of the registers. Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 42d9b04bd3..d8187fadd1 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -329,10 +329,7 @@ static void xilinx_spips_reset(DeviceState *d) { XilinxSPIPS *s = XILINX_SPIPS(d); - int i; - for (i = 0; i < XLNX_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); fifo8_reset(&s->rx_fifo); fifo8_reset(&s->rx_fifo); @@ -357,13 +354,11 @@ static void xilinx_spips_reset(DeviceState *d) static void xlnx_zynqmp_qspips_reset(DeviceState *d) { XlnxZynqMPQSPIPS *s = XLNX_ZYNQMP_QSPIPS(d); - int i; xilinx_spips_reset(d); - for (i = 0; i < XLNX_ZYNQMP_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); + fifo8_reset(&s->rx_fifo_g); fifo8_reset(&s->rx_fifo_g); fifo32_reset(&s->fifo_g);