From patchwork Sun Mar 21 23:31:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Straub X-Patchwork-Id: 1456334 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=web.de header.i=@web.de header.a=rsa-sha256 header.s=dbaedf251592 header.b=HldLYBfn; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F3Ynj3Wr3z9sWF for ; Mon, 22 Mar 2021 10:32:25 +1100 (AEDT) Received: from localhost ([::1]:42504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lO7YV-0007zS-Hh for incoming@patchwork.ozlabs.org; Sun, 21 Mar 2021 19:32:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lO7Y5-0007yO-7V for qemu-devel@nongnu.org; Sun, 21 Mar 2021 19:31:57 -0400 Received: from mout.web.de ([217.72.192.78]:50867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lO7Y3-0000Gh-9G for qemu-devel@nongnu.org; Sun, 21 Mar 2021 19:31:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1616369511; bh=g96QoTGwedFUXA0fm9qRHfwgSpJ5sKc88uQ9mOYbs8g=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=HldLYBfnwi/K6EMLBLsNFThCJvvRXoNQ/MaQVybK1DBp8sswnUBpROay0kfcukKvq xXNPj8jBrprHmLhSg/qKqASmTbme1d5H4swnZdAOlrdV9dJV/3ok2gCDTNVSPL6ZAO TlZetMq4CR0D8hsTDVLfb6nBxo37bPRIYOZ/ukY4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from gecko.fritz.box ([94.134.180.131]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LfAoO-1m3o5P0R9U-00omLQ; Mon, 22 Mar 2021 00:31:51 +0100 Date: Mon, 22 Mar 2021 00:31:49 +0100 From: Lukas Straub To: qemu-devel Subject: [PATCH 2/5] tests: Add tests for yank with the chardev-change Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Provags-ID: V03:K1:uBbVE/AGt6Cs/n1SLeOx7krvvnF1f2SiUvcmPVjMKH325m8ypIL 8HDXMcGIfdCtJbD424GTZKzaUb96B6XoMYH85a9cJjxx8WAgfCQO+vJWTK331WY26nr1DT+ nrTmWP9C0Z59swCDB97hcLrmbv8zF+ECb+TAgNjcgGr59W5B8ZZ63UNxs+ezHeyAPdqZ4T7 eiZGbUSvbUp2Es48mPekA== X-UI-Out-Filterresults: notjunk:1;V03:K0:5WIsvmLIz/4=:1IBQmfxnOCkHfc5bUSf6fy 05+f5jQ2y0tPwCKvgNnmlwyyorUPbBeADsUkCHt/Q/HCx0Jbe1y/k9aNCAoqISZstpIbfMZgL IAckN6EJ1YqRw/C17itkqN6oL56xLOaxihnyHCVLwgPo5UiqKrFOVnQY/qLQfQgIqeYD88HMg shzoY521bQduu/Ft2VGDEuCvtdOlr0iPUaoRCfvWfCPitYfx9MBo1QDJDgn1/yDjrMaPBXkY0 EuRzvFHCe6aYyf1WPwKBjQiw7mXEyJ+VfHQqes2muk6ji8jNytvYvuUGUICrqHPXK0bBDXzNb 1qAbxGk0TQ1Im1MS1RHvOjzUoBkGYW6OmD/AZd5e1/O+v/UuMyX1oe92U9rXCv17xWS7TNBpr CceVjNW+B24cWfMmoHIR2NVANH7mCBqCPkhBwbGrFINAUh1a61rdztu4uS1xLcfti2sHjWH7+ 5cztiVuWQg3FLYwBkgjqAk+HOVa0tr8oN7qwqkZn/O/df05inn1+zslM6sUQs9T8BYiGJmoMZ LfSncZm1Uxq5mm8r6jWXbkfvE7bVaDERRIGgc1JLVYCQsryNRJPLwGa5gplaoGVcrTcFykBT0 7ryI9/hkqUg9b41j1kfFUD6/M90+ebEg2K6e8kVsMxYG8NGOeY8TKcgC94Ld6qhCRdWOK2/mk CCEEffXJ4HFwANAnqCeteRdswRM2fSALw4yEeoxTIzVlinAHX2yCBm/ROxE2k53rtFAlsA5wn l3jP8GVNF2hUDk0jmx3ulZFubSTYYTA7HL6C/el5aXJmh5B2ZJWTl0v0ZDtPxXsM9TJ7TLxIp qWImah9BvgfS4Dzk8gW2qhtydcc9yh545NOdv6oaFo4dGqv9j9gIe8fQAw3p9L4CUJtQYuVlo Tv1KTCr/Eor/BrkGMR7cskgYj2SngW5DPfNE6e0yo= Received-SPF: pass client-ip=217.72.192.78; envelope-from=lukasstraub2@web.de; helo=mout.web.de X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Marc-Andre Lureau , Thomas Huth , Li Zhang , Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Add tests for yank with the chardev-change case. Signed-off-by: Lukas Straub --- MAINTAINERS | 1 + tests/unit/meson.build | 3 +- tests/unit/test-yank.c | 240 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 243 insertions(+), 1 deletion(-) create mode 100644 tests/unit/test-yank.c -- 2.30.2 diff --git a/MAINTAINERS b/MAINTAINERS index aa024eed17..a8a7f0d1c2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2817,6 +2817,7 @@ F: monitor/yank.c F: stubs/yank.c F: include/qemu/yank.h F: qapi/yank.json +F: tests/unit/test-yank.c COLO Framework M: zhanghailiang diff --git a/tests/unit/meson.build b/tests/unit/meson.build index 8ccf60af66..38e5dba920 100644 --- a/tests/unit/meson.build +++ b/tests/unit/meson.build @@ -123,7 +123,8 @@ if have_system 'test-util-sockets': ['socket-helpers.c'], 'test-base64': [], 'test-bufferiszero': [], - 'test-vmstate': [migration, io, '../../monitor/yank.c'] + 'test-vmstate': [migration, io, '../../monitor/yank.c'], + 'test-yank': ['socket-helpers.c', qom, io, chardev, '../../monitor/yank.c'] } if 'CONFIG_INOTIFY1' in config_host tests += {'test-util-filemonitor': []} diff --git a/tests/unit/test-yank.c b/tests/unit/test-yank.c new file mode 100644 index 0000000000..44f24c45a8 --- /dev/null +++ b/tests/unit/test-yank.c @@ -0,0 +1,240 @@ +#include "qemu/osdep.h" +#include + +#include "qemu/config-file.h" +#include "qemu/module.h" +#include "qemu/option.h" +#include "qemu/sockets.h" +#include "chardev/char-fe.h" +#include "sysemu/sysemu.h" +#include "qapi/error.h" +#include "qapi/qapi-commands-char.h" +#include "qapi/qmp/qdict.h" +#include "qom/qom-qobject.h" +#include "io/channel-socket.h" +#include "qapi/qobject-input-visitor.h" +#include "qapi/qapi-visit-sockets.h" +#include "socket-helpers.h" +#include "qapi/qapi-commands-yank.h" +#include "qapi/qapi-types-yank.h" + +static int chardev_change(void *opaque) +{ + return 0; +} + +static bool is_yank_instance_registered(void) +{ + YankInstanceList *list; + bool ret; + + list = qmp_query_yank(&error_abort); + + ret = !!list; + + qapi_free_YankInstanceList(list); + + return ret; +} + +static void char_change_to_yank_test(gconstpointer opaque) +{ + SocketAddress *addr = (gpointer) opaque; + Chardev *chr; + CharBackend be; + ChardevReturn *ret; + QIOChannelSocket *ioc; + + /* + * Setup a listener socket and determine its address + * so we know the TCP port for the client later + */ + ioc = qio_channel_socket_new(); + g_assert_nonnull(ioc); + qio_channel_socket_listen_sync(ioc, addr, 1, &error_abort); + addr = qio_channel_socket_get_local_address(ioc, &error_abort); + g_assert_nonnull(addr); + + ChardevBackend old_backend = { .type = CHARDEV_BACKEND_KIND_NULL }; + ChardevBackend new_backend = { + .type = CHARDEV_BACKEND_KIND_SOCKET, + .u.socket.data = &(ChardevSocket) { + .addr = &(SocketAddressLegacy) { + .type = SOCKET_ADDRESS_LEGACY_KIND_INET, + .u.inet.data = &addr->u.inet + }, + .has_server = true, + .server = false + } }; + + g_assert(!is_yank_instance_registered()); + + ret = qmp_chardev_add("chardev", &old_backend, &error_abort); + qapi_free_ChardevReturn(ret); + chr = qemu_chr_find("chardev"); + g_assert_nonnull(chr); + + g_assert(!is_yank_instance_registered()); + + qemu_chr_wait_connected(chr, &error_abort); + qemu_chr_fe_init(&be, chr, &error_abort); + /* allow chardev-change */ + qemu_chr_fe_set_handlers(&be, NULL, NULL, + NULL, chardev_change, NULL, NULL, true); + + ret = qmp_chardev_change("chardev", &new_backend, &error_abort); + g_assert_nonnull(ret); + g_assert(be.chr != chr); + g_assert(is_yank_instance_registered()); + + object_unparent(OBJECT(be.chr)); + object_unref(OBJECT(ioc)); + qapi_free_ChardevReturn(ret); +} + +static void char_change_yank_to_yank_test(gconstpointer opaque) +{ + SocketAddress *addr = (gpointer) opaque; + Chardev *chr; + CharBackend be; + ChardevReturn *ret; + QIOChannelSocket *ioc; + + /* + * Setup a listener socket and determine its address + * so we know the TCP port for the client later + */ + ioc = qio_channel_socket_new(); + g_assert_nonnull(ioc); + qio_channel_socket_listen_sync(ioc, addr, 1, &error_abort); + addr = qio_channel_socket_get_local_address(ioc, &error_abort); + g_assert_nonnull(addr); + + ChardevBackend backend = { + .type = CHARDEV_BACKEND_KIND_SOCKET, + .u.socket.data = &(ChardevSocket) { + .addr = &(SocketAddressLegacy) { + .type = SOCKET_ADDRESS_LEGACY_KIND_INET, + .u.inet.data = &addr->u.inet + }, + .has_server = true, + .server = false + } }; + + g_assert(!is_yank_instance_registered()); + + ret = qmp_chardev_add("chardev", &backend, &error_abort); + qapi_free_ChardevReturn(ret); + chr = qemu_chr_find("chardev"); + g_assert_nonnull(chr); + + g_assert(is_yank_instance_registered()); + + qemu_chr_wait_connected(chr, &error_abort); + qemu_chr_fe_init(&be, chr, &error_abort); + /* allow chardev-change */ + qemu_chr_fe_set_handlers(&be, NULL, NULL, + NULL, chardev_change, NULL, NULL, true); + + ret = qmp_chardev_change("chardev", &backend, &error_abort); + g_assert_nonnull(ret); + g_assert(be.chr != chr); + g_assert(is_yank_instance_registered()); + + object_unparent(OBJECT(be.chr)); + object_unref(OBJECT(ioc)); + qapi_free_ChardevReturn(ret); +} + +static void char_change_from_yank_test(gconstpointer opaque) +{ + SocketAddress *addr = (gpointer) opaque; + Chardev *chr; + CharBackend be; + ChardevReturn *ret; + QIOChannelSocket *ioc; + + /* + * Setup a listener socket and determine its address + * so we know the TCP port for the client later + */ + ioc = qio_channel_socket_new(); + g_assert_nonnull(ioc); + qio_channel_socket_listen_sync(ioc, addr, 1, &error_abort); + addr = qio_channel_socket_get_local_address(ioc, &error_abort); + g_assert_nonnull(addr); + + ChardevBackend old_backend = { + .type = CHARDEV_BACKEND_KIND_SOCKET, + .u.socket.data = &(ChardevSocket) { + .addr = &(SocketAddressLegacy) { + .type = SOCKET_ADDRESS_LEGACY_KIND_INET, + .u.inet.data = &addr->u.inet + }, + .has_server = true, + .server = false + } }; + ChardevBackend new_backend = { .type = CHARDEV_BACKEND_KIND_NULL }; + + g_assert(!is_yank_instance_registered()); + + ret = qmp_chardev_add("chardev", &old_backend, &error_abort); + qapi_free_ChardevReturn(ret); + chr = qemu_chr_find("chardev"); + g_assert_nonnull(chr); + + g_assert(is_yank_instance_registered()); + + qemu_chr_wait_connected(chr, &error_abort); + qemu_chr_fe_init(&be, chr, &error_abort); + /* allow chardev-change */ + qemu_chr_fe_set_handlers(&be, NULL, NULL, + NULL, chardev_change, NULL, NULL, true); + + ret = qmp_chardev_change("chardev", &new_backend, &error_abort); + g_assert_nonnull(ret); + g_assert(be.chr != chr); + g_assert(!is_yank_instance_registered()); + + object_unparent(OBJECT(be.chr)); + object_unref(OBJECT(ioc)); + qapi_free_ChardevReturn(ret); +} + +static SocketAddress tcpaddr = { + .type = SOCKET_ADDRESS_TYPE_INET, + .u.inet.host = (char *)"127.0.0.1", + .u.inet.port = (char *)"0", +}; + +int main(int argc, char **argv) +{ + bool has_ipv4, has_ipv6; + + qemu_init_main_loop(&error_abort); + socket_init(); + + g_test_init(&argc, &argv, NULL); + + if (socket_check_protocol_support(&has_ipv4, &has_ipv6) < 0) { + g_printerr("socket_check_protocol_support() failed\n"); + goto end; + } + + if (!has_ipv4) { + goto end; + } + + module_call_init(MODULE_INIT_QOM); + qemu_add_opts(&qemu_chardev_opts); + + g_test_add_data_func("/yank/char_change_to_yank", &tcpaddr, + char_change_to_yank_test); + g_test_add_data_func("/yank/char_change_yank_to_yank", &tcpaddr, + char_change_yank_to_yank_test); + g_test_add_data_func("/yank/char_change_from_yank", &tcpaddr, + char_change_from_yank_test); + +end: + return g_test_run(); +}