diff mbox series

running TCG tests for xtensaeb

Message ID CAMo8BfLnjCQfjotBR4QoqwT_8WnBt9rX3oBKkLMKO5SkveU6gg@mail.gmail.com
State New
Headers show
Series running TCG tests for xtensaeb | expand

Commit Message

Max Filippov Oct. 2, 2021, 4:33 a.m. UTC 
Hi Alex,

I've tried to use

  make check-tcg CORE=test_kc705_be CROSS_CC_GUEST=xtensa-test_kc705_be-elf-gcc

to run TCG tests for a big-endian xtensa core. I thought the following change
would be sufficient to do it:

---8<---
$(XTENSA_SRC)/*.S))
---8<---

but it turns out that tests/tcg/Makefile.target uses the following
code to load target-specific bits:

-include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.softmmu-target

and for big-endian xtensa TARGET_NAME is xtensaeb.
However all xtensa tests are under tests/tcg/xtensa, so
Makefile.softmmu-target isn't getting loaded at all.
If I replace '$(TARGET_NAME)' with 'xtensa' in the above
line everything works as expected.

What do you think would be the best way to fix it?
diff mbox series

Patch

diff --git a/tests/tcg/xtensa/Makefile.softmmu-target
b/tests/tcg/xtensa/Makefile.softmmu-target
index 9530cac2ad95..6588388967d9 100644
--- a/tests/tcg/xtensa/Makefile.softmmu-target
+++ b/tests/tcg/xtensa/Makefile.softmmu-target
@@ -2,7 +2,7 @@ 
# Xtensa softmmu tests
#

-ifneq ($(TARGET_WORDS_BIGENDIAN),y)
+ifneq ($(shell $(QEMU) -cpu help | grep -w $(CORE)),)

XTENSA_SRC = $(SRC_PATH)/tests/tcg/xtensa
XTENSA_ALL = $(filter-out $(XTENSA_SRC)/linker.ld.S,$(wildcard