Message ID | CAEgOgz5u5kr7GD6PUY0EsmGuQLkLyQHSnafoobHvaU5Hbyr6Eg@mail.gmail.com |
---|---|
State | New |
Headers | show |
Il 13/06/2012 08:21, Peter Crosthwaite ha scritto: > > Im testing your revisions the the xilinx ip around getting rid of the > pointer props (your prop-ptr branch on your github). > > First up theres a typo in the machine model stuff, heres the fix: > > diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c > index 37866f4..e718183 100644 > --- a/hw/petalogix_ml605_mmu.c > +++ b/hw/petalogix_ml605_mmu.c > @@ -126,7 +126,7 @@ petalogix_ml605_init(ram_addr_t ram_size, > xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000); > > /* axi ethernet and dma initialization. */ > - DeviceState *dma = qdev_create(NULL, "xilinx-axidma"); > + DeviceState *dma = qdev_create(NULL, "xilinx,axidma"); > DeviceState *eth0; > > eth0 = xilinx_axiethernet_create(&nd_table[0], XILINX_AXIDMA_PEER(dma), > > I corrected this and ran it but SIGABRT'ed on some assertion in the > qom framework: It's quite possible that interfaces are borked, since we have no unit tests and no user. :/ Paolo
Up and running Paolo, Interfaces now tested as working in a machine :) I had to hack-up QOM a little bit for it all to work, creating a series (hacks and all) so it can be discussed. Regards, Peter On Wed, Jun 13, 2012 at 4:38 PM, Paolo Bonzini <pbonzini@redhat.com> wrote: > Il 13/06/2012 08:21, Peter Crosthwaite ha scritto: >> >> Im testing your revisions the the xilinx ip around getting rid of the >> pointer props (your prop-ptr branch on your github). >> >> First up theres a typo in the machine model stuff, heres the fix: >> >> diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c >> index 37866f4..e718183 100644 >> --- a/hw/petalogix_ml605_mmu.c >> +++ b/hw/petalogix_ml605_mmu.c >> @@ -126,7 +126,7 @@ petalogix_ml605_init(ram_addr_t ram_size, >> xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000); >> >> /* axi ethernet and dma initialization. */ >> - DeviceState *dma = qdev_create(NULL, "xilinx-axidma"); >> + DeviceState *dma = qdev_create(NULL, "xilinx,axidma"); >> DeviceState *eth0; >> >> eth0 = xilinx_axiethernet_create(&nd_table[0], XILINX_AXIDMA_PEER(dma), >> >> I corrected this and ran it but SIGABRT'ed on some assertion in the >> qom framework: > > It's quite possible that interfaces are borked, since we have no unit > tests and no user. :/ Alrighty, So if this is the first user, then maybe its the smoke-test case? Preparing a test package now. Regards, Peter > > Paolo >
Il 13/06/2012 10:43, Peter Crosthwaite ha scritto: >> > It's quite possible that interfaces are borked, since we have no unit >> > tests and no user. :/ > Alrighty, > > So if this is the first user, then maybe its the smoke-test case? > Preparing a test package now. Yes, having a user was in fact the reason why I chose to model AXI with interfaces. :) Thanks very much for your work! Paolo
diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c index 37866f4..e718183 100644 --- a/hw/petalogix_ml605_mmu.c +++ b/hw/petalogix_ml605_mmu.c @@ -126,7 +126,7 @@ petalogix_ml605_init(ram_addr_t ram_size, xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000); /* axi ethernet and dma initialization. */ - DeviceState *dma = qdev_create(NULL, "xilinx-axidma"); + DeviceState *dma = qdev_create(NULL, "xilinx,axidma"); DeviceState *eth0; eth0 = xilinx_axiethernet_create(&nd_table[0], XILINX_AXIDMA_PEER(dma),