| Message ID | 93ae03bd89b47731f6703dab5925ed2f7a9fd426.1723119423.git.mchehab+huawei@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | Add ACPI CPER firmware first error injection on ARM emulation | expand |
On Thu, 8 Aug 2024 14:26:33 +0200 Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > While the spec defines a CPER size of 4KiB for each record, > currently it is set to 1KiB. Fix the documentation and add > a pointer to the macro name there, as this may help to keep > it updated. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Acked-by: Igor Mammedov <imammedo@redhat.com> > --- > docs/specs/acpi_hest_ghes.rst | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/docs/specs/acpi_hest_ghes.rst b/docs/specs/acpi_hest_ghes.rst > index 68f1fbe0a4af..c3e9f8d9a702 100644 > --- a/docs/specs/acpi_hest_ghes.rst > +++ b/docs/specs/acpi_hest_ghes.rst > @@ -67,8 +67,10 @@ Design Details > (3) The address registers table contains N Error Block Address entries > and N Read Ack Register entries. The size for each entry is 8-byte. > The Error Status Data Block table contains N Error Status Data Block > - entries. The size for each entry is 4096(0x1000) bytes. The total size > - for the "etc/hardware_errors" fw_cfg blob is (N * 8 * 2 + N * 4096) bytes. > + entries. The size for each entry is defined at the source code as > + ACPI_GHES_MAX_RAW_DATA_LENGTH (currently 1024 bytes). The total size > + for the "etc/hardware_errors" fw_cfg blob is > + (N * 8 * 2 + N * ACPI_GHES_MAX_RAW_DATA_LENGTH) bytes. > N is the number of the kinds of hardware error sources. > > (4) QEMU generates the ACPI linker/loader script for the firmware. The
diff --git a/docs/specs/acpi_hest_ghes.rst b/docs/specs/acpi_hest_ghes.rst index 68f1fbe0a4af..c3e9f8d9a702 100644 --- a/docs/specs/acpi_hest_ghes.rst +++ b/docs/specs/acpi_hest_ghes.rst @@ -67,8 +67,10 @@ Design Details (3) The address registers table contains N Error Block Address entries and N Read Ack Register entries. The size for each entry is 8-byte. The Error Status Data Block table contains N Error Status Data Block - entries. The size for each entry is 4096(0x1000) bytes. The total size - for the "etc/hardware_errors" fw_cfg blob is (N * 8 * 2 + N * 4096) bytes. + entries. The size for each entry is defined at the source code as + ACPI_GHES_MAX_RAW_DATA_LENGTH (currently 1024 bytes). The total size + for the "etc/hardware_errors" fw_cfg blob is + (N * 8 * 2 + N * ACPI_GHES_MAX_RAW_DATA_LENGTH) bytes. N is the number of the kinds of hardware error sources. (4) QEMU generates the ACPI linker/loader script for the firmware. The
While the spec defines a CPER size of 4KiB for each record, currently it is set to 1KiB. Fix the documentation and add a pointer to the macro name there, as this may help to keep it updated. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- docs/specs/acpi_hest_ghes.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)