From patchwork Wed Jan 11 19:16:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Llu=C3=ADs_Vilanova?= X-Patchwork-Id: 135474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E9564B6EF2 for ; Thu, 12 Jan 2012 06:18:23 +1100 (EST) Received: from localhost ([::1]:41860 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl3gj-0002jU-RR for incoming@patchwork.ozlabs.org; Wed, 11 Jan 2012 14:18:21 -0500 Received: from eggs.gnu.org ([140.186.70.92]:37558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl3ge-0002iw-Dm for qemu-devel@nongnu.org; Wed, 11 Jan 2012 14:18:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl3gd-0000bM-58 for qemu-devel@nongnu.org; Wed, 11 Jan 2012 14:18:16 -0500 Received: from gw.ac.upc.es ([147.83.30.3]:44174 helo=gw.ac.upc.edu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl3gc-0000bD-QH for qemu-devel@nongnu.org; Wed, 11 Jan 2012 14:18:15 -0500 Received: from localhost (unknown [84.88.53.92]) by gw.ac.upc.edu (Postfix) with ESMTP id 6909D6B0249; Wed, 11 Jan 2012 20:18:12 +0100 (CET) From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= To: qemu-devel@nongnu.org References: <20120111180504.25198.76946.stgit@ginnungagap.bsc.es> <20120111180621.25198.40906.stgit@ginnungagap.bsc.es> Date: Wed, 11 Jan 2012 20:16:19 +0100 In-Reply-To: <20120111180621.25198.40906.stgit@ginnungagap.bsc.es> (=?utf-8?Q?=22Llu=C3=ADs?= Vilanova"'s message of "Wed, 11 Jan 2012 19:06:21 +0100") Message-ID: <87d3aqkq2k.fsf_-_@ginnungagap.bsc.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 147.83.30.3 Cc: harsh@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com Subject: [Qemu-devel] [PATH 7/6] trace: [tracetool] Make format-specific code optional and with access to event information X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 35 ++++++++++------------------------- 1 files changed, 10 insertions(+), 25 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index a9020de..ddf4c31 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -38,26 +38,19 @@ Options: ''' sys.exit(1) -def trace_h_begin(): +def trace_h_begin(events): print '''#ifndef TRACE_H #define TRACE_H /* This file is autogenerated by tracetool, do not edit. */ #include "qemu-common.h"''' - return -def trace_h_end(): +def trace_h_end(events): print '#endif /* TRACE_H */' - return -def trace_c_begin(): +def trace_c_begin(events): print '/* This file is autogenerated by tracetool, do not edit. */' - return - -def trace_c_end(): - # nop, required for trace_gen - return def nop_h(events): print @@ -350,7 +343,7 @@ probe %(probeprefix)s.%(name)s = process("%(binary)s").mark("%(name)s") def dtrace_nop_stp(events): pass -def trace_stap_begin(): +def trace_stap_begin(events): global probeprefix if backend != "dtrace": print 'SystemTAP tapset generator not applicable to %s backend' % backend @@ -367,20 +360,13 @@ def trace_stap_begin(): if probeprefix == "": probeprefix = 'qemu.' + targettype + '.' + targetarch print '/* This file is autogenerated by tracetool, do not edit. */' - return -def trace_stap_end(): - return #nop, reqd for trace_gen - -def trace_d_begin(): +def trace_d_begin(events): if backend != 'dtrace': print 'DTrace probe generator not applicable to %s backend' % backend sys.exit(1) print '/* This file is autogenerated by tracetool, do not edit. */' -def trace_d_end(): - return #nop, reqd for trace_gen - # Registry of backends and their converter functions converters = { @@ -416,22 +402,19 @@ converters = { } # Trace file header and footer code generators -trace_gen = { +formats = { 'h': { 'begin': trace_h_begin, 'end': trace_h_end, }, 'c': { 'begin': trace_c_begin, - 'end': trace_c_end, }, 'd': { 'begin': trace_d_begin, - 'end': trace_d_end, }, 'stap': { 'begin': trace_stap_begin, - 'end': trace_stap_end, }, } @@ -558,10 +541,12 @@ def main(): events = read_events(sys.stdin) - trace_gen[output]['begin']() + if 'begin' in formats[output]: + formats[output]['begin'](events) converters[backend][output]([ e for e in events if 'disable' not in e.properties ]) converters['nop'][output]([ e for e in events if 'disable' in e.properties ]) - trace_gen[output]['end']() + if 'end' in formats[output]: + formats[output]['end'](events) if __name__ == "__main__": main()