| Message ID | 780bf01dec69fa68b8fe5a9c09187b124e0a56ec.1730713917.git.mprivozn@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qga: Open channel before going daemon | expand |
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> On Mon, Nov 4, 2024 at 11:54 AM Michal Privoznik <mprivozn@redhat.com> wrote: > The run_agent_once() function is already given GAState via an > argument. There's no need to access the global ga_state variable > which points to the argument anyways (thanks to > initialize_agent()). Worse, some parts of the function use the > argument and the other use the global variable. Stick with the > function argument. > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> > --- > qga/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/main.c b/qga/main.c > index 50186760bf..4a695235f0 100644 > --- a/qga/main.c > +++ b/qga/main.c > @@ -1519,7 +1519,7 @@ static int run_agent_once(GAState *s) > return EXIT_FAILURE; > } > > - g_main_loop_run(ga_state->main_loop); > + g_main_loop_run(s->main_loop); > > if (s->channel) { > ga_channel_free(s->channel); > -- > 2.45.2 > >
diff --git a/qga/main.c b/qga/main.c index 50186760bf..4a695235f0 100644 --- a/qga/main.c +++ b/qga/main.c @@ -1519,7 +1519,7 @@ static int run_agent_once(GAState *s) return EXIT_FAILURE; } - g_main_loop_run(ga_state->main_loop); + g_main_loop_run(s->main_loop); if (s->channel) { ga_channel_free(s->channel);
The run_agent_once() function is already given GAState via an argument. There's no need to access the global ga_state variable which points to the argument anyways (thanks to initialize_agent()). Worse, some parts of the function use the argument and the other use the global variable. Stick with the function argument. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)