From patchwork Mon Aug 21 11:23:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dou Liyang X-Patchwork-Id: 803966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xbWYZ6JHjz9s78 for ; Mon, 21 Aug 2017 21:24:33 +1000 (AEST) Received: from localhost ([::1]:35562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djkoo-0002Jd-TA for incoming@patchwork.ozlabs.org; Mon, 21 Aug 2017 07:24:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djkoL-0002GV-Pf for qemu-devel@nongnu.org; Mon, 21 Aug 2017 07:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djkoI-0004bg-GV for qemu-devel@nongnu.org; Mon, 21 Aug 2017 07:24:01 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:44614 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djkoI-0004ao-4c for qemu-devel@nongnu.org; Mon, 21 Aug 2017 07:23:58 -0400 X-IronPort-AV: E=Sophos;i="5.41,409,1498492800"; d="scan'208";a="24202960" Received: from localhost (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 21 Aug 2017 19:23:52 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 3B79847243AB; Mon, 21 Aug 2017 19:23:52 +0800 (CST) Received: from localhost.localdomain (10.167.226.106) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 Aug 2017 19:23:54 +0800 To: Igor Mammedov References: <1502847935-20483-1-git-send-email-douly.fnst@cn.fujitsu.com> <9e5b10ce-6259-a21b-01dc-13f57d28a0ef@cn.fujitsu.com> <20170818164852.GZ3108@localhost.localdomain> <20170821105708.4391e201@nial.brq.redhat.com> From: Dou Liyang Message-ID: <6d8a9fae-fce8-c739-3e23-293cd201b91f@cn.fujitsu.com> Date: Mon, 21 Aug 2017 19:23:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170821105708.4391e201@nial.brq.redhat.com> X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: 3B79847243AB.A7918 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 183.91.158.132 Subject: Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, rth@twiddle.net, mst@redhat.com, Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi, Igor [...] >> >> Ok, I will do it right now. > > see commit 6b9c1dd2c for example of adding test case, > currently test has base SRAT tables that is reused by all tests. > When you create testcase that produces different SRAT table, > 'make check' will print warnings that ables do not match > you can add "V=1" env. var. 'make V=1 check' to get detailed > diff of what's changed. > > also see how 'test_data.variant' is handled to get idea how to use > it to differentiate specific test case vs shared ACPI tables baseline blobs. > Thanks for teaching me that, it's very helpful to me. Except for adding a new case, can we except memhp testcase with node RAM check? just like following shows: Thanks, dou. diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 564da45..c79ece4 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -788,7 +788,7 @@ static void test_acpi_q35_tcg_memhp(void) data.machine = MACHINE_Q35; data.variant = ".memhp"; test_acpi_one(" -m 128,slots=3,maxmem=1G" - " -numa node -numa node" + " -numa node -numa node,mem=128" " -numa dist,src=0,dst=1,val=21", &data); free_test_data(&data); @@ -802,7 +802,7 @@ static void test_acpi_piix4_tcg_memhp(void) data.machine = MACHINE_PC; data.variant = ".memhp"; test_acpi_one(" -m 128,slots=3,maxmem=1G" - " -numa node -numa node" + " -numa node -numa node,mem=128" " -numa dist,src=0,dst=1,val=21", &data); free_test_data(&data);