From patchwork Mon Jan 24 10:00:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 80171 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EC89DB710E for ; Tue, 25 Jan 2011 01:17:19 +1100 (EST) Received: from localhost ([127.0.0.1]:50103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhJiP-0006aT-6W for incoming@patchwork.ozlabs.org; Mon, 24 Jan 2011 05:32:05 -0500 Received: from [140.186.70.92] (port=45090 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhJEK-0004lA-SM for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:01:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhJEJ-000830-UO for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:01:00 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:35244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhJEJ-00082h-LQ for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:00:59 -0500 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id 7F4018746B; Mon, 24 Jan 2011 19:00:58 +0900 (JST) Received: (nullmailer pid 12491 invoked by uid 1000); Mon, 24 Jan 2011 10:00:58 -0000 From: Isaku Yamahata To: qemu-devel@nongnu.org Date: Mon, 24 Jan 2011 19:00:58 +0900 Message-Id: <6415008f38500f490594eef803cf910f0bb5f46c.1295863213.git.yamahata@valinux.co.jp> X-Mailer: git-send-email 1.7.1.1 X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: yamahata@valinux.co.jp Subject: [Qemu-devel] [PATCH] loader: memory leak in rom_add_file() on error path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org fix memory leak in rom_add_file(). Signed-off-by: Isaku Yamahata --- hw/loader.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index 35d792e..6cba8c5 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -618,6 +618,8 @@ int rom_add_file(const char *file, const char *fw_dir, err: if (fd != -1) close(fd); + qemu_free(rom->fw_file); + qemu_free(rom->fw_dir); qemu_free(rom->data); qemu_free(rom->path); qemu_free(rom->name);