From patchwork Wed Nov 8 22:57:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 836064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="N/VhqRFp"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yXMkZ0VW3z9s3w for ; Thu, 9 Nov 2017 10:21:42 +1100 (AEDT) Received: from localhost ([::1]:34406 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCZfA-0007UF-2H for incoming@patchwork.ozlabs.org; Wed, 08 Nov 2017 18:21:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCZLq-0008Gd-VM for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCZLn-0003Jb-Qz for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:43 -0500 Received: from mail-sn1nam01on0087.outbound.protection.outlook.com ([104.47.32.87]:49411 helo=NAM01-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCZLn-0003JA-I3 for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AWX4c71g+kzdY+bxhaz0/0IDVev7o8AOiZms+K2qTmg=; b=N/VhqRFpvm72cBqexAzOMzbzZfIovbRfsLCy6iL48vT4aWCFd83cUudIoOlJApBYBzBKrMJbUkY1tLk6jP3/S8kA20D62u3YasB9nTQTeAdXdpE7pWpsqZ2U9Iw/A2AB/xGddh4XjyLnMlRUcoxUVXTVdiGmFhIZoiSP2Mmf558= Received: from BLUPR0201CA0024.namprd02.prod.outlook.com (2a01:111:e400:52e7::34) by DM2PR02MB1340.namprd02.prod.outlook.com (2a01:111:e400:50c8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Wed, 8 Nov 2017 23:01:37 +0000 Received: from BL2NAM02FT052.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::206) by BLUPR0201CA0024.outlook.office365.com (2a01:111:e400:52e7::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.218.12 via Frontend Transport; Wed, 8 Nov 2017 23:01:36 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT052.mail.protection.outlook.com (10.152.77.0) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.197.9 via Frontend Transport; Wed, 8 Nov 2017 23:01:36 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1eCZLj-0001Lr-Gx; Wed, 08 Nov 2017 15:01:35 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eCZLj-0002py-9S; Wed, 08 Nov 2017 15:01:35 -0800 Received: from xsj-pvapsmtp01 (smtp3.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vA8N1SsP009607; Wed, 8 Nov 2017 15:01:28 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eCZLb-0002mi-SI; Wed, 08 Nov 2017 15:01:28 -0800 From: Alistair Francis To: Date: Wed, 8 Nov 2017 14:57:30 -0800 Message-ID: <5ef24a383f26a1506bd57b576e6028ce506db65c.1510181732.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23450.000 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(189002)(199003)(81156014)(81166006)(2351001)(54906003)(5820100001)(76176999)(50986999)(106002)(8676002)(316002)(6306002)(356003)(36756003)(9786002)(305945005)(50466002)(4326008)(189998001)(77096006)(8936002)(39060400002)(47776003)(2870700001)(33646002)(575784001)(2906002)(50226002)(63266004)(23676003)(6666003)(478600001)(106466001)(2950100002)(5660300001)(36386004)(6916009)(118296001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR02MB1340; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT052; 1:BuV+F2ds+zj8BS/Y9LbU/hFRvvDG/X5tQlqWvpVWo/dv49KIRjoxx2I0QDeH/ogYoVxdcpJ7PFbuw1c3vsG0tPl0umdBUH7k5az5+k3LkUWsM4hNr/sW2+R6crQe0S47 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 665fe080-d0a5-4cc4-0121-08d526fca9c4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:DM2PR02MB1340; X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 3:8hZOVta4ngRnUiAzL2QfrdJ2Ye/bMyEsG2jbWWtzr0hzmSi7KFJPq97/yFFRcPYPOotzD2/fbpyrym/NcBy4eIkvJtmlhx+OMJSGhSZF5FkNwj7+5i+/FtjYxqjCEyiYcdngErebErLRmCk4rMjlrpHfzDC+PEaI+YZiWzqkgpTSL46BbzG7pkQlmX2trdm08zvJWTR/gz08kPndesq881aLfXKkI2GdMhoxyjYtmFHcNrTtXT0v+GNjKbOCiIwV8f2sJpvXry0Ji0gqhFnVwq3p/zybQlqTV2qHYaVcXXX/8a3hvFomRqe4xv3fWeT0oBHxycZTdhwWlZrz2986e7MppcS3ZRLXz35fqDspv9A=; 25:4bD8KPWjMkmY64Tank3hVIYN2ImhS1OtgHVKCsfOxchtF1p9PiZ3AdP6U56lIKYNXjB7MOrPjgJKDLLBLF8JkucB6rv//3UitWg7P6Nqixxml9wzuwmR+SD4oiIWMMr0SzM1l1fBqr0afy9QpKy9g2fZLAAD7AgbIq0ywlcSVuxAekh8Y/IDOgmuMRbXJAJmnZ4p9i+3GD2Ty89kYNvg/62gI1ajCYrGzj0O10onz52kHfBdLFBMj/8ym+1Zt9Gv/sVVewbUNBGoQtdDUdQoobw3FNyvYMajYvBVsx2aysjYdSjbpkupQJxBDY7ENgIGxB6JUvf5gYIX9Kjlz1wunZHfPhjqjS8zJDj6/2bacJU= X-MS-TrafficTypeDiagnostic: DM2PR02MB1340: X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 31:9TIJUQlyioaj8K7D6VlrodPS5rCZsnZchFCJwWP3z7SyBOaZOOL/p8MaB2uh7+8m+40HiAKBGt1KxHx3RWPLT3NtihaQDGB/cFZF1k6O4cmkiFiRqp7+95J0Ymyx8q1m6hWWy51eFSLAmQidVnhykqpwFx2yV0jFvLRV4RDRtHcARt95XvaMeQtgKtXS3Sj3eO4A7tsFQcB9f3BgH3RsosIR+hfhel5uC7AJRP4Wmyc=; 20:SpPTYejc11S/mFGwLa5v9LH7Z8YzepY8iz44rLK+vmg3CV6ADL0/3xKsXhUps84lOJUndOxCA9Q61I+P9mapjXchihJ1zzRffKQcMzTwJxxnNj5xOmSC+up2xMt1hT4QKZQwzf8zOELVQpSoxfnUTTJidzWnBJdokrusUzRRFMi6lfug6bndjbWc7n4ZQ6Eaz/ykO3XEGuhAH8Et5nnBLU//lLFtNokNpz0SNFhsPremkJgTZJHhvFSY+eSPXF/jgsVC02e2KyWhFkLs7lNA21ZvDoj8qCY+A8odXfspZ2FAuEt50XVAf/ov9CXn2qxyEgbPpyPmFAY1lCr+QSziTF8VA9jR0ltxrj64PmIfg44VZzQJl4Npo+8lh0Ixe18+qJXn1mVI9uFqG1YQJYyI+wzDyZ5fNFpPT8WdjH7d2l14rc94vrEn60W7WHmsHQJnwBAK8TgWLch2cCwL+yFJon7P2JTiB1Iycc9a1EKDGLiMseed9kGFhcig2ufjrhxV X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030)(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93004095)(3002001)(3231021)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM2PR02MB1340; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM2PR02MB1340; X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 4:AqmY2foK964QKCJgzFP0vciQTZZSSzl8qRcag0kc9/hDRpT4X7ah01nkTz3DyiVEZ3Nnp9fmSHGtg1sc1zogGn9/OrXlCyFMyO+z5y3oVzTPSAIxl6PZ9tAotepkBnQvq9dzbiDBQWrvelL+I/8TwZTG/H066y2M4IwO+grxpjLKdkMJLfEJhEVW/6ye+K8ou9aEf8JTmviBw0e06lrqaZCGOESauUAc7gTqhnT+GpBenDBOOWlua126NSeL8iqtEooRn7wr8Y5cjdxuWhKx+0ntyvyDDtOEZMbuPASA/U+bSC406WApF7XC/pkk6e3KKGNyL+AeWUWfGZ+jFM5qOyorS+t0cwmnVGwdUDaPq5swZCRsvrec1jS+0vAgNqgBwSCBBzBp+YHUgygRZisey5IcuuLlqTuf1LdYt96p6gs= X-Forefront-PRVS: 0485417665 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR02MB1340; 23:AD8wGrfMgdAIj6SqKZfAJCcV12hz5VTgPImbnnsur?= inWW5cL6GV/4a1LfeEm5hMH3DdXlUkwSE5ivOgw1S5WIEt9tvThaP7oYcd9ELpDq+Ub/rgK35mrTwHd+JXW70cWC/guByl4fNnwhId4gBn6eVsSQFCenJcpWfPzKqvqhENsw80KmAoy3nSqgf5wJ5qcPkKsB9+lzCE+BxnH9t2JYx3ML1UYiFVwLtmhtHSRIJAhmY9nzVFDSyGl/kjIFyMuZ7pL8Z4ZS0xe4OkhVfA21CCP4rZrms7zfU7wRhpNoPRhzh2e5M0yKBP7Yoeyz+c8+Dn+D72+Nyo8ZsWve5LK3YJ8o9t1IE+ZrO14OnBtUw5Bnsh91mf9smdfNqSoIwpZukyjcQdGpZoLB21X25LT+/KEsDIrWMqI0EwyGRYzV9LZEp2U7KhvfAB7PvCmIKXOjQwvyVy8THFf2o+Twb0IdtThc+FUkoDIwH91JhhU1w4U3TUtwNQflpuPATZnm9aOhgu/971XVrAhaWxe/j8LoHduSyiqoY+vIlxs9hzudZzLawZAl+AwZA4+gWlooolHnWsosExHZ8vzqahuaYHZ5UAUC5jKwJGJNPJoHsQwVBS6b+8nxSS+7DD4LSTJCzAcVpZGd4NTWRy56eQQaVI4ezyNoz4aa/B4jugT+plPU1k1PCova1WeUbcefQhecpyqk1R0m1wDkiDluMCcVNec4eHAnSrTStriKPtY6FZc76AknPiG1yMZEtVBYE9AwCTQ8mZuRq75A6ODPUpfNiVqljl/stoJm9IXrtcYpg++tLRv1UzBmDdWwCfuw26h4DxUUKdnXfDWBB4vwrvo3KdK5XFwBEZCaRIUYkDlt5wIA3yNJU7wNqXbZUmcT2+vJYKwASGYGdpABYtVRHk5aFOruatx8IBJOuaLxy+7iyCYokI7lg2Dd9Q4qQhtvYQmN/Vi2lpo0SPRWMSdJS389i6dkFMubJA00HfH4z85JTdBMIzvSuC1pIIs/yKjv1oKBM+b8UISrg9QgHng9EOSZB6MPZDa4h50VOxl+tXNwRBqW2bEXEIzrQC4bkO02FQhLcy1/LL2lB47QeYI36LjiRlKTw== X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 6:k7NyCtnW8nJIzmgpSCzz+gsIlE3FVrR5Q6CExpnHQmUM2wMdE5NT57x7MsagUioZkOvWXZtNRyNdc42sO9Nprmfrg6MtEe7iAaPBit5JE8gOUdO9WDiSQA6yVZk/KllaOKc+6wT3dwidOLwJ2NkNP9LtG3Wq82CY8Bk03nNKiuH6R/KkPtihv0LQnlzfDaSn9liu88bx1yI9YBpWqB0oabUxaecOwi/5a2xexsXbivjTxtwwW+MeVs90e2IwpsnhVcFH2f6Nyp+27BEKe9Hh3X7eMGEdDDR1sslbJmkl0VWvRZHizEPb5eGd52oYBHC6mlnM19CREubKaYzLpaaj7rlr2SHRyVMk8cnJjzQAziM=; 5:d+rTVzQrTAwonfp6jMDSkJBjK7+bT4hAg05bsRJsWXAfzI6DRWqUuXyskqtjg849r0R9lMoyF7OfAStkqJFSqTTPAIGU94q/Y/bxgHIH6XTvZxxVzP3hg5YB87ocBFiFEhaKKxY6o+ga2Ih7oarZ/keuJj1vFE+26r0IA1cQXEk=; 24:2/QuDHr77ujTyjP8PlnDNIP0cVf2myepd6AZOV1iHjljlGkG9zcm0vKDABUwNXsc7jNa1CdcP3U70jEBmQ0PKpuuATilJIJywWvfBVZm7VQ=; 7:yRQABudvJGQls8DfQWt6nkdTVGl3IiQ/tHXUQS4qockOdpGY6g0oLdFPvk7/z6NcG0g9Div8RPJrsdI9g+n63ZFoNkILJQxTrQ8uVTVbM+lSw2ZGR9ykiuz7Aejlzt2YT2ZSfWa22dTzfki4GAcApQBvmpBegwKanjMD2V5+abLAvd21LXwEHbzUwjuWB0CErDe49MvzFgtGPxJ9tR6N78vWjWGA2lLvEt1eBGxsGXophsZJiOYL2NABMJO3rxJE SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2017 23:01:36.2102 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 665fe080-d0a5-4cc4-0121-08d526fca9c4 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB1340 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.32.87 Subject: [Qemu-devel] [PATCH v4 20/45] hw/isa: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- V2: - Split hw patch into individual directories hw/isa/isa-bus.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 348e0eab9d..0f2e426d02 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -17,6 +17,7 @@ * License along with this library; if not, see . */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "hw/hw.h" #include "monitor/monitor.h" @@ -186,15 +187,15 @@ ISADevice *isa_vga_init(ISABus *bus) case VGA_CIRRUS: return isa_create_simple(bus, "isa-cirrus-vga"); case VGA_QXL: - fprintf(stderr, "%s: qxl: no PCI bus\n", __func__); + error_report("%s: qxl: no PCI bus", __func__); return NULL; case VGA_STD: return isa_create_simple(bus, "isa-vga"); case VGA_VMWARE: - fprintf(stderr, "%s: vmware_vga: no PCI bus\n", __func__); + error_report("%s: vmware_vga: no PCI bus", __func__); return NULL; case VGA_VIRTIO: - fprintf(stderr, "%s: virtio-vga: no PCI bus\n", __func__); + error_report("%s: virtio-vga: no PCI bus", __func__); return NULL; case VGA_NONE: default: