From patchwork Wed Nov 8 22:57:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 836061 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="cKso4x7l"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yXMgy1bxVz9s3w for ; Thu, 9 Nov 2017 10:19:26 +1100 (AEDT) Received: from localhost ([::1]:34392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCZcy-0005jW-44 for incoming@patchwork.ozlabs.org; Wed, 08 Nov 2017 18:19:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCZLq-0008GX-Rk for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCZLn-0003JU-OS for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:42 -0500 Received: from mail-sn1nam01on0059.outbound.protection.outlook.com ([104.47.32.59]:33357 helo=NAM01-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCZLn-0003Iz-GK for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OrynN4WZoZoHYgqML/BL2R502hXxxrywlbwEAlffRvw=; b=cKso4x7l3donQimaEHUnCkN5AwHGzZAjQmmG9MnejDAO1zQ4cmNE/9RvZ2XOxKHT4F+XhXhNUImslvalvqWpKT3HeAW2mGbw5erZpv2nntvhkCGbAPp6A+x8ipWGWWiQJx0D3tXXNFeqaCNvx5qHIhfRutak0/nsHdVj/zMPlxk= Received: from MWHPR0201CA0074.namprd02.prod.outlook.com (10.167.161.15) by CY1PR02MB1335.namprd02.prod.outlook.com (10.161.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Wed, 8 Nov 2017 23:01:36 +0000 Received: from SN1NAM02FT049.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::205) by MWHPR0201CA0074.outlook.office365.com (2603:10b6:301:75::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.218.12 via Frontend Transport; Wed, 8 Nov 2017 23:01:36 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT049.mail.protection.outlook.com (10.152.72.166) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.197.9 via Frontend Transport; Wed, 8 Nov 2017 23:01:36 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1eCZLj-0001Lx-LO; Wed, 08 Nov 2017 15:01:35 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eCZLj-0002py-D0; Wed, 08 Nov 2017 15:01:35 -0800 Received: from xsj-pvapsmtp01 (mailman.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vA8N1Prq009559; Wed, 8 Nov 2017 15:01:25 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eCZLZ-0002lw-Eu; Wed, 08 Nov 2017 15:01:25 -0800 From: Alistair Francis To: Date: Wed, 8 Nov 2017 14:57:27 -0800 Message-ID: <5c147b85d57e57a1b8fcda6974630a82666f1bf1.1510181732.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23450.000 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(2980300002)(438002)(199003)(189002)(81166006)(33646002)(9786002)(36386004)(356003)(478600001)(189998001)(5660300001)(106466001)(2351001)(106002)(2906002)(305945005)(2870700001)(39060400002)(63266004)(2950100002)(4326008)(6916009)(77096006)(8936002)(81156014)(50466002)(47776003)(54906003)(36756003)(118296001)(23676003)(76176999)(5820100001)(316002)(8676002)(50986999)(50226002)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR02MB1335; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT049; 1:l00dbILS2smVsraEblWrpqm+4jC/UeOGXJRZeHMNDspG4wW8W/TrhRiKI2I7bLaybV5a7XGUTa4ftluSOUkYl7/uqIkETDbbrIsojZyNLS2ABfoi7j8iQW3Je0ooPYcc X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d4fd54f-faee-4d56-3cd6-08d526fca9a8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603249); SRVR:CY1PR02MB1335; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1335; 3:nQK4gexbjVW4wqH9knwN6SDwOWsXWSmYZJLA9kBI/p/tVOSbM1SGW2eitSX21S8BOBY25Evu/y2lGZy/G/qchEVSgsboyutpHWN5yoo6S9C5plhBEku9m4Vk8+jZU6gU04z+J/iwjCQjUh7W5FNy93msiZMZLi5rZh+kRsCtj9VB9XnYwmmr8ENcJaUU45z6L+R7m5odPon2nzLdSC2S/+7jN+ed71k5qKfq5jh0D7EAmBS8YQCRnjMNUMALnxzF1KY6XbMyA1A14g0feuARVrncRA70sCqFoZrMXw2hozvk7n4sUs3k5spxoKviPMmFINd3F4zrGQcEH0bVexhb+gXwVwx3WGefJJia5PrBnhU=; 25:PC21VAAklV/pM2g7yIhx4CZYvKgiWZrhptFFr1a9aLRH5VPmeyriuBBLw5yJvkaYOGi7inD8rgIc3HpePMF8yS9P95ifWNvZcWbXGLSZgGZP9JzvdOGXhai5tamHpO3ciGwf46PVkWMIVdHpH5QCBPdE4N1MhI/EsVo4RSDJNyxA8fWrDICS8sI9I6yZ0TdLofqHPN1VTh+IUwELDV7WlTKTBV3XHCHnAGtjSY+w8pl/MK6AiyHn+Sr/n+9ePKQp8I6LQMgO3r+nxAdyy9BhsvIlQujwBWkN2PGWg4L+eMu2/rYDwd9GF/muYI1PONG7O8E5UdIKpz1eA1Jadxq8RA== X-MS-TrafficTypeDiagnostic: CY1PR02MB1335: X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1335; 31:cVc7few3IVTK96x7FSPCGm+hZiwsEw38KO0viD27s9b2eYYvphBKKuSVkVN91mS2l284HAruIPbeXBeCqSV278URNzTNZ0Xlg1IgNJSodI+ec+oLWd0Rq0+Eph56qybMkrctje12QmnaPq/M+s8tUJzywRmaxS3TuN9VCy8aek1OHS3l96Q/JzAO9SyezEr6mZVK1cMjws1E1rrdOuhFpJww2WOlzH77EUbf9/Elqo4=; 20:Pqm9/ODBDUzvah2wOMZpXFNDIXSISpTupLeY1IQPI4/whgWaxzNpdbNGZ4KhW3pS42RrFVXFxHWozfEIb1hifYocgsiOPYJ+uySi3jCLd4bmGmkjcRysoIYJM+JHoIBqGdO7iu0EOs0PIAhvC+pwP8U0Rmrxd/rbIoTHjWzpd2qyL+rrGHPk1KKmNAt9TANnEeen7JKTE2Dpay6nz1q6WEKEuu1kiANhy+DF7/jjoLJ08I49ErwfF9KKtgZWXucfTSUxZqNwm0OCjVO9VQBNWV7KLvAiNClKYCNmGBRbfAzJulNGNURu0lMDfu5I3t/Ydy+2OK/Uqt/5Qrj1y1LUfD8FyzYfGeTATEmqGlKnQhUGLh+/5KAGmZvs6nl/zyoRx9NlSN/69oQs3U8TnPe4FFIHD+iHpQCqOndJJuhaakT8FYRYu3qREgTlErH92oWQVHUppvGwmd48wsuTLW1QFXjDkTrD8G7y3NOBVZh9sTY+f2on05RSzE9a0aIE0Jw5 X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93004095)(3002001)(3231021)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR02MB1335; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR02MB1335; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1335; 4:13fpnMwdiHKdGfsKrV2NVASmtrmYi//I0vrJ2xXCT+vtrWhQUDCSuKQGZUvAGTHgcWOe8H3NrOa7r+ch+DU24+1adXDczwARzBcrygo3GGYUOWmSE1llXWdTkf4chhRN+v/P1afNYmn01JIPAjmaokTuGVrDKHBPRtUVDu1bl8sJLUwpGcArTXbTlk47kNJUXzp88rVjdzH71flOHdxq6fS6wEJF61+z42usp/vXz3Yn+qEUqMhyX04oZgSADtPeFQDKbr+lrUQL81RBpRCMFEZKvF8HwbJAe8fCcsqTmyjtstM+83dP8o6Tn3Cr6cXgCq+BMCU7XPh4/xrpW5bsqQ== X-Forefront-PRVS: 0485417665 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR02MB1335; 23:LSItZp0NiDTtLPEsbkv2egYBKtW/06ymZLtS8A8Wa?= Dqp96VR7dQSUAE/T5x8MWIsztdNSdl0m48WxUGt0sHlt/VmfBlCZQgVD0lCa3bRxhwLroQ9M++EwCyXQS4j2NI0ykud2xi2Kwohj1Eq0mMzC/CnSnXdQxU4xygsr7BCL9V1Z2kJhDtJ6O1m2Nl0jdvm/JyXPqNJC7xGSj+zeUCzeSsoGVh6b4m3vSsOggnXstKaL4muSS/PDSXmwU00JeaFKEtaJ+S586UkNjzxI+ueYFfwf1XKEBoN1cfc65ZbTAitkCluCGw5++hBjh1ufwlv0fWZ7XXcQ9BCsdtO79HhAQNBp33ujlbJGuMr5wpsIGthwguTeFS+AF2Iy2tM92st3cLFZ8+/qk+fz5zL1XTEpFeItbgLKP+zaZxPO2etdTejzo5qmRL/zUcjNjP1LMV08YvaZrFQttfmUym/BHfwVQbRe7E8JWb0Kyfr7gU7tSI9EbVej3quwsicNOt7uVlO073ph48IUC0XDYtxYLfES6c7jBLHRcJHE1jKFvyXSAHT8OJcMPdnD2JK3etoiYVdXCTeYdpd9TAQB+PH5qAVEwPRZ20LqA0dYLlwaXKkHAoUoeKz9bx/4IkSzZqxLkcLb987lcUmP1qtupp5mFosvo50xGq/rOaqBbHaFRaFTHyPjwIHC34yKA4zlsKYMps9JSY810PDRO0TIRkLJUecqbd/pO70z0MZnv7+46E3PA5roSXYss4JhPE2aKKlj/ctbWAbX+tSYvPLp+kjXM5DN0FjTaDu2/kvl7i1SoH4baZk1FdPxEhQInOuhLfe3LFyRiC9gBOVRzWJ1d2bsgDpbvfeFFRU4gf8VZlf/H6i1VFwXHkuh0W02G3uc8XNDQg2dkpyqCPGJPI3btYqkc5bUvjRdc4TzI3P5TIPlTaU1wmW9TyLUjbN1d2hotiTM5Q25IO6TVMXXyLuhv8kKjFhUjjH6RU2TPZ6JvCzufykunTLCfnwcleeX+9vtonrLRDoDnDHc1fLnSlqfEMtWuj5JQ== X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1335; 6:QK81+SxuZ5bA7m0azkQ1sQEoGuzVNxSwDwdxRfjGpxVoEb38aTKYD3NBgq3UKKWeuI3iSo3jnEwj7/Id1omr2Hvfd18lk+lAratUB1IkdLD0Db++sOXrklhEMnOJvh+jc4dzhselORKcbZxt+5k6fsio1j+mlsUoCli/X3g8lts8tk51S0out/BjrI5sQJ1pPKZFCutsag2eLlh/k2GGSLwZhL/zI64d2517spomd8Gqn41SQj6uSHMyIrgaFMV79DC25dtjgBEu8bkhjM0iSt2/zizfVOJA3Fhug69DGW+JjG6oHY6P6xuB49LLOXEBnd4OYyNCh6XxV5ZS/35nuHNPsmC0tPF/lq5QRQbsKNI=; 5:0O+9Y+Yu2rM9C7qtsv8gZhEm6cKj+S7/QN5O8hFaBgDL1Eqic3b54bEPv+kCK/uRRGB7LRn8nHdaS61EXOUdMKSJIUrVXYxwtd0ryh1Jey2YmIWX6/m/nieHxcqXDZLQWbkxrJuUhuGETjmcOLgENspnjZ1vSISk85phDw5O8oE=; 24:ExBD2Qvc+uPepbcEHOQEUhN3dVfjbGoTgJG+83jnMxhML/z+2/LcRoowm+rhp0fwN9u5zM/Ty9sz0iL9EJnX6RFs+UcnCY1Zr2ZCUhBU99s=; 7:U+MIfRAlzotaJk/NUKa7hlIfpkSu4VVZurw+eu/KW/O7QgSKLBis7N/rawZX41pvOSdE7fYlbmgZZKJcstbI5nX++cK51iSthKQwUBVYaMn5TNBXQJh+h90aK21j2JaMaS0NPX5mxfcXbHMEXQaNFFjO4kfdAyvk/ORs3ZCjjomUB9fusDGmiSyMkhjN1pyKrIyvTqjussTGPjrukAjr2BQ9RXT0ChnyhCvzTijrzZ4IoYZqou2pwyJPh+8UkkZH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2017 23:01:36.0751 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d4fd54f-faee-4d56-3cd6-08d526fca9a8 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1335 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.32.59 Subject: [Qemu-devel] [PATCH v4 19/45] hw/ipmi: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- V3: - Remove left over include V2: - Split hw patch into individual directories hw/ipmi/ipmi_bmc_extern.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index abab3bba4f..8c0535d3dd 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -28,6 +28,7 @@ */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "qemu/timer.h" #include "chardev/char-fe.h" @@ -194,8 +195,8 @@ static void ipmi_bmc_extern_handle_command(IPMIBmc *b, if (ibe->outlen) { /* We already have a command queued. Shouldn't ever happen. */ - fprintf(stderr, "IPMI KCS: Got command when not finished with the" - " previous command\n"); + error_report("IPMI KCS: Got command when not finished with the" + " previous command"); abort(); }