From patchwork Fri Sep 1 16:51:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 808829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="0PDGqMB3"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xkQNY0fHzz9t2x for ; Sat, 2 Sep 2017 02:55:41 +1000 (AEST) Received: from localhost ([::1]:50044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnpEJ-0005q4-5F for incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 12:55:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnpDh-0005oX-9S for qemu-devel@nongnu.org; Fri, 01 Sep 2017 12:55:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnpDc-00063C-DN for qemu-devel@nongnu.org; Fri, 01 Sep 2017 12:55:01 -0400 Received: from mail-bn3nam01on0076.outbound.protection.outlook.com ([104.47.33.76]:19424 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnpDc-00062y-7F for qemu-devel@nongnu.org; Fri, 01 Sep 2017 12:54:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ws9jIhRkxTgskZV/DyXmAidbISqzsJ7U4VsTeI5SqnU=; b=0PDGqMB3mKpqYuraif5Ytmx7bmfSgcZ6C9vnyCPyUmDK1wnT6e3F9ULCAd7ds3v32dwr3V+fSNIkVu6a5V85C8akN/O9Adp/CwqWVKvP1WQ1IUfLt6mqFzA3ZWcNq12qj1QyBR/ev3mN5FZzoSGipTrC2E600lSK7O74DQwZ7Mo= Received: from BN6PR02CA0045.namprd02.prod.outlook.com (10.173.146.159) by SN1PR0201MB1933.namprd02.prod.outlook.com (10.163.87.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Fri, 1 Sep 2017 16:54:54 +0000 Received: from BL2NAM02FT050.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::204) by BN6PR02CA0045.outlook.office365.com (2603:10b6:404:5f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Fri, 1 Sep 2017 16:54:54 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT050.mail.protection.outlook.com (10.152.77.101) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11 via Frontend Transport; Fri, 1 Sep 2017 16:54:53 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1dnpDZ-0002aG-2L; Fri, 01 Sep 2017 09:54:53 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dnpDY-0003eO-Vn; Fri, 01 Sep 2017 09:54:53 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v81Gsh0u028937; Fri, 1 Sep 2017 09:54:43 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dnpDO-0003cF-Vj; Fri, 01 Sep 2017 09:54:43 -0700 From: Alistair Francis To: Date: Fri, 1 Sep 2017 09:51:05 -0700 Message-ID: <5bf40ca8376c537ac05dd848a84e072a88a1d939.1504228916.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23296.003 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(189002)(199003)(54906002)(5660300001)(5003940100001)(189998001)(15650500001)(110136004)(8936002)(50226002)(63266004)(2906002)(47776003)(9786002)(6666003)(6916009)(2950100002)(8676002)(77096006)(118296001)(478600001)(81156014)(81166006)(50986999)(36386004)(76176999)(36756003)(50466002)(626005)(48376002)(39060400002)(33646002)(4326008)(2351001)(356003)(106466001)(305945005)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0201MB1933; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT050; 1:D9m3FSmc11d1b632k6MzrYJcUlhogtFoZKfx1TsdAWVnirjvrA9Vzvrd4ePi8ivlnKgiegN4hyccfwLT6sFRsBTKzQ41cvDj43GkfKUuVymGFqXsH2YzjyC8bo0tzBjN MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c098d5c-3929-43e1-b407-08d4f15a2b04 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN1PR0201MB1933; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1933; 3:hHTfvPc0Endu/PGXyK8DnMguQYlAYOwEFKo1Jd5iKncsmw3we+uF7T41xBZQ3/dndwxbOD7c7PZn1Qsy7uyWmMsSEE3bmRqpNyVSzU8J4RNGeprBor+Cw3p3jkhDy+VD5t1me85GMqG4LoDAEuwRCdwb26hw4ozzGjFwpvatP2G1u43tbNFVxn1FQRIvynTPp1VGX+MQgO8cN4c7C5MGefnihcge4gGWKl72JgFgl+UrSwyvdMSpb5Aeubb4RACoLLshh0QK3R33Up40LIYdaovC6Tyah25JShg3mXt+1JQiIEkStCjnLP59buvO5W0SCerqrEmbRUloLwqqzQI/yFR4eSJbi3Lj1doTAQtLAg4=; 25:i9sOWmkJfjK0xQKYp2GUD3Ctev4nVZIBd1sykCuR8imGfLGAn1pmDDx3b2UuVcZ/YCTFXWrbWi+JvpHx9dP0uKjhnN+bI37+5t17CoVZ5q/nyOUkxJoRJoiz6FdNA2URNhlKJgAJp1ooWiHbL7J5eV4CszZdzV1ETGz16ea2a3ikwwg4V6gnhOEvUIDXfbCCYMmi5EWECadDafbeSzIXszcou5R1wfuSeUDDnqeCmsuzgf2fil7eV85pBuZJlYVnWWydbucbx5ZmfUiQb0TNId65eM+dKem3Kf07clEPhO8FeBKPmdlMzCckJJuVmt6SjWRuNUeFsXZF+h/GmY33tQ== X-MS-TrafficTypeDiagnostic: SN1PR0201MB1933: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1933; 31:7t8JF2lfLoJc6LEGk3Zxi0+fIt1naSjAU+Tx65ZXsPgfSOBrqyAtgDaxT9FaMG8b5rs5lqHra4YI1OjbBWoeMIZtIUWT/aLUKxXqr9eGyZaZ3uyUG1abaD/WMe8r+jPhZt6vOSciptD50zbtpxECdajUcp2cEMRCVauO+tajJo8bJV/fsBUElsVpI3v3ygRBsAcdAdN3vT7RPJS04mYgnonNRuZvDv+/E+QcnH8clPc=; 20:8S5w3F6Gg3maNMgd3aowwpIUsD/Pmxktqtzl6igWEW+tLQTnJxCovwCKhyfCCjHW3MRDKLltwk7226JAHe5lQXaM/mFgoipoFUGPt5mvzpVML91OJKKah0GdHFD3BW76sInQQTvmcirWzSdEnbq/W/sx45n33EmfLhmaPF3ynyLQRQ9b4KZd5hKU+MMvKRXMdTJKN2Djl0ItvekLjbIr/JE/W01C4EeOfzJqaa14GO8X8B2TxSlt3C8Tkk/2iiGly2kXHEw40xjKrybab7ntCOk/jLYx6tiahlg292OCPx0tFOKMqHO1mAVZ9dAIDjAluazeUeakUhj+a5ZGvbybrX2g5xeV8y9xvKQrf/owt1XGAffacjni+E48Mr7f6eY+uDPI7xhNsjgkjKeP0AamekJeejIibxT7UvElQ5xxXH8MOAnTMi0sMsOFvtyInikVvUpR9Pdufjgs4HWUeAy10WzHTPx3GiU1x56fZut1uJyLNerzOgRXM1hgydlkebdd X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(13018025)(5005006)(13016025)(10201501046)(3002001)(93006095)(93004095)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR0201MB1933; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR0201MB1933; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1933; 4:HnRioy+Qc78VJyMgdPi6FcNabGh2CDhWmw7WQGH6KkRD64qB7I2p5D6n/EWYBX+sYslU5/AfI663zbD5D/vQNTxB80U2BFufbtitkQwRSYyIco5xVkhb2zLo0fN/T8FyIQkTwzBHAJSyGQw5IoJ2lqYmwG+gTARlXxhQbKpv0OiPsxBXipDLbV2M+tdsXlzs5YLlQi16QvCMdpw85slzEMtRbLlOyLMsx48JHrUooQnRYFw9vN34Rls/lD/muKoS9Ee9BacGTT2w/b4AYEKu6goG2BFzc09qhuPBskW5lD4= X-Forefront-PRVS: 0417A3FFD2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0201MB1933; 23:awFF5ltfG24kBYe4salddlzkDwNSooa3L0vl8wf?= 7vj4vcuSidkFEnBfIawWATlRglFunAFn8G3P1WcP3xD9wxPInqY6C1Efp5Woj13skYf5F1zayQ49QlLKFv2Q+WkT60BYqJ8F1qwpTkYiSO4EnInsYg8/N+tXOtvNy5Xcm94pPNWwyI0m2eVOcXcMaO136H3nHMVomG1ufM7YsyLwgynVnoYB+zpYrwh+wSNPipSds4P3wFb9/y6y2hz1iUOTN/k9lTHzr7009T8XX/z9TFeS7+FWKs8D/Fa4m/P8EY22mS42+WeyEGHGi1knM5zeKGsnOwOfCbMNfOCt1/0Yljbgd5FyKygkRvkbhpKnPY5rzWIj50lWiR0KwUV0zvWy5l2AZQrBbOhtyBBnCzN10mTxx2lK1jYv/owJt7MmTEnGUTN68FvGm60m+1QpsPJuY7XeeOv2tXPupCHt2T2VwZDkTYScw5M77Al+0PTGM0pZHAwp9daXMwo6FN6ZCenMJguoYP+GKHmOvN79TsFPVos5DzST2Y4dZiKZiIget+0JzQIxCi68t5GvGvIDnKRQoeugTsKJLs92cKuSal2nnXlBrBNUJ6rcgqDqQEQxa2eNr6Mv7jYPZ5j+edqdGKq1Bqy15g/d1JU8N7nJAUOQyO1dUXEXxX8YHaJL+Ohap3oSCi/OW1uHKn748oHPQwcJiX1MM8Z8Hgxvwbzj+gYBvKGJHlLKEkpGs2CDeyhn9TR8fMv/RmHMLN5/xOTmxyFiHTNnRSdjyfRw2m+wSTNCUrozoNKdjPoq1fC8hGNB7lDsdwW/6TyKhT4Cwmp35p4qUgDntxn0/k20ZR3ZM4W7GB+ltFGeNWkPfmuQT0efLVLRuYbvsOPVGlc4qt0bKyOnAVvUal2axcqHynLL6JbBmkeZJiPHRjt2keQ6W/ggqumdKjU8HNGLfDBnLXrzFYIw+tBYRq0CsyVVZR8onrImUABH/a2sn2EhP6QtJotcOLhS/XBCt5M6wT9ZX9Z3UoSJgI2A/sdlF8ZRD13GSIkZ+4w== X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1933; 6:jxCb2L2JY3dy2iv4XJfafXibxKQxpH1ML9lJq4dHSbHCpl9ZBTU7bCSBngHfc1CJUvzagERiG78lRSJg/aPcmajyX1DdvNOXdo9OyKWJe2F8DRi34Lz+Usx+d+rqg1EUqCLDs04qZEH0SDe8zv6GJgFB2tbUbR/ELGuaslPjTlBpEIGIdgS/ohPluC7bcIdFR2twg7dVOHro66AnhsnifK97R4piUCI8M5onl3iyATECY4/vYtWlRz4+qyFnTfEZIB9lCeiz8hG4EgenSnF0dgN1s8F3XJVOREa60LcFWIkFyIfacVGcLCA9xU9+are/bDn7Kk/ED7qRaS98g078ZQ==; 5:CUMDPIecJWzpIkIFOjg7U3D1j0El6P+Heya0m9fgqaP0XwsLSdddwU7rCBvjV67CBSO036gPfUVGIqbpV2MkZEW1pPZ2Ebcd0pEcS0S+AqVJB3s5xXca17oJvo9MKQsV38hLYHPnlevgGkCTmTqJeQ==; 24:2xwc6IXS99fIcnJD1mSvUJLrw98mbLvFDcQSyPM7SNHncKinfDwUFDNS8Aov59+jwTlp8742jPDfwSRfYFgUv4r8CfAFHYMTUKksu3Qw/AU=; 7:dWqQ9i3scJ1q5B9g5yWIO03PEyV7ya52EwtI2xuiAD9UJjIYPcXxSfcjajwbdTRlQ4A6zcE+UUDJsou9gwSv4cmtVoUwDA5fFE/7ygHEyI0JA2V3FV0i0qM7Xfn8njdbk5rUaAlXNfv4MuAT9I9IliSg6BOGcGhV4OoxPj4kWu1ICK8u8JZBRpvphk1VDidNm5uHUFHjctbB2TEjCdPcaajv1Zo4HwWBlqk2YFTf4A0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2017 16:54:53.4661 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1933 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.76 Subject: [Qemu-devel] [PATCH v3 1/7] hw/i386: Improve some of the warning messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, pbonzini@redhat.com, armbru@redhat.com, Eduardo Habkost , alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alistair Francis Suggested-by: Eduardo Habkost Cc: Eduardo Habkost --- V3: - Improve the messages hw/i386/acpi-build.c | 15 ++++++++++----- hw/i386/pc.c | 7 +++---- hw/i386/pc_q35.c | 8 +++++--- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 98dd424678..142bd6433c 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2780,17 +2780,22 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) ACPI_BUILD_ALIGN_SIZE); if (tables_blob->len > legacy_table_size) { /* Should happen only with PCI bridges and -M pc-i440fx-2.0. */ - warn_report("migration may not work."); + warn_report("ACPI table size %u exceeds %d bytes," + " migration may not work", + tables_blob->len, legacy_table_size); + error_printf("Try removing CPUs, NUMA nodes, memory slots" + " or PCI bridges."); } g_array_set_size(tables_blob, legacy_table_size); } else { /* Make sure we have a buffer in case we need to resize the tables. */ if (tables_blob->len > ACPI_BUILD_TABLE_SIZE / 2) { /* As of QEMU 2.1, this fires with 160 VCPUs and 255 memory slots. */ - warn_report("ACPI tables are larger than 64k."); - warn_report("migration may not work."); - warn_report("please remove CPUs, NUMA nodes, " - "memory slots or PCI bridges."); + warn_report("ACPI table size %u exceeds %d bytes," + " migration may not work", + tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2); + error_printf("Try removing CPUs, NUMA nodes, memory slots" + " or PCI bridges."); } acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE); } diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 21081041d5..c882f8c2ea 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -384,7 +384,7 @@ ISADevice *pc_find_fdc0(void) warn_report("multiple floppy disk controllers with " "iobase=0x3f0 have been found"); error_printf("the one being picked for CMOS setup might not reflect " - "your intent\n"); + "your intent"); } return state.floppy; @@ -2098,9 +2098,8 @@ static void pc_machine_set_max_ram_below_4g(Object *obj, Visitor *v, } if (value < (1ULL << 20)) { - warn_report("small max_ram_below_4g(%"PRIu64 - ") less than 1M. BIOS may not work..", - value); + warn_report("Only %" PRIu64 " bytes of RAM below the 4GiB boundary," + "BIOS may not work with less than 1MiB", value); } pcms->max_ram_below_4g = value; diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 169a214d50..435eb2c458 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -101,9 +101,11 @@ static void pc_q35_init(MachineState *machine) lowmem = pcms->max_ram_below_4g; if (machine->ram_size - lowmem > lowmem && lowmem & ((1ULL << 30) - 1)) { - warn_report("Large machine and max_ram_below_4g(%"PRIu64 - ") not a multiple of 1G; possible bad performance.", - pcms->max_ram_below_4g); + warn_report("Large machine as the ram size (0x%" PRIx64 ") is more" + " then twice the size of the internal limit" + " (0x%" PRIx64 ") and max-ram-below-4g (%"PRIu64")" + " note a multiple of 1G; possible bad performance.", + machine->ram_size, lowmem, pcms->max_ram_below_4g); } }