From patchwork Thu Sep 10 01:12:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiejun Chen X-Patchwork-Id: 516075 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 96244140281 for ; Thu, 10 Sep 2015 11:13:05 +1000 (AEST) Received: from localhost ([::1]:46311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZqQB-0000H8-GT for incoming@patchwork.ozlabs.org; Wed, 09 Sep 2015 21:13:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZqPv-0008LA-UV for qemu-devel@nongnu.org; Wed, 09 Sep 2015 21:12:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZqPr-0005Gm-H7 for qemu-devel@nongnu.org; Wed, 09 Sep 2015 21:12:47 -0400 Received: from mga03.intel.com ([134.134.136.65]:62708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZqPr-0005G8-77 for qemu-devel@nongnu.org; Wed, 09 Sep 2015 21:12:43 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 09 Sep 2015 18:12:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,500,1437462000"; d="scan'208";a="641886205" Received: from tiejunch-mobl1.ccr.corp.intel.com (HELO [10.238.128.161]) ([10.238.128.161]) by orsmga003.jf.intel.com with ESMTP; 09 Sep 2015 18:12:39 -0700 To: Stefano Stabellini References: From: "Chen, Tiejun" Message-ID: <55F0D906.4070606@intel.com> Date: Thu, 10 Sep 2015 09:12:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 Cc: peter.maydell@linaro.org, "xen-devel@lists.xensource.com Devel" , QEMU Developers Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 9/9/2015 9:06 PM, Stefano Stabellini wrote: > On Tue, 8 Sep 2015, Peter Maydell wrote: >> On 8 September 2015 at 18:21, Stefano Stabellini >> wrote: >> > The following changes since commit 8611280505119e296757a60711a881341603fa5a: >> > >> > target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200) >> > >> > are available in the git repository at: >> > >> > git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-09-08-tag >> > >> > for you to fetch changes up to ba2250ad148997b1352aba976aac66b55410e7e4: >> > >> > xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings. (2015-09-08 15:21:56 +0000) >> > >> > ---------------------------------------------------------------- >> > Xen branch xen-2015-09-08 >> > >> > ---------------------------------------------------------------- >> >> Hi. I'm afraid this fails to build on OSX (and probably Windows too, >> though that build hasn't run yet): >> >> CC i386-softmmu/hw/i386/pci-assign-load-rom.o >> /Users/pm215/src/qemu/hw/i386/pci-assign-load-rom.c:6:10: fatal error: >> 'sys/io.h' file not found >> #include >> ^ >> CC alpha-softmmu/hw/alpha/pci.o >> 1 error generated. > > Tiejun, > > this is caused by 33d33242b7d802e6c994f3d56ecba96a66465dc3, > "hw/pci-assign: split pci-assign.c". Could you please double-check > non-Linux builds? Its interesting. As you see this short log, "hw/pci-assign: split pci-assign.c", so this means I just extract something from the original hw/i386/kvm/pci-assign.c, and here so I just keep those original head files residing hw/i386/kvm/pci-assign.c, and I didn't introduce anything new. So its very probably that you still can't compile successfully even without my commit on OSX/Windows, right? I think Peter may be right, "Will passthrough even work on Windows and OSX hosts? Consider whether we should be building this code on those hosts at all..." I prefer this isn't what we did previously. > > > I suspect that the fix would be quite small, but I don't have an OSX or > a Windows build environment to try it. I haven't a this build environment as well. But I think right now you can remove "#include " to fix this simply since looks this is redundant actually. hw/i386/pci-assign: remove one head file This is redundant actually but really break OS/Windows build. Signed-off-by: Tiejun Chen At least I can build this under Linux, ./configure --target-list=x86_64-softmmu && make Thanks Tiejun > > Speak about build environments, Peter, would you care to share your > scripts and setup so that I can run similar tests in the future on my > own? I have no OSX machines so I tried to do a Windows > cross-compile, following http://wiki.qemu.org/Hosts/W32 on Debian 7, but > I failed very early with an "ERROR: zlib check failed". > diff --git a/hw/i386/pci-assign-load-rom.c b/hw/i386/pci-assign-load-rom.c index bad53b7..1f0d4ef 100644 --- a/hw/i386/pci-assign-load-rom.c +++ b/hw/i386/pci-assign-load-rom.c @@ -3,7 +3,6 @@ */ #include #include -#include #include #include #include