From patchwork Fri Apr 4 09:39:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 336883 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1B020140095 for ; Fri, 4 Apr 2014 20:40:23 +1100 (EST) Received: from localhost ([::1]:48676 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW0bk-0003LZ-QS for incoming@patchwork.ozlabs.org; Fri, 04 Apr 2014 05:40:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW0bH-0003KD-HN for qemu-devel@nongnu.org; Fri, 04 Apr 2014 05:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW0b8-0006LL-HW for qemu-devel@nongnu.org; Fri, 04 Apr 2014 05:39:51 -0400 Received: from mail-pb0-x22c.google.com ([2607:f8b0:400e:c01::22c]:32976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW0b8-0006Kz-A3; Fri, 04 Apr 2014 05:39:42 -0400 Received: by mail-pb0-f44.google.com with SMTP id rp16so3232304pbb.3 for ; Fri, 04 Apr 2014 02:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=c5jYVYJlc4mOkEkvv8frdYIDl3x5RlRmmRTVQmRLStM=; b=zVg53zB1YN1lf5ifdIQ8jHqaaJLh29miSpB5eKfbbvTVXvewS9+gaHJjwFgVWDh9v5 NNbVcykr8fxCCNRdlBB80zLHfAESrBArhxiSNeVIgLAgw3l6KhmyrmQuvryoss9wu06f doks96212W23Vcfuc0nVWqIUE7aNc1zXhMglSgsdF3GPkdgwauA/Q6xGYm4VRxBKt4s4 6Quhjh1aeK8qWcXdF+qNadO1NGaQ6QeCgqx8cq7bEKYd+I7GyGZ8F+UQIWYN+DtFlD4v C+j8bApEi4gQXAvMuDqiqnEzScHA4eSy6fkL7/NrxzQeBxPGyXYNIHZndcyRD805A51W Jk/A== X-Received: by 10.69.1.69 with SMTP id be5mr13922162pbd.126.1396604380784; Fri, 04 Apr 2014 02:39:40 -0700 (PDT) Received: from [192.168.1.104] ([124.126.231.64]) by mx.google.com with ESMTPSA id aj7sm38043755pad.29.2014.04.04.02.39.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Apr 2014 02:39:39 -0700 (PDT) Message-ID: <533E7DD5.3090203@gmail.com> Date: Fri, 04 Apr 2014 17:39:33 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Peter Maydell References: <53337BEB.90305@gmail.com> <87wqfgrp83.fsf@blackfin.pond.sub.org> <5333F6E2.9080202@gmail.com> <53382DDD.8050001@gmail.com> <87fvlylf02.fsf@blackfin.pond.sub.org> <53396545.805@gmail.com> <533969AB.4010505@gmail.com> <53396CE9.9090405@gmail.com> In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c01::22c Cc: QEMU Trivial , Markus Armbruster , Anthony Liguori , QEMU Developers Subject: [Qemu-devel] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When you ask for an accelerator not supported for your target, you get a bogus "accelerator does not exist" message: $ qemu-system-arm -machine none,accel=kvm KVM not supported for this target "kvm" accelerator does not exist. No accelerator found! Suppress it. Signed-off-by: Chen Gang Reviewed-by: Markus Armbruster Signed-off-by: Chen Gang --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 842e897..b4f98fa 100644 --- a/vl.c +++ b/vl.c @@ -2709,7 +2709,7 @@ static int configure_accelerator(QEMUMachine *machine) if (!accel_list[i].available()) { printf("%s not supported for this target\n", accel_list[i].name); - continue; + break; } *(accel_list[i].allowed) = true; ret = accel_list[i].init(machine);