From patchwork Tue Jun 11 12:29:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 250545 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6A4012C0082 for ; Tue, 11 Jun 2013 22:30:34 +1000 (EST) Received: from localhost ([::1]:47613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmNia-0004vX-2c for incoming@patchwork.ozlabs.org; Tue, 11 Jun 2013 08:30:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmNhy-0004Qh-HQ for qemu-devel@nongnu.org; Tue, 11 Jun 2013 08:29:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmNhx-0002L4-1S for qemu-devel@nongnu.org; Tue, 11 Jun 2013 08:29:54 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:46001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmNhw-0002Ko-PO; Tue, 11 Jun 2013 08:29:52 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 7ACDF41266; Tue, 11 Jun 2013 16:29:51 +0400 (MSK) Message-ID: <51B7183E.6070203@msgid.tls.msk.ru> Date: Tue, 11 Jun 2013 16:29:50 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 MIME-Version: 1.0 To: Peter Maydell References: <1370897240-23490-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: X-Enigmail-Version: 1.5.1 OpenPGP: id=804465C5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, "M. Mohan Kumar" , qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org 11.06.2013 01:45, Peter Maydell wrote: > On 10 June 2013 21:47, Michael Tokarev wrote: >> Or else >> >> ./configure --disable-system --enable-virtfs >> >> (which makes no sense by its own but does not error out) >> will fail to build, because it will define CONFIG_VIRTFS, >> and the makefile will try to build virtfs-proxy-helper >> manpage (but not the executable). >> >> Cc: qemu-trivial@nongnu.org >> Cc: M. Mohan Kumar >> Signed-off-by: Michael Tokarev >> --- >> configure | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/configure b/configure >> index a3f0b7a..0ff0380 100755 >> --- a/configure >> +++ b/configure >> @@ -3423,6 +3423,8 @@ if test "$softmmu" = yes ; then >> tools="qemu-ga\$(EXESUF) $tools" >> fi >> fi >> +else >> + virtfs=no >> fi > > This doesn't feel to me like it's quite the right way > to fix this bug. The current code in configure seems > to tangle up (a) was virtfs requested and can we do it? > with (b) what do we need to do if it was? (build some > extra tools) and (c) when does it make sense? not for > linux-user targets. So you end up with an 'else virtfs=no' > clause added in an odd place. If the mess was untangled > then this probably wouldn't be necessary. Um. I don't think that tangling is a bad thing really. Having different variables or options for it will be too bloated, in my opinion. I don't think there should be anything done with it. How about something like this: (BTW, why configure uses this "test" instead of more readable [ ] ? ) > Also, disabling building tools and docs in general seems > broken: --disable-tools disables building qemu-img, for > instance, but not its documentation. So maybe we should > fix this by generally making sure we don't build the docs > unless we build the tool as well. This has been addressed by a separate patch sent by afaerber. Thanks, /mjt --- a/configure +++ b/configure @@ -3810,7 +3810,7 @@ fi if test "$libattr" = "yes" ; then echo "CONFIG_LIBATTR=y" >> $config_host_mak fi -if test "$virtfs" = "yes" ; then +if test "$virtfs" = "yes" && test "$target_softmmu" = "yes" ; then echo "CONFIG_VIRTFS=y" >> $config_host_mak fi if test "$vhost_scsi" = "yes" ; then