From patchwork Tue Mar 12 15:54:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 227063 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9604B2C007B for ; Wed, 13 Mar 2013 02:54:40 +1100 (EST) Received: from localhost ([::1]:58811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRXC-0008Ah-SC for incoming@patchwork.ozlabs.org; Tue, 12 Mar 2013 11:54:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRWt-00086k-Sc for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:54:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFRWn-0003ks-PP for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:54:19 -0400 Received: from ssl.dlhnet.de ([91.198.192.8]:46063 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRWn-0003kh-Hc for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:54:13 -0400 Received: from localhost (localhost [127.0.0.1]) by ssl.dlh.net (Postfix) with ESMTP id 07AA114540E; Tue, 12 Mar 2013 16:54:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ssl.dlh.net Received: from ssl.dlh.net ([127.0.0.1]) by localhost (ssl.dlh.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JxZYqM65LjXI; Tue, 12 Mar 2013 16:54:12 +0100 (CET) Received: from [172.21.12.60] (unknown [82.141.1.226]) by ssl.dlh.net (Postfix) with ESMTPSA id 9386B13F711; Tue, 12 Mar 2013 16:54:12 +0100 (CET) Message-ID: <513F4FA6.6000701@dlhnet.de> Date: Tue, 12 Mar 2013 16:54:14 +0100 From: Peter Lieven User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 MIME-Version: 1.0 To: "qemu-devel@nongnu.org" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 91.198.192.8 Cc: Kevin Wolf , Paolo Bonzini , Orit Wasserman , Stefan Hajnoczi Subject: [Qemu-devel] [RFC][PATCH 8/9] migration: do not sent zero_pages in bulk stage X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org if the dup_page is a zero_page do not send it at all. the memory at the destination reads as zero anyway. Signed-off-by: Peter Lieven --- arch_init.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch_init.c b/arch_init.c index 04c82e4..abd54a7 100644 --- a/arch_init.c +++ b/arch_init.c @@ -447,9 +447,11 @@ static int ram_save_block(QEMUFile *f, bool last_stage) bytes_sent = -1; if (ram_bulk_stage && is_dup_page(p)) { acct_info.dup_pages++; - bytes_sent = save_block_hdr(f, block, offset, cont, + if (p[0]) { + bytes_sent = save_block_hdr(f, block, offset, cont, RAM_SAVE_FLAG_COMPRESS); - qemu_put_byte(f, *p); + qemu_put_byte(f, *p); + } bytes_sent += 1; } else if (!ram_bulk_stage && migrate_use_xbzrle()) { current_addr = block->offset + offset;