From patchwork Tue Mar 12 15:51:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 227065 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1CF4D2C0291 for ; Wed, 13 Mar 2013 02:55:42 +1100 (EST) Received: from localhost ([::1]:54479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRUf-0003Ox-Hs for incoming@patchwork.ozlabs.org; Tue, 12 Mar 2013 11:52:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRTv-0002d3-72 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFRTn-0002pR-RP for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:51:15 -0400 Received: from ssl.dlhnet.de ([91.198.192.8]:46032 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRTn-0002p0-J5 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:51:07 -0400 Received: from localhost (localhost [127.0.0.1]) by ssl.dlh.net (Postfix) with ESMTP id 18A2114540E; Tue, 12 Mar 2013 16:51:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ssl.dlh.net Received: from ssl.dlh.net ([127.0.0.1]) by localhost (ssl.dlh.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0EAC9jjgKbrH; Tue, 12 Mar 2013 16:51:06 +0100 (CET) Received: from [172.21.12.60] (unknown [82.141.1.226]) by ssl.dlh.net (Postfix) with ESMTPSA id 8D70F13F711; Tue, 12 Mar 2013 16:51:06 +0100 (CET) Message-ID: <513F4EEC.9050903@dlhnet.de> Date: Tue, 12 Mar 2013 16:51:08 +0100 From: Peter Lieven User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 MIME-Version: 1.0 To: "qemu-devel@nongnu.org" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 91.198.192.8 Cc: Kevin Wolf , Paolo Bonzini , Orit Wasserman , Stefan Hajnoczi Subject: [Qemu-devel] [RFC][PATCH 5/9] migration: check for dup pages only in bulk stage X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org pages are dup (most likely zero) from the very beginning. unless there is an application running inside the VM zeroing out large areas of memory its wasted time for checking for dup pages after the bulk stage. Signed-off-by: Peter Lieven --- arch_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index d48b914..3d09327 100644 --- a/arch_init.c +++ b/arch_init.c @@ -445,7 +445,7 @@ static int ram_save_block(QEMUFile *f, bool last_stage) /* In doubt sent page as normal */ bytes_sent = -1; - if (is_dup_page(p)) { + if (ram_bulk_stage && is_dup_page(p)) { acct_info.dup_pages++; bytes_sent = save_block_hdr(f, block, offset, cont, RAM_SAVE_FLAG_COMPRESS);