From patchwork Mon Mar 5 10:29:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Cave-Ayland X-Patchwork-Id: 144646 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2CC5BB6F62 for ; Mon, 5 Mar 2012 21:30:35 +1100 (EST) Received: from localhost ([::1]:46801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4VBZ-0008At-16 for incoming@patchwork.ozlabs.org; Mon, 05 Mar 2012 05:30:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4VBJ-0007xx-0C for qemu-devel@nongnu.org; Mon, 05 Mar 2012 05:30:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4VBD-0004dZ-J8 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 05:30:16 -0500 Received: from p15195424.pureserver.info ([82.165.34.74]:39481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4VAg-0004Ry-Aw; Mon, 05 Mar 2012 05:29:38 -0500 Received: from 93-97-95-250.zone5.bethere.co.uk ([93.97.95.250] helo=[192.168.1.76]) by p15195424.pureserver.info with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.43) id 1S4VAc-000326-7o; Mon, 05 Mar 2012 10:29:36 +0000 Message-ID: <4F54958F.4050506@ilande.co.uk> Date: Mon, 05 Mar 2012 10:29:35 +0000 From: Mark Cave-Ayland User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120207 Icedove/3.0.11 MIME-Version: 1.0 To: Avi Kivity , qemu-ppc@nongnu.org, qemu-devel@nongnu.org References: <4F53AF2A.10804@ilande.co.uk> <4F548CBD.5030308@redhat.com> In-Reply-To: <4F548CBD.5030308@redhat.com> X-SA-Exim-Connect-IP: 93.97.95.250 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.1 (built Wed, 05 Jan 2005 10:54:05 -0500) X-SA-Exim-Scanned: Yes (on p15195424.pureserver.info) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 82.165.34.74 Subject: Re: [Qemu-devel] PPC: VGA broken in git master X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 05/03/12 09:51, Avi Kivity wrote: > On 03/04/2012 08:06 PM, Mark Cave-Ayland wrote: >> Hi all, >> >> I've just done a git pull to update my local repository, and it now >> appears that the VGA device is broken in QEMU - rather than displaying >> the OpenBIOS banner in my VNC client, the framebuffer remains >> constantly black. >> >> A git bisect shows that the problem is caused by the following commit: >> >> >> de58ac72b6a062d1a61478284c0c0f8a0428613e is the first bad commit >> commit de58ac72b6a062d1a61478284c0c0f8a0428613e >> Author: Avi Kivity >> Date: Sun Jan 8 19:46:17 2012 +0200 >> >> ioport: change portio_list not to use memory_region_set_offset() >> >> memory_region_set_offset() will be going away soon, so don't use it. >> Use an alias instead. >> >> Signed-off-by: Avi Kivity >> Reviewed-by: Richard Henderson >> >> >> Avi/Richard - please would it be possible for you to review this >> commit and come up with a suitable fix? >> > > Can you provide the command line needed to reproduce the problem? Sure. I can reproduce it here using something as simple as: ./qemu-system-ppc -cdrom /dev/null -boot d -vnc :1 What you'll see is that the framebuffer remains black in your VNC client, as opposed to displaying the OpenBIOS startup banner. Note that de58ac72b6a062d1a61478284c0c0f8a0428613e (and the previous commit) have a qdev bug which segfaults qemu-system-ppc on startup, however the attached patch will resolve this for you. I've also confirmed over the weekend that the bug also affects SPARC64, although testing shows that SPARC32 still seems to work okay. HTH, Mark. diff --git a/hw/escc.c b/hw/escc.c index 9fe282f..0ed9e8a 100644 --- a/hw/escc.c +++ b/hw/escc.c @@ -695,8 +695,8 @@ MemoryRegion *escc_init(target_phys_addr_t base, qemu_irq irqA, qemu_irq irqB, qdev_prop_set_uint32(dev, "disabled", 0); qdev_prop_set_uint32(dev, "frequency", clock); qdev_prop_set_uint32(dev, "it_shift", it_shift); - qdev_prop_set_chr(dev, "chrB", chrB); - qdev_prop_set_chr(dev, "chrA", chrA); + //qdev_prop_set_chr(dev, "chrB", chrB); + //qdev_prop_set_chr(dev, "chrA", chrA); qdev_prop_set_uint32(dev, "chnBtype", ser); qdev_prop_set_uint32(dev, "chnAtype", ser); qdev_init_nofail(dev);