From patchwork Thu Nov 25 01:06:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wen Congyang X-Patchwork-Id: 72966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 84A15B70A8 for ; Thu, 25 Nov 2010 12:07:00 +1100 (EST) Received: from localhost ([127.0.0.1]:58689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLQIa-0004nn-RT for incoming@patchwork.ozlabs.org; Wed, 24 Nov 2010 20:06:56 -0500 Received: from [140.186.70.92] (port=51475 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLQHX-0004VU-Sq for qemu-devel@nongnu.org; Wed, 24 Nov 2010 20:05:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLQHW-0007WJ-DZ for qemu-devel@nongnu.org; Wed, 24 Nov 2010 20:05:51 -0500 Received: from [222.73.24.84] (port=51187 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLQHW-0007Vw-3c for qemu-devel@nongnu.org; Wed, 24 Nov 2010 20:05:50 -0500 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 4D59F17115E; Thu, 25 Nov 2010 09:05:43 +0800 (CST) Received: from mailserver.fnst.cn.fujitus.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id oAP11Ap6011458; Thu, 25 Nov 2010 09:01:10 +0800 Received: from [10.167.225.226] ([10.167.225.226]) by mailserver.fnst.cn.fujitus.com (Lotus Domino Release 8.5.1FP4) with ESMTP id 2010112509055922-96862 ; Thu, 25 Nov 2010 09:05:59 +0800 Message-ID: <4CEDB67D.9070904@cn.fujitsu.com> Date: Thu, 25 Nov 2010 09:06:05 +0800 From: Wen Congyang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: Luiz Capitulino References: <4CEB5406.3060300@cn.fujitsu.com> <20101123104348.5d44e89e@doriath> <20101123113159.4aab053a@doriath> <4CEC6A56.8080309@cn.fujitsu.com> <20101124154857.10657aa1@doriath> In-Reply-To: <20101124154857.10657aa1@doriath> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2010-11-25 09:05:59, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2010-11-25 09:06:00, Serialize complete at 2010-11-25 09:06:00 X-detected-operating-system: by eggs.gnu.org: FreeBSD 6.x (1) Cc: armbru@redhat.com, qemu-devel Subject: [Qemu-devel] [PATCH v2] correct migrate_set_speed's args_type X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped. This bug was caused by 07de3e60b05 and hence affects master only. Signed-off-by: Wen Congyang --- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.1 diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..16bdb08 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,