From patchwork Thu Apr 29 16:24:43 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 51300 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 43C58B7D2E for ; Fri, 30 Apr 2010 02:29:12 +1000 (EST) Received: from localhost ([127.0.0.1]:60156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7Wbu-0004Bh-7Z for incoming@patchwork.ozlabs.org; Thu, 29 Apr 2010 12:29:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O7WXm-0002G8-QY for qemu-devel@nongnu.org; Thu, 29 Apr 2010 12:24:54 -0400 Received: from [140.186.70.92] (port=60100 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7WXh-0002Bv-Hc for qemu-devel@nongnu.org; Thu, 29 Apr 2010 12:24:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O7WXg-0003cw-4W for qemu-devel@nongnu.org; Thu, 29 Apr 2010 12:24:49 -0400 Received: from thoth.sbs.de ([192.35.17.2]:24640) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O7WXf-0003cd-Rg for qemu-devel@nongnu.org; Thu, 29 Apr 2010 12:24:48 -0400 Received: from mail2.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id o3TGOisF021680; Thu, 29 Apr 2010 18:24:44 +0200 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail2.siemens.de (8.12.11.20060308/8.12.11) with ESMTP id o3TGOh6V027017; Thu, 29 Apr 2010 18:24:44 +0200 Message-ID: <4BD9B2CB.7060107@siemens.com> Date: Thu, 29 Apr 2010 18:24:43 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: Gerd Hoffmann Subject: [Qemu-devel] [PATCH] Fix tiny leak in qemu_opts_parse X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qemu_opts_create duplicates the id we pass in case it shall be stored in the opts. So we do not need to dup it in qemu_opts_parse, leaking a few bytes this way. Signed-off-by: Jan Kiszka --- qemu-option.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 1ffc497..076dddf 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -763,10 +763,10 @@ QemuOpts *qemu_opts_parse(QemuOptsList *list, const char *params, if (strncmp(params, "id=", 3) == 0) { get_opt_value(value, sizeof(value), params+3); - id = qemu_strdup(value); + id = value; } else if ((p = strstr(params, ",id=")) != NULL) { get_opt_value(value, sizeof(value), p+4); - id = qemu_strdup(value); + id = value; } opts = qemu_opts_create(list, id, 1); if (opts == NULL)