From patchwork Mon Jan 18 11:15:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 43059 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 496ABB7C9C for ; Mon, 18 Jan 2010 22:26:50 +1100 (EST) Received: from localhost ([127.0.0.1]:44962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWpjV-0005e0-K1 for incoming@patchwork.ozlabs.org; Mon, 18 Jan 2010 06:25:21 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWpZo-0007xH-VB for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWpZi-0007qa-5q for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:19 -0500 Received: from [199.232.76.173] (port=33522 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWpZh-0007qK-TZ for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:14 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:35738) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWpZg-0003h0-HH for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:13 -0500 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate03.web.de (Postfix) with ESMTP id 9A9E513C44278; Mon, 18 Jan 2010 12:15:04 +0100 (CET) Received: from [92.74.62.226] (helo=[139.25.109.167]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #314) id 1NWpZY-0007h6-00; Mon, 18 Jan 2010 12:15:04 +0100 Message-ID: <4B5442B5.5070409@web.de> Date: Mon, 18 Jan 2010 12:15:01 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Gerd Hoffmann References: <4B50CAEA.6070900@web.de> <4B5428C5.4050309@redhat.com> <4B543618.9030602@web.de> <4B543C33.1070701@redhat.com> In-Reply-To: <4B543C33.1070701@redhat.com> X-Enigmail-Version: 0.95.7 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1+JszM2we9klQFyYFm9QqqnM/jKEMDWjNWaA2D8 C2Lvf2qCo5bkulJXbUFhz+wbhdeMO/ct4Yr72zX4ckl+ZEpHbY PFWTCHJ7E= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 Cc: Anthony Liguori , qemu-devel Subject: [Qemu-devel] [PATCH][STABLE] Drop debug printfs from qemu_chr_parse_compat X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Gerd Hoffmann wrote: > On 01/18/10 11:21, Jan Kiszka wrote: >> Gerd Hoffmann wrote: >>> On 01/15/10 21:07, Jan Kiszka wrote: >>>> The missing '@' broke 'udp::@:' parsing. >>> >>>> if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)< 2) { >>>> host[0] = 0; >>>> - if (sscanf(p, ":%32[^,]%n", port,&pos)< 1) { >>>> + if (sscanf(p, ":%32[^@,]%n", port,&pos)< 1) { >>> >>> Indeed. >>> >>>> fprintf(stderr, "udp #1\n"); >>> >>> While you are at it, can you also zap this debug leftover? >> >> Looks like there are three of them in qemu_chr_parse_compat - kill >> them all? > > Yes. > > thanks, > Gerd > Signed-off-by: Jan Kiszka Acked-by: Gerd Hoffmann --- qemu-char.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a8a92f5..ef7823f 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2315,7 +2315,6 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename) if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port, &pos) < 2) { host[0] = 0; if (sscanf(p, ":%32[^@,]%n", port, &pos) < 1) { - fprintf(stderr, "udp #1\n"); goto fail; } } @@ -2326,7 +2325,6 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename) if (sscanf(p, "%64[^:]:%32[^,]%n", host, port, &pos) < 2) { host[0] = 0; if (sscanf(p, ":%32[^,]%n", port, &pos) < 1) { - fprintf(stderr, "udp #2\n"); goto fail; } } @@ -2354,7 +2352,6 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename) } fail: - fprintf(stderr, "%s: fail on \"%s\"\n", __FUNCTION__, filename); qemu_opts_del(opts); return NULL; }