From patchwork Thu Oct 15 14:10:49 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roy Tam X-Patchwork-Id: 36113 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7904BB7B78 for ; Fri, 16 Oct 2009 01:12:41 +1100 (EST) Received: from localhost ([127.0.0.1]:38909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyR4I-0007SX-H2 for incoming@patchwork.ozlabs.org; Thu, 15 Oct 2009 10:12:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyR2f-00073R-7m for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyR2a-00071O-8B for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:56 -0400 Received: from [199.232.76.173] (port=49592 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyR2Z-00071J-Td for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:51 -0400 Received: from mail-px0-f179.google.com ([209.85.216.179]:50441) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MyR2Z-00023N-GY for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:51 -0400 Received: by pxi9 with SMTP id 9so97134pxi.4 for ; Thu, 15 Oct 2009 07:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=VIE9ODK8QpaSl5pbj55NK7vnI61fIUORaODMVwxvv/M=; b=Y2Ab8KjSoznU4uRjNFyopa0aHGwAvSOnSKzmuoUybVUzkCP7whmVnEReuuFUOKTF7s Tt1wWKVhKKwGzHya6ZY2mxTxPNDGeZCQtRoZjQG3ypAdzlIw2c8xtTVyW/xYBgCD8IYW qFIi+9YRqEoX0lQewiADEas26SNDlvqXzt6Hk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=T6BvELSuhlLx3FkM4n+4V2ndyTP0VO/JfXWj0iSiIPeLPOwomtGuOn1tUb02VAKYiK VRQVkVvW2EXfYg/Sns7gXukNN6XAw6K6IgkjgOdeXidF1oAWd179mYcmxlxes0xZweyG ggZYJ72OYaV9D6VyMkeeOLxJdz1cEK3Q7upAU= MIME-Version: 1.0 Received: by 10.115.80.18 with SMTP id h18mr79430wal.53.1255615849698; Thu, 15 Oct 2009 07:10:49 -0700 (PDT) In-Reply-To: <20091015094622.GA18638@volta.aurel32.net> References: <473191350910132348y7e9b9738wdf591b0589a9e86a@mail.gmail.com> <20091015094622.GA18638@volta.aurel32.net> Date: Thu, 15 Oct 2009 22:10:49 +0800 Message-ID: <473191350910150710o61fa2261h31808d72597946a@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present From: Roy Tam To: qemu-devel@nongnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org As i8259 in mips_jazz.c is not connect to isa bus correctly, this patch fix that. P.S.: just click the wrong button which sent to Aurelien only. resend to list. Signed-off-by: Roy Tam 2009/10/15 Aurelien Jarno : > On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote: >> As i8259 in mips_jazz.c is not connect to isa bus correctly, this >> patch fix that. > > It looks fine. Could you please resend the patch with a Signed-off-by: > >> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c >> index 3ff367d..281713c 100644 >> --- a/hw/mips_jazz.c >> +++ b/hw/mips_jazz.c >> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size, >> >> /* ISA devices */ >> i8259 = i8259_init(env->irq[4]); >> + isa_bus_new(NULL); >> + isa_bus_irqs(i8259); >> DMA_init(0); >> pit = pit_init(0x40, i8259[0]); >> pcspk_init(pit); >> >> >> > > -- > Aurelien Jarno GPG: 1024D/F1BCDB73 > aurelien@aurel32.net http://www.aurel32.net > diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c index 3ff367d..281713c 100644 --- a/hw/mips_jazz.c +++ b/hw/mips_jazz.c @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size, /* ISA devices */ i8259 = i8259_init(env->irq[4]); + isa_bus_new(NULL); + isa_bus_irqs(i8259); DMA_init(0); pit = pit_init(0x40, i8259[0]); pcspk_init(pit);