| Message ID | 40de48d2-6acc-6525-34d4-cb2eec9977e8@zapateado.de |
|---|---|
| State | New |
| Headers | show |
| Series | Fix audio voices tests | expand |
On Sun, Sep 25, 2022 at 12:57 PM Helge Konetzka <hk@zapateado.de> wrote: > > Calling qemu with valid -audiodev ...,in.voices=0 results in an obsolete > warning: > audio: Bogus number of capture voices 0, setting to 0 > This patch fixes the in.voices test. > > Signed-off-by: Helge Konetzka <hk@zapateado.de> > weird case, ok :) Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > audio/audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/audio/audio.c b/audio/audio.c > index cfa4119c05..8a0ade4052 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -1756,7 +1756,7 @@ static AudioState *audio_init(Audiodev *dev, const > char *name) > s->nb_hw_voices_out = 1; > } > > - if (s->nb_hw_voices_in <= 0) { > + if (s->nb_hw_voices_in < 0) { > dolog ("Bogus number of capture voices %d, setting to 0\n", > s->nb_hw_voices_in); > s->nb_hw_voices_in = 0; > -- > 2.37.3 > >
On Sun, Sep 25, 2022 at 10:56:56AM +0200, Helge Konetzka wrote: > > Calling qemu with valid -audiodev ...,in.voices=0 results in an obsolete > warning: > audio: Bogus number of capture voices 0, setting to 0 > This patch fixes the in.voices test. > > Signed-off-by: Helge Konetzka <hk@zapateado.de> > --- > audio/audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/audio/audio.c b/audio/audio.c > index cfa4119c05..8a0ade4052 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -1756,7 +1756,7 @@ static AudioState *audio_init(Audiodev *dev, const > char *name) Patch is mangled (line-wrapped) here, 'git am' refuses to accept it. Please use 'git send-email' to post patches, thanks & take care, Gerd
diff --git a/audio/audio.c b/audio/audio.c index cfa4119c05..8a0ade4052 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1756,7 +1756,7 @@ static AudioState *audio_init(Audiodev *dev, const char *name) s->nb_hw_voices_out = 1; } - if (s->nb_hw_voices_in <= 0) { + if (s->nb_hw_voices_in < 0) { dolog ("Bogus number of capture voices %d, setting to 0\n", s->nb_hw_voices_in);
Calling qemu with valid -audiodev ...,in.voices=0 results in an obsolete warning: audio: Bogus number of capture voices 0, setting to 0 This patch fixes the in.voices test. Signed-off-by: Helge Konetzka <hk@zapateado.de> --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) s->nb_hw_voices_in = 0;