From patchwork Fri Aug 21 15:37:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?= X-Patchwork-Id: 509537 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2A6D5140772 for ; Sat, 22 Aug 2015 01:48:53 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=cu67MCdt; dkim-atps=neutral Received: from localhost ([::1]:42228 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSoYl-0001tO-9V for incoming@patchwork.ozlabs.org; Fri, 21 Aug 2015 11:48:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSoOA-0002Kv-OD for qemu-devel@nongnu.org; Fri, 21 Aug 2015 11:37:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSoO9-00023L-Fc for qemu-devel@nongnu.org; Fri, 21 Aug 2015 11:37:54 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:34868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSoO9-000234-6X for qemu-devel@nongnu.org; Fri, 21 Aug 2015 11:37:53 -0400 Received: by wicne3 with SMTP id ne3so19120368wic.0 for ; Fri, 21 Aug 2015 08:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=X6dWevmBjym+8xUSOP1VmPeZEhKJBSsEYoawti8BJLA=; b=cu67MCdtWpNAZur+uDqo2irY89OKKU0WKkMFNtUKT9YpH13HpyaRgHuCXKEQTKNfo5 EaTOsp3MH9YKigprWoBq78X0rdIgryizgj0keDVQELIp4zRGamhiIB+Ls3z1tVptDmGi cU/l3brOJpeTlQCWWCx/joMtGLDAFqstCzC4W1h+NtY1SfBfp2lR9/UAcbfre4FhbQIq 6I7fbE1cHEEvo2LG1A0cBQLrOSJi5TmJpHcsePignkr/8SX+9JO/LS0/MPW08z7CcMAh pqvvHBlGzYmUrA8ypQQwuEcqxsj85NiHxdKVAuN7WplLLSUF5XoSGXBWM76SXLwGWHnh amaQ== X-Received: by 10.194.23.36 with SMTP id j4mr16670906wjf.105.1440171472637; Fri, 21 Aug 2015 08:37:52 -0700 (PDT) Received: from nullptr.home.dirty-ice.org (178-164-172-216.pool.digikabel.hu. [178.164.172.216]) by smtp.gmail.com with ESMTPSA id v8sm10479895wjr.15.2015.08.21.08.37.52 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Aug 2015 08:37:52 -0700 (PDT) From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?=" X-Google-Original-From: =?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?= To: qemu-devel@nongnu.org Date: Fri, 21 Aug 2015 17:37:10 +0200 Message-Id: <3dcc28cf3d431d3af6ef04802a887fc90582ccaa.1440171025.git.DirtY.iCE.hu@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: References: MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::234 Cc: Gerd Hoffmann Subject: [Qemu-devel] [PATCH v2 14/49] coreaudio: port to -audiodev config X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 10 ++++++++++ audio/coreaudio.c | 47 ++++++++++------------------------------------- 2 files changed, 20 insertions(+), 37 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index bc830c5..4be972e 100644 --- a/audio/audio_legacy.c +++ b/audio/audio_legacy.c @@ -58,6 +58,14 @@ SimpleEnvMap alsa_map[] = { { /* End of list */ } }; +SimpleEnvMap coreaudio_map[] = { + { "QEMU_COREAUDIO_BUFFER_SIZE", "buffer-len", + ENV_TRANSFORM_FRAMES_TO_USECS_OUT }, + { "QEMU_COREAUDIO_BUFFER_COUNT", "buffer-count" }, + + { /* End of list */ } +}; + static unsigned long long toull(const char *str) { unsigned long long ret; @@ -228,6 +236,8 @@ static void legacy_opt(const char *drv) if (strcmp(drv, "alsa") == 0) { handle_env_opts(opts, alsa_map); handle_alsa(opts); + } else if (strcmp(drv, "coreaudio") == 0) { + handle_env_opts(opts, coreaudio_map); } } diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 3612511..dfa5e79 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -34,11 +34,6 @@ static int isAtexit; -typedef struct { - int buffer_frames; - int nbuffers; -} CoreaudioConf; - typedef struct coreaudioVoiceOut { HWVoiceOut hw; pthread_mutex_t mutex; @@ -292,7 +287,9 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as, int err; const char *typ = "playback"; AudioValueRange frameRange; - CoreaudioConf *conf = drv_opaque; + Audiodev *dev = drv_opaque; + AudiodevPerDirectionOptions *pdo = dev->out; + int frames; /* create mutex */ err = pthread_mutex_init(&core->mutex, NULL); @@ -334,16 +331,17 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as, return -1; } - if (frameRange.mMinimum > conf->buffer_frames) { + frames = audio_buffer_frames(pdo, as, 11610); + if (frameRange.mMinimum > frames) { core->audioDevicePropertyBufferFrameSize = (UInt32) frameRange.mMinimum; dolog ("warning: Upsizing Buffer Frames to %f\n", frameRange.mMinimum); } - else if (frameRange.mMaximum < conf->buffer_frames) { + else if (frameRange.mMaximum < frames) { core->audioDevicePropertyBufferFrameSize = (UInt32) frameRange.mMaximum; dolog ("warning: Downsizing Buffer Frames to %f\n", frameRange.mMaximum); } else { - core->audioDevicePropertyBufferFrameSize = conf->buffer_frames; + core->audioDevicePropertyBufferFrameSize = frames; } /* set Buffer Frame Size */ @@ -377,7 +375,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as, "Could not get device buffer frame size\n"); return -1; } - hw->samples = conf->nbuffers * core->audioDevicePropertyBufferFrameSize; + hw->samples = (pdo->has_buffer_count ? pdo->buffer_count : 4) * + core->audioDevicePropertyBufferFrameSize; /* get StreamFormat */ propertySize = sizeof(core->outputStreamBasicDescription); @@ -497,41 +496,16 @@ static int coreaudio_ctl_out (HWVoiceOut *hw, int cmd, ...) return 0; } -static CoreaudioConf glob_conf = { - .buffer_frames = 512, - .nbuffers = 4, -}; - static void *coreaudio_audio_init(Audiodev *dev) { - CoreaudioConf *conf = g_malloc(sizeof(CoreaudioConf)); - *conf = glob_conf; - atexit(coreaudio_atexit); - return conf; + return dev; } static void coreaudio_audio_fini (void *opaque) { - g_free(opaque); } -static struct audio_option coreaudio_options[] = { - { - .name = "BUFFER_SIZE", - .tag = AUD_OPT_INT, - .valp = &glob_conf.buffer_frames, - .descr = "Size of the buffer in frames" - }, - { - .name = "BUFFER_COUNT", - .tag = AUD_OPT_INT, - .valp = &glob_conf.nbuffers, - .descr = "Number of buffers" - }, - { /* End of list */ } -}; - static struct audio_pcm_ops coreaudio_pcm_ops = { .init_out = coreaudio_init_out, .fini_out = coreaudio_fini_out, @@ -543,7 +517,6 @@ static struct audio_pcm_ops coreaudio_pcm_ops = { struct audio_driver coreaudio_audio_driver = { .name = "coreaudio", .descr = "CoreAudio http://developer.apple.com/audio/coreaudio.html", - .options = coreaudio_options, .init = coreaudio_audio_init, .fini = coreaudio_audio_fini, .pcm_ops = &coreaudio_pcm_ops,