From patchwork Sat Dec 12 00:31:29 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 40942 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2320AB7B6B for ; Sat, 12 Dec 2009 12:39:32 +1100 (EST) Received: from localhost ([127.0.0.1]:60869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJGxF-0001R6-EU for incoming@patchwork.ozlabs.org; Fri, 11 Dec 2009 20:39:29 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJGi0-0007tr-5Y for qemu-devel@nongnu.org; Fri, 11 Dec 2009 20:23:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJGhr-0007nR-0r for qemu-devel@nongnu.org; Fri, 11 Dec 2009 20:23:35 -0500 Received: from [199.232.76.173] (port=54748 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJGhp-0007mJ-CM for qemu-devel@nongnu.org; Fri, 11 Dec 2009 20:23:33 -0500 Received: from are.twiddle.net ([75.149.56.221]:43442) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NJGhn-00036I-V2 for qemu-devel@nongnu.org; Fri, 11 Dec 2009 20:23:32 -0500 Received: by are.twiddle.net (Postfix, from userid 5000) id B232CC91; Fri, 11 Dec 2009 17:23:30 -0800 (PST) Message-Id: <35c75c5c09892e3635275e0aa6922148d284a94d.1260580414.git.rth@twiddle.net> In-Reply-To: References: From: Richard Henderson Date: Fri, 11 Dec 2009 16:31:29 -0800 To: qemu-devel@nongnu.org MIME-Version: 1.0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH 10/13] alpha: Expand ins*h inline. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Richard Henderson --- target-alpha/helper.h | 3 -- target-alpha/op_helper.c | 18 ---------------- target-alpha/translate.c | 51 ++++++++++++++++++++++++++++++++++++++++----- 3 files changed, 45 insertions(+), 27 deletions(-) diff --git a/target-alpha/helper.h b/target-alpha/helper.h index a545c5c..4eb3b6f 100644 --- a/target-alpha/helper.h +++ b/target-alpha/helper.h @@ -19,9 +19,6 @@ DEF_HELPER_1(cttz, i64, i64) DEF_HELPER_2(zap, i64, i64, i64) DEF_HELPER_2(zapnot, i64, i64, i64) -DEF_HELPER_2(inswh, i64, i64, i64) -DEF_HELPER_2(inslh, i64, i64, i64) -DEF_HELPER_2(insqh, i64, i64, i64) DEF_HELPER_2(cmpbge, i64, i64, i64) diff --git a/target-alpha/op_helper.c b/target-alpha/op_helper.c index b6ec0e8..d7f4fb2 100644 --- a/target-alpha/op_helper.c +++ b/target-alpha/op_helper.c @@ -185,24 +185,6 @@ uint64_t helper_zapnot(uint64_t val, uint64_t mask) return byte_zap(val, ~mask); } -uint64_t helper_inswh(uint64_t val, uint64_t mask) -{ - val >>= 64 - ((mask & 7) * 8); - return byte_zap(val, ~((0x03 << (mask & 7)) >> 8)); -} - -uint64_t helper_inslh(uint64_t val, uint64_t mask) -{ - val >>= 64 - ((mask & 7) * 8); - return byte_zap(val, ~((0x0F << (mask & 7)) >> 8)); -} - -uint64_t helper_insqh(uint64_t val, uint64_t mask) -{ - val >>= 64 - ((mask & 7) * 8); - return byte_zap(val, ~((0xFF << (mask & 7)) >> 8)); -} - uint64_t helper_cmpbge (uint64_t op1, uint64_t op2) { uint8_t opa, opb, res; diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 92d001d..d361ffe 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -625,6 +625,48 @@ static void gen_ext_l(int ra, int rb, int rc, int islit, } } +/* INSWH, INSLH, INSQH */ +static void gen_ins_h(int ra, int rb, int rc, int islit, + uint8_t lit, uint8_t byte_mask) +{ + if (unlikely(rc == 31)) + return; + else if (unlikely(ra == 31) || (islit && (lit & 7) == 0)) + tcg_gen_movi_i64(cpu_ir[rc], 0); + else { + TCGv tmp = tcg_temp_new(); + + /* The instruction description has us left-shift the byte mask + and extract bits <15:8> and apply that zap at the end. This + is equivalent to simply performing the zap first and shifting + afterward. */ + gen_zapnoti (tmp, cpu_ir[ra], byte_mask); + + if (islit) { + /* Note that we have handled the lit==0 case above. */ + tcg_gen_shri_i64 (cpu_ir[rc], tmp, 64 - (lit & 7) * 8); + } else { + TCGv shift = tcg_temp_new(); + + /* If (B & 7) == 0, we need to shift by 64 and leave a zero. + Do this portably by splitting the shift into two parts: + shift_count-1 and 1. Arrange for the -1 by using + ones-complement instead of twos-complement in the negation: + ~((B & 7) * 8) & 63. */ + + tcg_gen_andi_i64(shift, cpu_ir[rb], 7); + tcg_gen_shli_i64(shift, shift, 3); + tcg_gen_not_i64(shift, shift); + tcg_gen_andi_i64(shift, shift, 0x3f); + + tcg_gen_shr_i64(cpu_ir[rc], tmp, shift); + tcg_gen_shri_i64(cpu_ir[rc], cpu_ir[rc], 1); + tcg_temp_free(shift); + } + tcg_temp_free(tmp); + } +} + /* INSBL, INSWL, INSLL, INSQL */ static void gen_ins_l(int ra, int rb, int rc, int islit, uint8_t lit, uint8_t byte_mask) @@ -750,9 +792,6 @@ ARITH3(addlv) ARITH3(sublv) ARITH3(addqv) ARITH3(subqv) -ARITH3(inswh) -ARITH3(inslh) -ARITH3(insqh) ARITH3(umulh) ARITH3(mullv) ARITH3(mulqv) @@ -1479,7 +1518,7 @@ static inline int translate_one(DisasContext *ctx, uint32_t insn) break; case 0x57: /* INSWH */ - gen_inswh(ra, rb, rc, islit, lit); + gen_ins_h(ra, rb, rc, islit, lit, 0x03); break; case 0x5A: /* EXTWH */ @@ -1491,7 +1530,7 @@ static inline int translate_one(DisasContext *ctx, uint32_t insn) break; case 0x67: /* INSLH */ - gen_inslh(ra, rb, rc, islit, lit); + gen_ins_h(ra, rb, rc, islit, lit, 0x0f); break; case 0x6A: /* EXTLH */ @@ -1503,7 +1542,7 @@ static inline int translate_one(DisasContext *ctx, uint32_t insn) break; case 0x77: /* INSQH */ - gen_insqh(ra, rb, rc, islit, lit); + gen_ins_h(ra, rb, rc, islit, lit, 0xff); break; case 0x7A: /* EXTQH */