| Message ID | 20241010101838.331032-2-r.peniaev@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/7] chardev/char: rename `char-mux.c` to `char-mux-fe.c` | expand |
Hi Roman, On Thu, Oct 10, 2024 at 2:21 PM Roman Penyaev <r.peniaev@gmail.com> wrote: > In the following patches backend multiplexer will be > introduced and the implementation will be named as > follows: `char-mux-be.c`. This patch renames the > frontend multiplexer from `char-mux.c` to > `char-mux-fe.c`. > > Signed-off-by: Roman Penyaev <r.peniaev@gmail.com> > Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com> > Cc: qemu-devel@nongnu.org thanks, it looks like the series is missing a cover letter (and thus not handled by patchew) Also it seems to fail to apply on master, and I wonder if it will conflict with your other mux cleanup series. thanks > > --- > chardev/{char-mux.c => char-mux-fe.c} | 0 > chardev/meson.build | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename chardev/{char-mux.c => char-mux-fe.c} (100%) > > diff --git a/chardev/char-mux.c b/chardev/char-mux-fe.c > similarity index 100% > rename from chardev/char-mux.c > rename to chardev/char-mux-fe.c > diff --git a/chardev/meson.build b/chardev/meson.build > index 70070a8279a9..778444a00ca6 100644 > --- a/chardev/meson.build > +++ b/chardev/meson.build > @@ -2,7 +2,7 @@ chardev_ss.add(files( > 'char-fe.c', > 'char-file.c', > 'char-io.c', > - 'char-mux.c', > + 'char-mux-fe.c', > 'char-null.c', > 'char-pipe.c', > 'char-ringbuf.c', > -- > 2.34.1 > > >
On Mon, Oct 14, 2024 at 3:57 PM Marc-André Lureau <marcandre.lureau@gmail.com> wrote: > > Hi Roman, > > On Thu, Oct 10, 2024 at 2:21 PM Roman Penyaev <r.peniaev@gmail.com> wrote: >> >> In the following patches backend multiplexer will be >> introduced and the implementation will be named as >> follows: `char-mux-be.c`. This patch renames the >> frontend multiplexer from `char-mux.c` to >> `char-mux-fe.c`. >> >> Signed-off-by: Roman Penyaev <r.peniaev@gmail.com> >> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com> >> Cc: qemu-devel@nongnu.org > > > thanks, it looks like the series is missing a cover letter (and thus not handled by patchew) Bummer, indeed, sent only to myself. > > Also it seems to fail to apply on master, and I wonder if it will conflict with your other mux cleanup series. That's because of the "chardev/char: fix qemu_chr_is_busy() check". In the cover letter (which was never delivered) I specified that the whole series is based on this patch :) Let me rebase this series once we finish with the frontend detach patchset (sent today), so I'll rebase everything from here and mark it with version "v4". Thanks. -- Roman
diff --git a/chardev/char-mux.c b/chardev/char-mux-fe.c similarity index 100% rename from chardev/char-mux.c rename to chardev/char-mux-fe.c diff --git a/chardev/meson.build b/chardev/meson.build index 70070a8279a9..778444a00ca6 100644 --- a/chardev/meson.build +++ b/chardev/meson.build @@ -2,7 +2,7 @@ chardev_ss.add(files( 'char-fe.c', 'char-file.c', 'char-io.c', - 'char-mux.c', + 'char-mux-fe.c', 'char-null.c', 'char-pipe.c', 'char-ringbuf.c',
In the following patches backend multiplexer will be introduced and the implementation will be named as follows: `char-mux-be.c`. This patch renames the frontend multiplexer from `char-mux.c` to `char-mux-fe.c`. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com> Cc: qemu-devel@nongnu.org --- chardev/{char-mux.c => char-mux-fe.c} | 0 chardev/meson.build | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename chardev/{char-mux.c => char-mux-fe.c} (100%)