From patchwork Wed Sep 25 17:11:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1989480 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=AA/Nv/cD; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XDNb10VdBz1xt6 for ; Thu, 26 Sep 2024 03:12:44 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stVYf-0000yZ-IZ; Wed, 25 Sep 2024 13:12:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stVYO-0000K5-CI for qemu-devel@nongnu.org; Wed, 25 Sep 2024 13:11:55 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stVYJ-0000bW-By for qemu-devel@nongnu.org; Wed, 25 Sep 2024 13:11:51 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-42cb2191107so229325e9.1 for ; Wed, 25 Sep 2024 10:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727284306; x=1727889106; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EDuKUu/6yQVewIifCo34+Vf5uNGO51ibdAtzIBiO5J8=; b=AA/Nv/cD5A5XNGyTS9Byh0ZEgbCYPbTcrz8vRn3LDi+wP+jvx0Hcp2lT5MAzMeGROU DWEoOFPhe1Z2cnYO+6SRvfeBIKtUn4OkcMd16mrfLrIyVR+elBsUElfoPhcJeCvj869H D8CNrQxZo8VFjfk2xQyqEQfQQBvLAjyynspWG0GMO+biKiPIxqjO3ffbFNhD5vRi2Q5l vfC2451j6u/Lug0+Cqf0NYHbesRDiT5TOvVRvcUXBqeZ6JRNAoJj53jC7DwhgHPrZvzU 4JXcYBF61WsO1BGqdD3xTef0q5cnCxcNyZ2b9rHps6HL7a4NW/dbJTEms0e1HYfQwnz9 rTVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727284306; x=1727889106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EDuKUu/6yQVewIifCo34+Vf5uNGO51ibdAtzIBiO5J8=; b=YDu8hDIgfZ4SFBnRvhS7Y86NxWr3QRa5+bwmNzGqoto56p5CGo6tO4pL4nKp0gvUOT NGQOGO4vaz68ty1AAa0UZlrA1G0SOGiX6FU8Jf1DzK8QoFgJ7lPyw1PG1CTBEssTEvvX c2Qc/F1wtEKP5SqZt1E20WWX7xnCmTpC9CWRRmgUFkX5D6VUK4RwQX8bQCbpASchh8+t VSel95tpjJHCAxuNpbtYvsCGH8VWFV6o1UoxflObPioZxxeGCN9/N2Ohc9BbGxSyePa6 G3i1GUMlSrrN2+urgLlWfoz/M489sxTCUxquaAiep2Rdlrsp44wwGZiE98phBWsjzqcu +OSw== X-Gm-Message-State: AOJu0YwCjImnrvYIcXHW6YTgdlfi/OdVFoeUPYCTZUgj096UrXNAnv4F 98pXU5LeCpmr5jO3Voqjn3PuXISlV1K7uOFxX166CLSvP1v4bp32/kjvOxUxgkI= X-Google-Smtp-Source: AGHT+IEA9zk5J4EgLwcu9iKTkG6OebG0V871ScTHwgvkLHU/Z/qAW1uTvFwLsqIXWyXSVXC9pmkYyw== X-Received: by 2002:a05:600c:a085:b0:42f:310f:de9 with SMTP id 5b1f17b1804b1-42f310f1005mr13936295e9.15.1727284305716; Wed, 25 Sep 2024 10:11:45 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e969e18f7sm24065735e9.5.2024.09.25.10.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 10:11:44 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id E015C5FA3D; Wed, 25 Sep 2024 18:11:40 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Zhao Liu , "Edgar E. Iglesias" , Marcel Apfelbaum , Alexandre Iooss , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Mahmoud Mandour , =?utf-8?q?Daniel_P=2E_Berrang?= =?utf-8?q?=C3=A9?= , Richard Henderson , Paolo Bonzini , Eduardo Habkost , Pierrick Bouvier , Wainer dos Santos Moschetta , kvm@vger.kernel.org, Jiaxun Yang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , qemu-arm@nongnu.org, Peter Maydell , devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Marcelo Tosatti , Laurent Vivier , Yanan Wang , Thomas Huth , Beraldo Leal Subject: [PATCH 06/10] target/i386: fix build warning (gcc-12 -fsanitize=thread) Date: Wed, 25 Sep 2024 18:11:36 +0100 Message-Id: <20240925171140.1307033-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240925171140.1307033-1-alex.bennee@linaro.org> References: <20240925171140.1307033-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Pierrick Bouvier Found on debian stable. ../target/i386/kvm/kvm.c: In function ‘kvm_handle_rdmsr’: ../target/i386/kvm/kvm.c:5345:1: error: control reaches end of non-void function [-Werror=return-type] 5345 | } | ^ ../target/i386/kvm/kvm.c: In function ‘kvm_handle_wrmsr’: ../target/i386/kvm/kvm.c:5364:1: error: control reaches end of non-void function [-Werror=return-type] 5364 | } Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Message-Id: <20240910174013.1433331-3-pierrick.bouvier@linaro.org> Signed-off-by: Alex Bennée --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index ada581c5d6..c8056ef83d 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5771,7 +5771,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) @@ -5790,7 +5790,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static bool has_sgx_provisioning;