Message ID | 20240924130222.748369-9-marcandre.lureau@redhat.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=U3F3/by7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XCg8w6Yqdz1xst for <incoming@patchwork.ozlabs.org>; Tue, 24 Sep 2024 23:06:08 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces@nongnu.org>) id 1st5Dc-0003vK-JY; Tue, 24 Sep 2024 09:04:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>) id 1st5Da-0003ie-OM for qemu-devel@nongnu.org; Tue, 24 Sep 2024 09:04:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>) id 1st5DZ-000080-6Y for qemu-devel@nongnu.org; Tue, 24 Sep 2024 09:04:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727183076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TbV9ZakF44C4gPu/dzMAxSKaBPNMHPS3TqhrfNh0O0w=; b=U3F3/by7eQxW+C/fcmN+YxibLEsvpkNAG+6ZnAbhHRWyak94eg8CVb8cXTpN1PqmmXA3T5 L1VyTAccEHGJ3cM2PxnjZRU7JkJajLQZTNm2D5U4axu/PIHe5+6uV78m2vUA6jDrsS0mTx auUvFBO8g99T7pm/gg3DvenbqVWCA+0= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-zgH54WJ5Mgi6sUCnCjq_Rg-1; Tue, 24 Sep 2024 09:03:28 -0400 X-MC-Unique: zgH54WJ5Mgi6sUCnCjq_Rg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5270518EBF15; Tue, 24 Sep 2024 13:03:25 +0000 (UTC) Received: from localhost (unknown [10.39.208.3]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 917E830001A1; Tue, 24 Sep 2024 13:03:23 +0000 (UTC) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= <philmd@linaro.org>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Hanna Reitz <hreitz@redhat.com>, Greg Kurz <groug@kaod.org>, Paolo Bonzini <pbonzini@redhat.com>, Klaus Jensen <its@irrelevant.dk>, Stefano Garzarella <sgarzare@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>, Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, Fam Zheng <fam@euphon.net>, "Michael S. Tsirkin" <mst@redhat.com>, Keith Busch <kbusch@kernel.org>, Hyman Huang <yong.huang@smartx.com>, Laurent Vivier <laurent@vivier.eu>, Fabiano Rosas <farosas@suse.de>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Stefan Hajnoczi <stefanha@redhat.com>, Mahmoud Mandour <ma.mandourr@gmail.com>, Jesper Devantier <foss@defmacro.it>, Peter Xu <peterx@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Bin Meng <bmeng.cn@gmail.com>, Song Gao <gaosong@loongson.cn>, =?utf-8?q?Da?= =?utf-8?q?niel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Eugeni?= =?utf-8?q?o_P=C3=A9rez?= <eperezma@redhat.com>, Yuval Shaia <yuval.shaia.ml@gmail.com>, Kevin Wolf <kwolf@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, qemu-block@nongnu.org, Bin Meng <bin.meng@windriver.com>, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com> Subject: [PATCH v2 08/22] hw/ahci: fix -Werror=maybe-uninitialized false-positive Date: Tue, 24 Sep 2024 17:02:07 +0400 Message-ID: <20240924130222.748369-9-marcandre.lureau@redhat.com> In-Reply-To: <20240924130222.748369-1-marcandre.lureau@redhat.com> References: <20240924130222.748369-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.09, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org |
Series |
-Werror=maybe-uninitialized fixes
|
expand
|
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 7fc2a08df2..d700986c39 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -948,7 +948,6 @@ static int ahci_populate_sglist(AHCIDevice *ad, QEMUSGList *sglist, uint64_t sum = 0; int off_idx = -1; int64_t off_pos = -1; - int tbl_entry_size; IDEBus *bus = &ad->port; BusState *qbus = BUS(bus); @@ -976,6 +975,8 @@ static int ahci_populate_sglist(AHCIDevice *ad, QEMUSGList *sglist, /* Get entries in the PRDT, init a qemu sglist accordingly */ if (prdtl > 0) { AHCI_SG *tbl = (AHCI_SG *)prdt; + int tbl_entry_size = -1; + sum = 0; for (i = 0; i < prdtl; i++) { tbl_entry_size = prdt_tbl_entry_size(&tbl[i]);