| Message ID | 20240916085400.1046925-13-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | tcg plugins pre-PR (deprecations, mem apis, contrib plugins) | expand |
On Mon, 2024-09-16 at 09:53 +0100, Alex Bennée wrote: > The multiarch system tests output serial data which should be > redirected to the "output" chardev rather than echoed to the console. > > Comment the use of EXTFLAGS variable while we are at it. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
On 16/09/2024 10.53, Alex Bennée wrote: > The multiarch system tests output serial data which should be > redirected to the "output" chardev rather than echoed to the console. > > Comment the use of EXTFLAGS variable while we are at it. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target index f60f94b090..be242ba8f1 100644 --- a/tests/tcg/s390x/Makefile.softmmu-target +++ b/tests/tcg/s390x/Makefile.softmmu-target @@ -1,6 +1,7 @@ S390X_SRC=$(SRC_PATH)/tests/tcg/s390x VPATH+=$(S390X_SRC) -QEMU_OPTS+=-action panic=exit-failure -nographic $(EXTFLAGS) -kernel +# EXTFLAGS can be passed by the user, e.g. to override the --accel +QEMU_OPTS+=-action panic=exit-failure -nographic -serial chardev:output $(EXTFLAGS) -kernel LINK_SCRIPT=$(S390X_SRC)/softmmu.ld CFLAGS+=-ggdb -O0 LDFLAGS=-nostdlib -static
The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- v2 - don't remove EXTFLAGS, add comment --- tests/tcg/s390x/Makefile.softmmu-target | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)