| Message ID | 20240904143603.52934-16-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | target/cris: Remove the deprecated CRIS target | expand |
On 04/09/2024 16.36, Philippe Mathieu-Daudé wrote: > As per the deprecation notice in commit c7bbef4023: > > The CRIS architecture was pulled from Linux in 4.17 and > the compiler is no longer packaged in any distro [...]. > > It is now unlikely QEMU is build on CRIS host. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > system/qemu-seccomp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/system/qemu-seccomp.c b/system/qemu-seccomp.c > index 98ffce075c..a14a0c0635 100644 > --- a/system/qemu-seccomp.c > +++ b/system/qemu-seccomp.c > @@ -50,7 +50,7 @@ const struct scmp_arg_cmp sched_setscheduler_arg[] = { > * See 'NOTES' in 'man 2 clone' - s390 & cross have 'flags' in > * different position to other architectures > */ > -#if defined(HOST_S390X) || defined(HOST_S390) || defined(HOST_CRIS) > +#if defined(HOST_S390X) || defined(HOST_S390) > #define CLONE_FLAGS_ARG 1 > #else > #define CLONE_FLAGS_ARG 0 Reviewed-by: Thomas Huth <thuth@redhat.com>
On 9/4/24 16:36, Philippe Mathieu-Daudé wrote: > As per the deprecation notice in commit c7bbef4023: > > The CRIS architecture was pulled from Linux in 4.17 and > the compiler is no longer packaged in any distro [...]. > > It is now unlikely QEMU is build on CRIS host. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Reviewed-by: Thomas Huth <thuth@redhat.com> > --- > system/qemu-seccomp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/system/qemu-seccomp.c b/system/qemu-seccomp.c > index 98ffce075c..a14a0c0635 100644 > --- a/system/qemu-seccomp.c > +++ b/system/qemu-seccomp.c > @@ -50,7 +50,7 @@ const struct scmp_arg_cmp sched_setscheduler_arg[] = { > * See 'NOTES' in 'man 2 clone' - s390 & cross have 'flags' in > * different position to other architectures Small nit, "cross" is a misspelling of "cris" so s/& cross // No need to repost, of course. Paolo > */ > -#if defined(HOST_S390X) || defined(HOST_S390) || defined(HOST_CRIS) > +#if defined(HOST_S390X) || defined(HOST_S390) > #define CLONE_FLAGS_ARG 1 > #else > #define CLONE_FLAGS_ARG 0
On 5/9/24 09:48, Paolo Bonzini wrote: > On 9/4/24 16:36, Philippe Mathieu-Daudé wrote: >> As per the deprecation notice in commit c7bbef4023: >> >> The CRIS architecture was pulled from Linux in 4.17 and >> the compiler is no longer packaged in any distro [...]. >> >> It is now unlikely QEMU is build on CRIS host. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> Reviewed-by: Thomas Huth <thuth@redhat.com> >> --- >> system/qemu-seccomp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/system/qemu-seccomp.c b/system/qemu-seccomp.c >> index 98ffce075c..a14a0c0635 100644 >> --- a/system/qemu-seccomp.c >> +++ b/system/qemu-seccomp.c >> @@ -50,7 +50,7 @@ const struct scmp_arg_cmp sched_setscheduler_arg[] = { >> * See 'NOTES' in 'man 2 clone' - s390 & cross have 'flags' in >> * different position to other architectures > > Small nit, "cross" is a misspelling of "cris" so > > s/& cross // Funny :) > > No need to repost, of course. I'll correct, thanks. > > Paolo
diff --git a/system/qemu-seccomp.c b/system/qemu-seccomp.c index 98ffce075c..a14a0c0635 100644 --- a/system/qemu-seccomp.c +++ b/system/qemu-seccomp.c @@ -50,7 +50,7 @@ const struct scmp_arg_cmp sched_setscheduler_arg[] = { * See 'NOTES' in 'man 2 clone' - s390 & cross have 'flags' in * different position to other architectures */ -#if defined(HOST_S390X) || defined(HOST_S390) || defined(HOST_CRIS) +#if defined(HOST_S390X) || defined(HOST_S390) #define CLONE_FLAGS_ARG 1 #else #define CLONE_FLAGS_ARG 0
As per the deprecation notice in commit c7bbef4023: The CRIS architecture was pulled from Linux in 4.17 and the compiler is no longer packaged in any distro [...]. It is now unlikely QEMU is build on CRIS host. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- system/qemu-seccomp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)