| Message ID | 20240802235617.7971-9-imp@bsdimp.com |
|---|---|
| State | New |
| Headers | show |
| Series | For 9.2: A bunch of cleanups and work towards variable pagesize support | expand |
On 8/3/24 09:56, Warner Losh wrote: > bsd-user has never supported this, and FreeBSD make it easy to set this > on a per-jail basis, so that the normal reporting routines that we pass > through just work. Since this was never used, and never even in the > usage(), retire it to cut down on the clutter. It was literally just a > write-only variable. > > Signed-off-by: Warner Losh<imp@bsdimp.com> > --- > bsd-user/main.c | 3 --- > bsd-user/qemu.h | 1 - > 2 files changed, 4 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/bsd-user/main.c b/bsd-user/main.c index 709ab10ddc1..8c52fb43ff1 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -92,7 +92,6 @@ static const char *cpu_type; unsigned long reserved_va; const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX; -const char *qemu_uname_release; unsigned long target_maxtsiz = TARGET_MAXTSIZ; /* max text size */ unsigned long target_dfldsiz = TARGET_DFLDSIZ; /* initial data size limit */ @@ -390,8 +389,6 @@ int main(int argc, char **argv) interp_prefix = argv[optind++]; } else if (!strcmp(r, "g")) { gdbstub = g_strdup(argv[optind++]); - } else if (!strcmp(r, "r")) { - qemu_uname_release = argv[optind++]; } else if (!strcmp(r, "cpu")) { cpu_model = argv[optind++]; if (is_help_option(cpu_model)) { diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index b97a902a4c2..ed6044cfdaf 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -122,7 +122,6 @@ struct TaskState { void init_task_state(TaskState *ts); void stop_all_tasks(void); extern const char *interp_prefix; -extern const char *qemu_uname_release; /* * TARGET_ARG_MAX defines the number of bytes allocated for arguments
bsd-user has never supported this, and FreeBSD make it easy to set this on a per-jail basis, so that the normal reporting routines that we pass through just work. Since this was never used, and never even in the usage(), retire it to cut down on the clutter. It was literally just a write-only variable. Signed-off-by: Warner Losh <imp@bsdimp.com> --- bsd-user/main.c | 3 --- bsd-user/qemu.h | 1 - 2 files changed, 4 deletions(-)