diff mbox series

[1/1] qemu-options.hx: correct formatting -smbios type=4

Message ID 20240729204816.11905-1-heinrich.schuchardt@canonical.com
State New
Headers show
Series [1/1] qemu-options.hx: correct formatting -smbios type=4 | expand

Commit Message

Heinrich Schuchardt July 29, 2024, 8:48 p.m. UTC 
processor-family and processor-id can be assigned independently.

Add missing brackets.

Fixes: b5831d79671c ("smbios: add processor-family option")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé July 30, 2024, 6:54 a.m. UTC | #1 
On 29/7/24 22:48, Heinrich Schuchardt wrote:
> processor-family and processor-id can be assigned independently.
> 
> Add missing brackets.
> 
> Fixes: b5831d79671c ("smbios: add processor-family option")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>   qemu-options.hx | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thomas Huth Aug. 12, 2024, 7:55 a.m. UTC | #2 
On 29/07/2024 22.48, Heinrich Schuchardt wrote:
> processor-family and processor-id can be assigned independently.
> 
> Add missing brackets.
> 
> Fixes: b5831d79671c ("smbios: add processor-family option")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>   qemu-options.hx | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 369ae81d7c..b0eb41fbcd 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2704,7 +2704,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
>       "                specify SMBIOS type 3 fields\n"
>       "-smbios type=4[,sock_pfx=str][,manufacturer=str][,version=str][,serial=str]\n"
>       "              [,asset=str][,part=str][,max-speed=%d][,current-speed=%d]\n"
> -    "              [,processor-family=%d,processor-id=%d]\n"
> +    "              [,processor-family=%d][,processor-id=%d]\n"
>       "                specify SMBIOS type 4 fields\n"
>       "-smbios type=8[,external_reference=str][,internal_reference=str][,connector_type=%d][,port_type=%d]\n"
>       "                specify SMBIOS type 8 fields\n"

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index 369ae81d7c..b0eb41fbcd 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2704,7 +2704,7 @@  DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
     "                specify SMBIOS type 3 fields\n"
     "-smbios type=4[,sock_pfx=str][,manufacturer=str][,version=str][,serial=str]\n"
     "              [,asset=str][,part=str][,max-speed=%d][,current-speed=%d]\n"
-    "              [,processor-family=%d,processor-id=%d]\n"
+    "              [,processor-family=%d][,processor-id=%d]\n"
     "                specify SMBIOS type 4 fields\n"
     "-smbios type=8[,external_reference=str][,internal_reference=str][,connector_type=%d][,port_type=%d]\n"
     "                specify SMBIOS type 8 fields\n"