| Message ID | 20240722214313.89503-15-imp@bsdimp.com |
|---|---|
| State | New |
| Headers | show |
| Series | bsd-user: Misc changes for 9.1 (I hope) | expand |
Hi Warner, On 22/7/24 23:43, Warner Losh wrote: > Add the aarch64 bsd-user fragments needed to build the new aarch64 code. > > Signed-off-by: Warner Losh <imp@bsdimp.com> > --- > configs/targets/aarch64-bsd-user.mak | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 configs/targets/aarch64-bsd-user.mak Can we build aarch64 on Cirrus-CI? (not clear on https://cirrus-ci.org/guide/FreeBSD/). If so, could you add a follow-up patch to build that on our CI, patching .gitlab-ci.d/cirrus.yml? Regards, Phil.
On Mon, Jul 22, 2024 at 3:54 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > Hi Warner, > > On 22/7/24 23:43, Warner Losh wrote: > > Add the aarch64 bsd-user fragments needed to build the new aarch64 code. > > > > Signed-off-by: Warner Losh <imp@bsdimp.com> > > --- > > configs/targets/aarch64-bsd-user.mak | 3 +++ > > 1 file changed, 3 insertions(+) > > create mode 100644 configs/targets/aarch64-bsd-user.mak > > Can we build aarch64 on Cirrus-CI? (not clear on > https://cirrus-ci.org/guide/FreeBSD/). If so, could you add > a follow-up patch to build that on our CI, patching > .gitlab-ci.d/cirrus.yml? > We can build aarch64 host for bsd-user for sure. I'll see if we can do it in cirrus CI. If so, I'll try to add it to cirrus.yml. This patch series adds aarch64 guest... Warner
On 23/7/24 00:06, Warner Losh wrote: > > > On Mon, Jul 22, 2024 at 3:54 PM Philippe Mathieu-Daudé > <philmd@linaro.org <mailto:philmd@linaro.org>> wrote: > > Hi Warner, > > On 22/7/24 23:43, Warner Losh wrote: > > Add the aarch64 bsd-user fragments needed to build the new > aarch64 code. > > > > Signed-off-by: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>> > > --- > > configs/targets/aarch64-bsd-user.mak | 3 +++ > > 1 file changed, 3 insertions(+) > > create mode 100644 configs/targets/aarch64-bsd-user.mak > > Can we build aarch64 on Cirrus-CI? (not clear on > https://cirrus-ci.org/guide/FreeBSD/ > <https://cirrus-ci.org/guide/FreeBSD/>). If so, could you add > a follow-up patch to build that on our CI, patching > .gitlab-ci.d/cirrus.yml? > > > We can build aarch64 host for bsd-user for sure. I'll see if we can do > it in cirrus CI. > If so, I'll try to add it to cirrus.yml. > > This patch series adds aarch64 guest... Yes, we want to use a aarch64 FreeBSD host to build your FreeBSD aarch64 bsd-user guest and test it. Am I wrong?
On 7/23/24 08:11, Philippe Mathieu-Daudé wrote: > On 23/7/24 00:06, Warner Losh wrote: >> >> >> On Mon, Jul 22, 2024 at 3:54 PM Philippe Mathieu-Daudé <philmd@linaro.org >> <mailto:philmd@linaro.org>> wrote: >> >> Hi Warner, >> >> On 22/7/24 23:43, Warner Losh wrote: >> > Add the aarch64 bsd-user fragments needed to build the new >> aarch64 code. >> > >> > Signed-off-by: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>> >> > --- >> > configs/targets/aarch64-bsd-user.mak | 3 +++ >> > 1 file changed, 3 insertions(+) >> > create mode 100644 configs/targets/aarch64-bsd-user.mak >> >> Can we build aarch64 on Cirrus-CI? (not clear on >> https://cirrus-ci.org/guide/FreeBSD/ >> <https://cirrus-ci.org/guide/FreeBSD/>). If so, could you add >> a follow-up patch to build that on our CI, patching >> .gitlab-ci.d/cirrus.yml? >> >> >> We can build aarch64 host for bsd-user for sure. I'll see if we can do it in cirrus CI. >> If so, I'll try to add it to cirrus.yml. >> >> This patch series adds aarch64 guest... > > Yes, we want to use a aarch64 FreeBSD host to build your FreeBSD > aarch64 bsd-user guest and test it. Am I wrong? > This is adding guest support, so your suggestion is orthogonal. r~
On Mon, Jul 22, 2024 at 7:17 PM Richard Henderson < richard.henderson@linaro.org> wrote: > On 7/23/24 08:11, Philippe Mathieu-Daudé wrote: > > On 23/7/24 00:06, Warner Losh wrote: > >> > >> > >> On Mon, Jul 22, 2024 at 3:54 PM Philippe Mathieu-Daudé < > philmd@linaro.org > >> <mailto:philmd@linaro.org>> wrote: > >> > >> Hi Warner, > >> > >> On 22/7/24 23:43, Warner Losh wrote: > >> > Add the aarch64 bsd-user fragments needed to build the new > >> aarch64 code. > >> > > >> > Signed-off-by: Warner Losh <imp@bsdimp.com <mailto: > imp@bsdimp.com>> > >> > --- > >> > configs/targets/aarch64-bsd-user.mak | 3 +++ > >> > 1 file changed, 3 insertions(+) > >> > create mode 100644 configs/targets/aarch64-bsd-user.mak > >> > >> Can we build aarch64 on Cirrus-CI? (not clear on > >> https://cirrus-ci.org/guide/FreeBSD/ > >> <https://cirrus-ci.org/guide/FreeBSD/>). If so, could you add > >> a follow-up patch to build that on our CI, patching > >> .gitlab-ci.d/cirrus.yml? > >> > >> > >> We can build aarch64 host for bsd-user for sure. I'll see if we can do > it in cirrus CI. > >> If so, I'll try to add it to cirrus.yml. > >> > >> This patch series adds aarch64 guest... > > > > Yes, we want to use a aarch64 FreeBSD host to build your FreeBSD > > aarch64 bsd-user guest and test it. Am I wrong? > > > > This is adding guest support, so your suggestion is orthogonal. > Yea... It's a good suggestion, but not what I'm working on right now... Warner
Oh, also, can I get a reviewed-by? Warner On Mon, Jul 22, 2024 at 11:08 PM Warner Losh <imp@bsdimp.com> wrote: > > > On Mon, Jul 22, 2024 at 7:17 PM Richard Henderson < > richard.henderson@linaro.org> wrote: > >> On 7/23/24 08:11, Philippe Mathieu-Daudé wrote: >> > On 23/7/24 00:06, Warner Losh wrote: >> >> >> >> >> >> On Mon, Jul 22, 2024 at 3:54 PM Philippe Mathieu-Daudé < >> philmd@linaro.org >> >> <mailto:philmd@linaro.org>> wrote: >> >> >> >> Hi Warner, >> >> >> >> On 22/7/24 23:43, Warner Losh wrote: >> >> > Add the aarch64 bsd-user fragments needed to build the new >> >> aarch64 code. >> >> > >> >> > Signed-off-by: Warner Losh <imp@bsdimp.com <mailto: >> imp@bsdimp.com>> >> >> > --- >> >> > configs/targets/aarch64-bsd-user.mak | 3 +++ >> >> > 1 file changed, 3 insertions(+) >> >> > create mode 100644 configs/targets/aarch64-bsd-user.mak >> >> >> >> Can we build aarch64 on Cirrus-CI? (not clear on >> >> https://cirrus-ci.org/guide/FreeBSD/ >> >> <https://cirrus-ci.org/guide/FreeBSD/>). If so, could you add >> >> a follow-up patch to build that on our CI, patching >> >> .gitlab-ci.d/cirrus.yml? >> >> >> >> >> >> We can build aarch64 host for bsd-user for sure. I'll see if we can do >> it in cirrus CI. >> >> If so, I'll try to add it to cirrus.yml. >> >> >> >> This patch series adds aarch64 guest... >> > >> > Yes, we want to use a aarch64 FreeBSD host to build your FreeBSD >> > aarch64 bsd-user guest and test it. Am I wrong? >> > >> >> This is adding guest support, so your suggestion is orthogonal. >> > > Yea... It's a good suggestion, but not what I'm working on right now... > > Warner >
On 7/23/24 07:43, Warner Losh wrote: > Add the aarch64 bsd-user fragments needed to build the new aarch64 code. > > Signed-off-by: Warner Losh<imp@bsdimp.com> > --- > configs/targets/aarch64-bsd-user.mak | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 configs/targets/aarch64-bsd-user.mak Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 23/7/24 03:17, Richard Henderson wrote: > On 7/23/24 08:11, Philippe Mathieu-Daudé wrote: >> On 23/7/24 00:06, Warner Losh wrote: >>> >>> >>> On Mon, Jul 22, 2024 at 3:54 PM Philippe Mathieu-Daudé >>> <philmd@linaro.org <mailto:philmd@linaro.org>> wrote: >>> >>> Hi Warner, >>> >>> On 22/7/24 23:43, Warner Losh wrote: >>> > Add the aarch64 bsd-user fragments needed to build the new >>> aarch64 code. >>> > >>> > Signed-off-by: Warner Losh <imp@bsdimp.com >>> <mailto:imp@bsdimp.com>> >>> > --- >>> > configs/targets/aarch64-bsd-user.mak | 3 +++ >>> > 1 file changed, 3 insertions(+) >>> > create mode 100644 configs/targets/aarch64-bsd-user.mak >>> >>> Can we build aarch64 on Cirrus-CI? (not clear on >>> https://cirrus-ci.org/guide/FreeBSD/ >>> <https://cirrus-ci.org/guide/FreeBSD/>). If so, could you add >>> a follow-up patch to build that on our CI, patching >>> .gitlab-ci.d/cirrus.yml? >>> >>> >>> We can build aarch64 host for bsd-user for sure. I'll see if we can >>> do it in cirrus CI. >>> If so, I'll try to add it to cirrus.yml. >>> >>> This patch series adds aarch64 guest... >> >> Yes, we want to use a aarch64 FreeBSD host to build your FreeBSD >> aarch64 bsd-user guest and test it. Am I wrong? >> > > This is adding guest support, so your suggestion is orthogonal. Ah, got it I guess, this series adds support for aarch64 user-mode emulation on any FreeBSD kernels, so IIUC we can test it on the current FreeBSD x86 job we have. Currently the x64-freebsd-13-build job uses: CONFIGURE_ARGS: --target-list-exclude=arm-softmmu,i386-softmmu,microblaze-softmmu,mips64el-softmmu,mipsel-softmmu,mips-softmmu,ppc-softmmu,sh4eb-softmmu,xtensa-softmmu TEST_TARGETS: check So the aarch64-bsd-user target should be selected automatically, is that correct? (got it, my request to test aarch64 FreeBSD *host* is orthogonal).
On Tue, Jul 23, 2024 at 12:38 AM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > On 23/7/24 03:17, Richard Henderson wrote: > > On 7/23/24 08:11, Philippe Mathieu-Daudé wrote: > >> On 23/7/24 00:06, Warner Losh wrote: > >>> > >>> > >>> On Mon, Jul 22, 2024 at 3:54 PM Philippe Mathieu-Daudé > >>> <philmd@linaro.org <mailto:philmd@linaro.org>> wrote: > >>> > >>> Hi Warner, > >>> > >>> On 22/7/24 23:43, Warner Losh wrote: > >>> > Add the aarch64 bsd-user fragments needed to build the new > >>> aarch64 code. > >>> > > >>> > Signed-off-by: Warner Losh <imp@bsdimp.com > >>> <mailto:imp@bsdimp.com>> > >>> > --- > >>> > configs/targets/aarch64-bsd-user.mak | 3 +++ > >>> > 1 file changed, 3 insertions(+) > >>> > create mode 100644 configs/targets/aarch64-bsd-user.mak > >>> > >>> Can we build aarch64 on Cirrus-CI? (not clear on > >>> https://cirrus-ci.org/guide/FreeBSD/ > >>> <https://cirrus-ci.org/guide/FreeBSD/>). If so, could you add > >>> a follow-up patch to build that on our CI, patching > >>> .gitlab-ci.d/cirrus.yml? > >>> > >>> > >>> We can build aarch64 host for bsd-user for sure. I'll see if we can > >>> do it in cirrus CI. > >>> If so, I'll try to add it to cirrus.yml. > >>> > >>> This patch series adds aarch64 guest... > >> > >> Yes, we want to use a aarch64 FreeBSD host to build your FreeBSD > >> aarch64 bsd-user guest and test it. Am I wrong? > >> > > > > This is adding guest support, so your suggestion is orthogonal. > > Ah, got it I guess, this series adds support for aarch64 user-mode > emulation on any FreeBSD kernels, so IIUC we can test it on the current > FreeBSD x86 job we have. Currently the x64-freebsd-13-build job uses: > > CONFIGURE_ARGS: > > --target-list-exclude=arm-softmmu,i386-softmmu,microblaze-softmmu,mips64el-softmmu,mipsel-softmmu,mips-softmmu,ppc-softmmu,sh4eb-softmmu,xtensa-softmmu > TEST_TARGETS: check > > So the aarch64-bsd-user target should be selected automatically, > is that correct? > Yes. It's automatically added to the build just by this file existing. So it should at least be compile tested by everything. Warner > (got it, my request to test aarch64 FreeBSD *host* is orthogonal). >
diff --git a/configs/targets/aarch64-bsd-user.mak b/configs/targets/aarch64-bsd-user.mak new file mode 100644 index 00000000000..8aaa5d8c802 --- /dev/null +++ b/configs/targets/aarch64-bsd-user.mak @@ -0,0 +1,3 @@ +TARGET_ARCH=aarch64 +TARGET_BASE_ARCH=arm +TARGET_XML_FILES= gdb-xml/aarch64-core.xml gdb-xml/aarch64-fpu.xml gdb-xml/aarch64-pauth.xml
Add the aarch64 bsd-user fragments needed to build the new aarch64 code. Signed-off-by: Warner Losh <imp@bsdimp.com> --- configs/targets/aarch64-bsd-user.mak | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 configs/targets/aarch64-bsd-user.mak