| Message ID | 20240711074829.3338879-1-gaosong@loongson.cn |
|---|---|
| State | New |
| Headers | show |
Hi Richard, On 11/7/24 09:48, Song Gao wrote: > The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf: > > Merge tag 'pull-aspeed-20240709' of https://github.com/legoater/qemu into staging (2024-07-09 07:13:55 -0700) > > are available in the Git repository at: > > https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240711 > > for you to fetch changes up to 78341408e705e1b8dc92eaae2071ae0023d586b0: > > target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-11 15:56:50 +0800) > > ---------------------------------------------------------------- > pull-loongarch-20240711 > > ---------------------------------------------------------------- > Bibo Mao (2): > hw/loongarch/virt: Remove unused assignment > target/loongarch/kvm: Add software breakpoint support > > Dmitry Frolov (1): > hw/loongarch/boot.c: fix out-of-bound reading > > Feiyang Chen (1): > target/loongarch: Remove avail_64 in trans_srai_w() and simplify it > > Jiaxun Yang (1): > MAINTAINERS: Add myself as a reviewer of LoongArch virt machine > > Song Gao (2): > target/loongarch: Set CSR_PRCFG1 and CSR_PRCFG2 values > target/loongarch: Fix cpu_reset set wrong CSR_CRMD > > Xianglai Li (2): > hw/loongarch: Change the tpm support by default > hw/loongarch: Modify flash block size to 256K Please hold on before merging, I'd like to check with the author for migration issue regarding the flash block size change. Thanks, Phil.
在 2024/7/11 下午5:57, Philippe Mathieu-Daudé 写道: > Hi Richard, > > On 11/7/24 09:48, Song Gao wrote: >> The following changes since commit >> 59084feb256c617063e0dbe7e64821ae8852d7cf: >> >> Merge tag 'pull-aspeed-20240709' of >> https://github.com/legoater/qemu into staging (2024-07-09 07:13:55 >> -0700) >> >> are available in the Git repository at: >> >> https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240711 >> >> for you to fetch changes up to 78341408e705e1b8dc92eaae2071ae0023d586b0: >> >> target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-11 >> 15:56:50 +0800) >> >> ---------------------------------------------------------------- >> pull-loongarch-20240711 >> >> ---------------------------------------------------------------- >> Bibo Mao (2): >> hw/loongarch/virt: Remove unused assignment >> target/loongarch/kvm: Add software breakpoint support >> >> Dmitry Frolov (1): >> hw/loongarch/boot.c: fix out-of-bound reading >> >> Feiyang Chen (1): >> target/loongarch: Remove avail_64 in trans_srai_w() and >> simplify it >> >> Jiaxun Yang (1): >> MAINTAINERS: Add myself as a reviewer of LoongArch virt machine >> >> Song Gao (2): >> target/loongarch: Set CSR_PRCFG1 and CSR_PRCFG2 values >> target/loongarch: Fix cpu_reset set wrong CSR_CRMD >> >> Xianglai Li (2): >> hw/loongarch: Change the tpm support by default >> hw/loongarch: Modify flash block size to 256K > > Please hold on before merging, I'd like to check with > the author for migration issue regarding the flash block size > change. > I'll drop this patch on v2, and push it next time. Thanks Song Gao > Thanks, > > Phil.
On 12/7/24 03:35, gaosong wrote: > 在 2024/7/11 下午5:57, Philippe Mathieu-Daudé 写道: >>> Xianglai Li (2): >>> hw/loongarch: Change the tpm support by default >>> hw/loongarch: Modify flash block size to 256K >> >> Please hold on before merging, I'd like to check with >> the author for migration issue regarding the flash block size >> change. >> > I'll drop this patch on v2, and push it next time. Thanks!
Hi Philippe: > Hi Richard, > > On 11/7/24 09:48, Song Gao wrote: >> The following changes since commit >> 59084feb256c617063e0dbe7e64821ae8852d7cf: >> >> Merge tag 'pull-aspeed-20240709' of >> https://github.com/legoater/qemu into staging (2024-07-09 07:13:55 >> -0700) >> >> are available in the Git repository at: >> >> https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240711 >> >> for you to fetch changes up to 78341408e705e1b8dc92eaae2071ae0023d586b0: >> >> target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-11 >> 15:56:50 +0800) >> >> ---------------------------------------------------------------- >> pull-loongarch-20240711 >> >> ---------------------------------------------------------------- >> Bibo Mao (2): >> hw/loongarch/virt: Remove unused assignment >> target/loongarch/kvm: Add software breakpoint support >> >> Dmitry Frolov (1): >> hw/loongarch/boot.c: fix out-of-bound reading >> >> Feiyang Chen (1): >> target/loongarch: Remove avail_64 in trans_srai_w() and >> simplify it >> >> Jiaxun Yang (1): >> MAINTAINERS: Add myself as a reviewer of LoongArch virt machine >> >> Song Gao (2): >> target/loongarch: Set CSR_PRCFG1 and CSR_PRCFG2 values >> target/loongarch: Fix cpu_reset set wrong CSR_CRMD >> >> Xianglai Li (2): >> hw/loongarch: Change the tpm support by default >> hw/loongarch: Modify flash block size to 256K > > Please hold on before merging, I'd like to check with > the author for migration issue regarding the flash block size > change. > I performed a live migration test on the local environment. The test steps are as follows: 1.Create A network file system between PC A and PC B. 2.Replace the qemu binary of PC B with the version with the modified flash block size. 2.The network file system enables PC A and PC B to access the same test qcow2 file. 3.Create a VM on PC A using the test qcow2 file. 4.Add a boot item stored in the flash. Use the BIOS GUI to save the boot item, shut down the VM, restart the VM, and check whether the boot item exists 5.The migration function of virt-manager is used to migrate VMS from PC A to PC B. After the migration is successful, stop the VM, restart the VM, and check whether the boot option exists and the VM can be started normally with the boot option. 6.Perform the same test as Step 5 to migrate the VM from PC B to PC A After the test, data in the flash of the VM is not lost, and the VM can start normally. Therefore, I believe that the current patch does not affect the migration function. Thanks, Xianglai. > Thanks, > > Phil.
在 2024/7/12 下午5:50, lixianglai 写道: > Hi Philippe: >> Hi Richard, >> >> On 11/7/24 09:48, Song Gao wrote: >>> The following changes since commit >>> 59084feb256c617063e0dbe7e64821ae8852d7cf: >>> >>> Merge tag 'pull-aspeed-20240709' of >>> https://github.com/legoater/qemu into staging (2024-07-09 07:13:55 >>> -0700) >>> >>> are available in the Git repository at: >>> >>> https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240711 >>> >>> for you to fetch changes up to >>> 78341408e705e1b8dc92eaae2071ae0023d586b0: >>> >>> target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-11 >>> 15:56:50 +0800) >>> >>> ---------------------------------------------------------------- >>> pull-loongarch-20240711 >>> >>> ---------------------------------------------------------------- >>> Bibo Mao (2): >>> hw/loongarch/virt: Remove unused assignment >>> target/loongarch/kvm: Add software breakpoint support >>> >>> Dmitry Frolov (1): >>> hw/loongarch/boot.c: fix out-of-bound reading >>> >>> Feiyang Chen (1): >>> target/loongarch: Remove avail_64 in trans_srai_w() and >>> simplify it >>> >>> Jiaxun Yang (1): >>> MAINTAINERS: Add myself as a reviewer of LoongArch virt machine >>> >>> Song Gao (2): >>> target/loongarch: Set CSR_PRCFG1 and CSR_PRCFG2 values >>> target/loongarch: Fix cpu_reset set wrong CSR_CRMD >>> >>> Xianglai Li (2): >>> hw/loongarch: Change the tpm support by default >>> hw/loongarch: Modify flash block size to 256K >> >> Please hold on before merging, I'd like to check with >> the author for migration issue regarding the flash block size >> change. >> > I performed a live migration test on the local environment. The test > steps are as follows: > > 1.Create A network file system between PC A and PC B. > 2.Replace the qemu binary of PC B with the version with the modified > flash block size. > 2.The network file system enables PC A and PC B to access the same > test qcow2 file. > 3.Create a VM on PC A using the test qcow2 file. > 4.Add a boot item stored in the flash. Use the BIOS GUI to save the > boot item, shut down the VM, > restart the VM, and check whether the boot item exists > 5.The migration function of virt-manager is used to migrate VMS from > PC A to PC B. > After the migration is successful, stop the VM, restart the VM, > and check whether the boot option exists and the VM can be started > normally with the boot option. > 6.Perform the same test as Step 5 to migrate the VM from PC B to PC A > > After the test, data in the flash of the VM is not lost, and the VM > can start normally. > Therefore, I believe that the current patch does not affect the > migration function. > > Thanks, > Xianglai. > Hi Philippe: Can we push this patch this time? Thanks. Song Gao >> Thanks, >> >> Phil.
The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf: Merge tag 'pull-aspeed-20240709' of https://github.com/legoater/qemu into staging (2024-07-09 07:13:55 -0700) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240711 for you to fetch changes up to 78341408e705e1b8dc92eaae2071ae0023d586b0: target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-11 15:56:50 +0800) ---------------------------------------------------------------- pull-loongarch-20240711 ---------------------------------------------------------------- Bibo Mao (2): hw/loongarch/virt: Remove unused assignment target/loongarch/kvm: Add software breakpoint support Dmitry Frolov (1): hw/loongarch/boot.c: fix out-of-bound reading Feiyang Chen (1): target/loongarch: Remove avail_64 in trans_srai_w() and simplify it Jiaxun Yang (1): MAINTAINERS: Add myself as a reviewer of LoongArch virt machine Song Gao (2): target/loongarch: Set CSR_PRCFG1 and CSR_PRCFG2 values target/loongarch: Fix cpu_reset set wrong CSR_CRMD Xianglai Li (2): hw/loongarch: Change the tpm support by default hw/loongarch: Modify flash block size to 256K MAINTAINERS | 1 + configs/targets/loongarch64-softmmu.mak | 1 + hw/loongarch/Kconfig | 1 + hw/loongarch/acpi-build.c | 3 + hw/loongarch/boot.c | 2 +- hw/loongarch/virt.c | 15 +++-- include/hw/loongarch/virt.h | 2 +- target/loongarch/cpu.c | 23 ++++--- target/loongarch/kvm/kvm.c | 76 +++++++++++++++++++++++ target/loongarch/tcg/insn_trans/trans_shift.c.inc | 15 +---- 10 files changed, 109 insertions(+), 30 deletions(-)