From patchwork Tue Jul 9 14:26:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1958471 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=a9u0oSy5; dkim=pass (2048-bit key; unprotected) header.d=Eviden.com header.i=@Eviden.com header.a=rsa-sha256 header.s=selector1 header.b=fGOU/6jB; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WJNcM0RmTz1xrJ for ; Wed, 10 Jul 2024 00:27:31 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRBnb-0006rE-Vb; Tue, 09 Jul 2024 10:26:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBnX-0006XQ-5Z for qemu-devel@nongnu.org; Tue, 09 Jul 2024 10:26:27 -0400 Received: from smarthost3.eviden.com ([80.78.11.84]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBnV-0002k2-8S for qemu-devel@nongnu.org; Tue, 09 Jul 2024 10:26:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1720535185; x=1752071185; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LD3dfZ2F2UETlVfIWevvE8qQfgdkNOQiC0RyOj3j5uU=; b=a9u0oSy5tNgoSys0WjyhjN8mmNJrgqDmFQ/dtvZCUWmhXqx7clpGYYql DAhP7hxqzeVA+ZpMfbVABPJn5EV2Lc7VNzx2riBNby0oLaeYkHJrKV4oX 77K0u/bnmndzJUYfXA5H1eMWcsKboCmrvLDto4eVmh4edm45EqChBVVqO FSwo0ijteaF26+kBAF9cmW2u6vPp4w5xaPUZX7TI+Bd3hPdttQqX1Iv1V uG9QsoV+L1zW9fl3/+AmBQg/4BsSq3KgO79x4iCm43b6tHsvwCNlaeqR4 EX/oWy541HuORjV0pnb8XgD9QDUjTJI403nswVpb9AF2cAWe6QWxr56Ri w==; X-IronPort-AV: E=Sophos;i="6.09,195,1716242400"; d="scan'208";a="16172663" X-MGA-submission: MDFFOgHd5UU7r4auyfq9wTqTwmWeLSiBUlIiOugfvvWfrH9OxUDes7NVdgna3sbaWdxj+SApKoQrtbFnC9GCjERs4kZrzfeoRna3b6lKi5oovmguMHTxKF4NnH6LtbjN0Pef0rHIw+vRa37NzYR09N72hn0Q9gCy5vOdYAFrQkWWWA== Received: from mail-db5eur02lp2105.outbound.protection.outlook.com (HELO EUR02-DB5-obe.outbound.protection.outlook.com) ([104.47.11.105]) by smarthost3.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2024 16:26:14 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hh4Bi1jwggkafryvK8KPsN5hJAYShNoRNmRlPQxh17dD9uXlzBlNf5yqTl5Ee2Gn44qUBC24Z94o8aDjbNqjf49es8yRw+mMX0DeWbSgKwftwRCIbLst+j8dEcCH+Ako8GSlnVmKqDIovmW7YKOLWCXCGcJRQf4Mvm55AFJsSUQ8Ta+ZOzzx3yeOzn8qNAhNioS27vWiMsi8OMNjKq0+gMa9KbzEa0XwA6O+TIbWbns9ija10sZKp/ksFp1yfAlK8X+KqSKH0i154PR3i0neflwLcPmObSYzwtmwqMON7/0Cf6PLksUih/nTym5gl+x9LjI7w2pS+ECAZqR/ESr5CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LD3dfZ2F2UETlVfIWevvE8qQfgdkNOQiC0RyOj3j5uU=; b=bI2sTeImUy7Xzio04tbWVwZMF2Hma4w88coMfowOBWKx92PFH64EMu2gWPneD9z3P5rUBAarRBEFA90CF3csEF26f+SmJTtpkCLXk3Tw1x+GEtoLKKWHq+iVMAEh17tx3LahhpvQrZ+tOXBFCkejKYqfG6F+WteC5O7zL9RtIfTflgnK/9Zh7GHUR4KUXLzX2+L1DIopWb+pHs3E/ZDETsoBeuL4p8Dtz1+F1oS5FRRE/phm7KuYx5PqxjkvhWROtDDoXyObvSkkYpOa6AKQWA+s34rYiHZdeAE2KnKIPhJuNtktbl0eKCClBBLuBSkAIKqceWXlk6HtTvAXJhQMYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LD3dfZ2F2UETlVfIWevvE8qQfgdkNOQiC0RyOj3j5uU=; b=fGOU/6jBPQndhNLmA4y/DB/O2D4PP1tOPPp1mw6KA7zsRQWsYsCJX6L5a8QAZ14P+wbTSkQQEWkwD0/WEPb9H1KbuemPy3kAwjjB0P0UTjZnAvjILeo77o9RkgSoMMGUEbQ3Afutv5TMEGKV+bu6L8utWSPV0RIvpK5wDHdYc1LzDiYre5aJMFzvlY2dUgKvwmxKzoQp2YPsL2VXa6q6FFFklDOM8UoqY+Cfi/QFldFJ419nmpFswg3JZLI1XHC1URNVVC8JqZINycLbtaiRjOg4OLxrsjDvPWqcR/M7KKn+AfzjjLwQ9+5PV17/WaSKKkDbIM2u9KH7alRxPeOiiQ== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by AS4PR07MB8459.eurprd07.prod.outlook.com (2603:10a6:20b:4e6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.19; Tue, 9 Jul 2024 14:26:10 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7762.016; Tue, 9 Jul 2024 14:26:10 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , CLEMENT MATHIEU--DRIF , Minwoo Im Subject: [PATCH v7 3/4] intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo Thread-Topic: [PATCH v7 3/4] intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo Thread-Index: AQHa0gvxim5DZG7IQkeXyOKD2lbMJg== Date: Tue, 9 Jul 2024 14:26:10 +0000 Message-ID: <20240709142557.317271-4-clement.mathieu--drif@eviden.com> References: <20240709142557.317271-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240709142557.317271-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|AS4PR07MB8459:EE_ x-ms-office365-filtering-correlation-id: ccab5a72-331e-4ac3-acd2-08dca023140f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?uWE5xidxBtzYC6ARh2gYuQQRDHxcAyb?= =?utf-8?q?x+eQ1RPx7P80jgf7NylIVGlJtGJgVSyQ1d8NGaD4BNZp1zNs9FrdZ3EESuorjVWsF?= =?utf-8?q?x1eyfTIcT8xNutF2XE5cf9i7cwlBfSGqnxKUFE83NU+M7Dp9QXT/qNKVrh/bGbHMO?= =?utf-8?q?qBnT5ZcULY/hLRRdNR0PY3MM82lrbODbu+iG5FibbUx0tHT9+PRm8XXTK8DgBd32D?= =?utf-8?q?zX1Hz4qXjTiHrzCACSfa/VZqQMm16PwlKnr4V5mbQR+E73kknNXhKhIRUs0LXV3AM?= =?utf-8?q?5sSRKVBAAfX1t3YqwYIEjD3BNleydtoAJ1tpnEXwAUzKzeYCIvY/KeNGq2vnPNHxv?= =?utf-8?q?m1T0O7rNIuRacRo4Q/1vwbBc1aj3B69aEqZIXWS2pdqhGh4ucVIUcxiI5G1xOeE3t?= =?utf-8?q?K9GHVAYvT547x0npGAGwmDVvmpTJYMydIbRPeWBRW5Zb1xCR+Iqpn0BxJAexU+BzP?= =?utf-8?q?6P2PiFmNEggKPYijtg3QuksVWUwjNIXyje/wgDaNKqlOB4pmoZgTUNufU8XnE54kk?= =?utf-8?q?B4HLR8sc0QgGmu+UM+9ZLFHtEWqtTGgA/dHv/lj9LTf1hNu4Q1h6RM8SJ5VpZT6gx?= =?utf-8?q?ArxG/bFqNl5G6Fewz1KbkKNTEq7suqvpU/gma2V336nH3cY1OBpTQtgT8zkcFXQ45?= =?utf-8?q?wK6OsDLhxiBGqo45mLuVpCC2a55YIa6eq5M+OA1ayxT4L3NvV40rXzce2YSqjYbRb?= =?utf-8?q?rde+AQQzLaRqqaSPZnOMUnm4sIV2pA4p/lRzhfcQiquYGI74HD0iRKU3e7duyS2+P?= =?utf-8?q?J+BsesWRxMcqZNZoTTpGzABRaHa+VQT7JK7WtUII9IDqpVKAco9CFCtofyaf3eEBB?= =?utf-8?q?mktw5BnfAZtEq8yTky/nIiP2eXtIB0shypqE4Qga1kSHph33W9S+xW91BdP9k2cJ0?= =?utf-8?q?E7JvMmtxBIfifvaYIw0w20j0sDXPX4HC/8puFPB2ZpIzE9Ny/+n/P18CFncGPEWUO?= =?utf-8?q?K3P1hBT1fY/+0UrD5jfXy8i87Ypbsd+MnkOu70HPGRRvAbAVhsS+X+1E5Gk+b8S+s?= =?utf-8?q?gmLQfhXxeeRl0ynU6y2ZugLxLjxi9d88xgd5PvVWE+EJvOzQtwCuzAjxfE/GtJ32B?= =?utf-8?q?MlCV5s5m6VbTESTfru5ZNo7HnDLOJWHaQNljqmyYHv6pKPBtYYw+ROjXTyil4d0VD?= =?utf-8?q?kAMu/5vN3641Ed1xsGrNyu5L8xcULp80z89xxP7wDI3N9kF6LuTVtdeB3Jp3kOrrJ?= =?utf-8?q?CFJN/vx2ITGCYC/2ktrnNkjSLa9QIcD8xYyKcN1tOqoBhPCsGkjtrnLlJFZ2yo61l?= =?utf-8?q?eeaqYwnjmt3ImgjrBA5PLnom9rI/FobWF2iyi4YI1fVlUSkYpura6UmMI3zc07KU7?= =?utf-8?q?fwGcG5qrY7cq8Kj7i15CpqVY48PaBZdpmw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?uG8DyHZLhEZI0xmGBaizH3wcThw7?= =?utf-8?q?vOMxhrPHagIhL7As4vRAzCOPJyXaMrU1WSzOAKpLjDClvNsHwHCUUBwaFOHCkoRTD?= =?utf-8?q?mnCmjCX88CnXmiTJmOYpC5OIIr7sCEf5E5DZEBgAcLjkCI2HD0hMBPaJkv/0/u9n3?= =?utf-8?q?cwsrulZFEjG7nF9QXRhX8csCUW0NNkdrnWZnbz6lDiV5EtMdYGLMgdVi6k74YLfZ3?= =?utf-8?q?vylPZIysU+TFY2WUHtwnLagGiBspuZRZObq8PiCUqfDDh1qzmzZEnCFJWOc9wcmwz?= =?utf-8?q?FbT0H6hHEsi79dE+7wWeTtCYrA71HLbw6f//ClQ4cdDTRiqeUQtAqmyst/zpd+UoU?= =?utf-8?q?RHW+LrE76wb2UzjuMDix/YZtMaUSxhPvnMm+4qDa5QHzFZ0rfw0WNYzoRmYrYBjtP?= =?utf-8?q?ws57Gg9z28MjSxlI1MDwYRx7GMbEljlRbnjrbH1emFJ4jtdJKO3qqNSRuA08KnOJq?= =?utf-8?q?VAUXwu6WUO/BAKtXAwZvP2o33ln3YXRdnmJ4ttzQMgUGcOpJvFuNgtF1pC74WXlDs?= =?utf-8?q?fbicCJZ4c6y8Y1X4GIJzAyKYxqpC41NfB1zx/6tnYFRI2zHEu6lzHSuoNboCH/rGd?= =?utf-8?q?wn5NYU1rxq7LExv5xkHMoszW6WHbHzh+Us/ue7OEB4tuCAAJXIMhLxzJ+ogXQyBI0?= =?utf-8?q?F95a6isIzSvzREXcIEj3exE4gYanogQaG/ZDjs6PRTVEqP+90BjTXP1vyU9O86Q13?= =?utf-8?q?RLxThScM05xepTe/DIKRU3V6zkRVcSmnUAiGefzry3nJYdKjxVOWpchFqg+Sp9qqs?= =?utf-8?q?W4ziH8aJstfB3gr8RR5NPwtQIPWgJ0ij9BKT2GTrP1ZVulgowZ7aqSqJG0DYj5yU+?= =?utf-8?q?UWLSomvRT8aowWKCd6IRoHKrmSyI6no1Zm9SfcxkxaW1HNrmloBy6pSVoK/VZEFfw?= =?utf-8?q?yPs1Drb6ICc1nHP2KZ8dfHB4kZBG9B8IUTp2sl2/4JaXftr+mXcK0DXtvq80mPHXl?= =?utf-8?q?7rHLlteQjwBIlNVlYHL+xUketP5ONz+7UvY6nXARyWNffAbnxvOWQB+FOhzIj3RlR?= =?utf-8?q?HtJGoG0jLVwMUMqwpEtFCi+2PYUK7PeZ5riCJQ7VOVMEbBhM9xOZP1guO2ausyKjf?= =?utf-8?q?DHW/Ym6Domlu/JDuiHa3nsqONp0Hjdfc6SfT8vfgfgvWmZ9PjDpRQCWGmTs0YRq2J?= =?utf-8?q?u6m0SPZztWIocL5p0LnKscFPwIVRLxHghl0OdhNCMUVFkZPFZzNJOVC/4AS4Jtyr3?= =?utf-8?q?yvg1IpP/ulTjAnpvM4wD7MvnSbX4iNLVU6qQVfvcL/3HvHIr272Kp5tLTUWNoohx8?= =?utf-8?q?7MYMcNT4EaPKgFYzs5UXi6JEs0fx0I9b2jQM5mFyidibYSFlcf4BrGCvupb+3YEhf?= =?utf-8?q?MkZEkwrAoSFtEdevUf60kVfXhyLkslEjCJRlYvO9PZwJzLtjCBuy9wlPET82qi3Bl?= =?utf-8?q?miO1cd1WWqS5VN5LwdV+qCJAamGbRCduvM7Jjuhc92hUhwVvmLYKgi+lMTIS7CSGt?= =?utf-8?q?81vhdjjKT+bA3OM6CixAQJaMo1o9jrCURQbwWqYY/DERzra8XFNKVGrc8Hy5zNvCW?= =?utf-8?q?291UxeE7lVw2ypaG0fE3iAUKDrxgzHJcTOiqc50wOYex9/2jMEI4XmU=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccab5a72-331e-4ac3-acd2-08dca023140f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2024 14:26:10.0313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VyKgq2WgTx/PqY0PGel1kDoOJ9z2/KWYIDQj+pgFiuxY8bJKIr+uI8cWk9y6ZhE6s5OGEk7VSzOZbC0za0YPtxoBD13dIAZAIg7f8HF4fJspcLBJi7uh3n3h5c3V08IY X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR07MB8459 Received-SPF: pass client-ip=80.78.11.84; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost3.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Clément Mathieu--Drif Per the below code, it can overflow as am can be larger than 8 according to the CH 6.5.2.3 IOTLB Invalidate. Use uint64_t to avoid overflows. Fixes: b5a280c00840 ("intel-iommu: add IOTLB using hash table") Signed-off-by: Clément Mathieu--Drif Reviewed-by: Minwoo Im Reviewed-by: Yi Liu --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index faea23e8d6..5f32c36943 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -436,7 +436,7 @@ struct VTDIOTLBPageInvInfo { uint16_t domain_id; uint32_t pasid; uint64_t addr; - uint8_t mask; + uint64_t mask; }; typedef struct VTDIOTLBPageInvInfo VTDIOTLBPageInvInfo;