From patchwork Tue Jul 9 14:26:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1958472 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=N/EcZmLn; dkim=pass (2048-bit key; unprotected) header.d=Eviden.com header.i=@Eviden.com header.a=rsa-sha256 header.s=selector1 header.b=nF6hQMx4; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WJNcN4rWTz1ySg for ; Wed, 10 Jul 2024 00:27:32 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRBnX-0006YT-Fv; Tue, 09 Jul 2024 10:26:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBnU-0006Oc-TA for qemu-devel@nongnu.org; Tue, 09 Jul 2024 10:26:24 -0400 Received: from smarthost3.eviden.com ([80.78.11.84]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBnK-0002k2-Sa for qemu-devel@nongnu.org; Tue, 09 Jul 2024 10:26:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1720535174; x=1752071174; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=u/EE/MVYvmwVs8wPu6Il6DxMESvsWjmJtHWqiv7M++c=; b=N/EcZmLnBcOw9yih7fFjMi/rR+JKAtIvQ/Orqzy6vmrKe0mPMrI3ieFQ iwGUJS1D7s2hfGpwYRp1KVv9/xH6naz6JSF8tSMOipijQ3EQJ1Ta8dNOb RB5urfsdv/dTRhdWMz9JWIA0FoVGLBIDpmcZzEca3zgskYvAGJWdX1kN3 CWJKmdpTyviUY8w/AaD4s5XTaM7r/4psJ5rGY/0duaMGJHAp2+l5+2afr uZ5HcgFvzYfT/D0+QK/p89HmQavFHzC+5jZc/nkfGgwiQr7IKtv/10Wxp n+0yNwkWxfOiq21+50NCz/vvrn4aD6f89/6PbabwR9Ku3enHzKLBdzLha A==; X-IronPort-AV: E=Sophos;i="6.09,195,1716242400"; d="scan'208";a="16172660" X-MGA-submission: MDHt0OLFiCuR5mDp0hqv4unM60BKCx6Zkpx3ujwDxYt4jv7MdtL3iqfM40u65+U6S5znVKG8A0QjNIz7moXoQGLlqEwXS0fo6ZMu172eXveKUkG6/GBIbaBWCIDjwRZfPhiFBBTzkf/8EGRsi2ZvjhGtguA202oPCAFdPgD0dZHNRg== Received: from mail-db5eur02lp2105.outbound.protection.outlook.com (HELO EUR02-DB5-obe.outbound.protection.outlook.com) ([104.47.11.105]) by smarthost3.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2024 16:26:10 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=unJKgZlBnJStIE9vUAkIBR+S10KOjg4bC3CYdX9JbaRj9RPYy39NUFa7stdL9j9OrILV2mgJ5Maon9cavmbrTUa0NGB37BJMf9VAWBXYUM/Pb9oEo7jKg9ahq3+S2J8w1PiQ77vjgoeeAVINSlGOwmHXCFCGVThL0L1geb+oUJgtKBlVkeNyISAitV6hExHEiLW6rcx1rMgJHAx1WNNQrDKiX26iZr4SVBvWicOxc5sdt5/GLAVMmRBUfZ9KyPvrIh0CijSfKbdkYseomSEPTR5p9TjLOUliUjdJTw/z6RzOsdozolMDGlws3icT+Gz+LFXQ5WMt2J35dV0KXuv53Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/EE/MVYvmwVs8wPu6Il6DxMESvsWjmJtHWqiv7M++c=; b=ILNEjZaTFB4/QtXmSZUP4sudjbF4VW+3zWSbP4yibaxYW2hRLCcEuaAfdUGjHANlEd09kvSgiWNdS3t1GuFdPx5IorVLCpcaYS49AzC+MlIsbU86sUYO4PyWFjC/uUBu8xu1kw1Dxrym/jqukckOPjICKYYR8GCUGEwdpYc7WaG1Zmv8CmqbWlREMyc4JOxtLwW/y8HlNLjVx7pm+4EJvpnE8H0RhAsI7jLszh2Ubhy3KLp4t4Eg1AUGJ7Ob04VcolAV996xb/FDKR5c2k6fwPIOpTkIV9GBSWWo8ABukNgblaU8ytYuMPDQBxuP+QhPPFfKEGPo8OfQxoXADSVDPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/EE/MVYvmwVs8wPu6Il6DxMESvsWjmJtHWqiv7M++c=; b=nF6hQMx4rNXBVc35IfJ/GCtEOKH052nF1Aaoblf6r3UdZ/h4aq5NrESb4K42EjU+Mw8COiqjIOp3Opt50QN8wK2iOkR8fDcODhcphlbw4vDWyw2y3scoJs+dHxPeOf5a/PtzfQ5AuLZSpHY/tfnEAw3zfhEl7K1eW2gyOgxGFE/7tl+znOxHFq/nsQ9quEXmtqpRXYogTTJzqId95wv6NdAiW3lFc7rcFlrpkryhswic49rccjY+Fdiet7wa7GC75i7mBLfWY/jxgkOMOIJ3qIkY6yl37HZHS0hDfDsmiiUyvmdXr3VV5kBYwGnmVKJBb0nTCDI2AygFEJLoqvvxCA== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by AS4PR07MB8459.eurprd07.prod.outlook.com (2603:10a6:20b:4e6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.19; Tue, 9 Jul 2024 14:26:08 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7762.016; Tue, 9 Jul 2024 14:26:08 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , CLEMENT MATHIEU--DRIF , Minwoo Im Subject: [PATCH v7 1/4] intel_iommu: fix FRCD construction macro Thread-Topic: [PATCH v7 1/4] intel_iommu: fix FRCD construction macro Thread-Index: AQHa0gvwQEBSmTxjMESb+vD3l1do3A== Date: Tue, 9 Jul 2024 14:26:08 +0000 Message-ID: <20240709142557.317271-2-clement.mathieu--drif@eviden.com> References: <20240709142557.317271-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240709142557.317271-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|AS4PR07MB8459:EE_ x-ms-office365-filtering-correlation-id: 1ca57ec1-763c-44bb-e619-08dca023133d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?VMfse9n3QggJ2H/RpS8ImKblOdsG7o9?= =?utf-8?q?Si/fKJt36RQzcfz9f+eKUOnV7E8VK+XUksYsrZVxU2Zzbqu4Nho9R4tWllGf/rqtV?= =?utf-8?q?Ze1TLTq+OgspC4u/XOw6uv5CKeArxVyQhTKv5QIC7FtD4oVYqeCJsXZb0cLwc6xx5?= =?utf-8?q?JvhYG347ATNaGtlSmmXQwel51WqcJ5HH0G1A7/zNkLYY83jfxkENC5+sXi80b28Pw?= =?utf-8?q?s4n6Zl5v/HrouGnl5lh10F4FidPRIq/tHt/Llce2C8+GRMLbom90KivoTMnhLDXLP?= =?utf-8?q?ENHsKFLQFLdzAFKmeip8NDgISj0cnY7j9zHCuamYWpn59CA6TLQAe7lv3Q6WZJx3V?= =?utf-8?q?+9My9v/lcY9X1QS+GFEFrxWfk2VivVJS/dtpfXxGnluVrKXyfA2o4kTfvxx5bCjCZ?= =?utf-8?q?JNMjBJMuCQvhbHP/OzcmjqIIeSKlA+vYg5E923h8jqEJfFdIYnIkQNnVtRbIQfDpg?= =?utf-8?q?rTfWZ+H+dclUPbEIPLHwiDF7wxX5Ep2FPX5sh6BL1Gzy/q0PRD7puwIAGT/woz978?= =?utf-8?q?l/x9NXlRU4s0cwkaZZQ1iWuWSCQQVcQBw/bYWASkZlz3xUCTTPT1JukV+sBkDgpVn?= =?utf-8?q?5Vn56nhTuH399n490cgKDDAjKMfj+GTBqsA3Utq/CEl70wMH7yPvXYd8Qx1aOZeMM?= =?utf-8?q?bt6IrDyDMHeMWYtZuJEqzhvgn4OBHuwKa6oicneyFM4eTExPKsCyyO0LqzBg4VhuD?= =?utf-8?q?JEgLYtaETBrLoUcfB8SsmDgA20vz0DkIG/v3n7jEVSwYuIYEEfZSZh1jhVLPV19ld?= =?utf-8?q?1G+hGe9a9iANWq4McIAaoba7YqXElc5X8cN7xGMQLh9tmmhosqbSl45aSVChLkZI1?= =?utf-8?q?HAYkfPWnaN/wP93/r6Tv7G9RnJHm9AhKftUbxnkXkcopqNV4XUlZc/pD5cA3KBQjU?= =?utf-8?q?f71bXJRTPGJcOorSjdCBsEsTmJS3m3lXyqtVmqHMu2taajuYXVDE7A6kLt3k6Z2n2?= =?utf-8?q?lrXK72AOkkKYf+sBClXQxCs/B7Fsh6vlsgH4ZRvPDm+JF4Ye342txvft2i80pA9ku?= =?utf-8?q?CYvxgFEaRBqs9XoHjj9Z9hPq1cjfw5VFyLvA0sSjiXdP3In5ZdKfG+Ci4YbHWo/3o?= =?utf-8?q?UgtZf3Im9ICFo+apRMUKk6mVcxAmaQCkWDeBMbr1/6648vLdvE/zJKj2OibsZZkm0?= =?utf-8?q?imx6m4C6+b08BpuL2yLd+p88Gu7BBWk1SiM4MZu1BnWzUWFNg/A0IKaCa2H/Ou1XD?= =?utf-8?q?sa33s0bwrdMuYf6G74O2JA2dLkuQ/t/LggtwcZlOvflZhB914yy8hOStjxfwuRK5w?= =?utf-8?q?PJc2L9HeidwljaugIttFVmS5uKJ6ORFm4An6ptrDM139yjkaTvfxPYpxizBqo3AIO?= =?utf-8?q?brMHWUNBYdCBEpkUujCWvkaOGj4O1ddfLQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?d2COXBGjbeysIIOEq8UejgBvAXBm?= =?utf-8?q?xDETgbYrmrVHqEHm70F+dw8T+LkkfsEfhvUWoRgiB5TwlsVWa5cDIIJYC2oL9RPBr?= =?utf-8?q?nXKslx+jlvFGB6Fa0d+63VZ35pzFnX8VFbzn4cOz0iMp1L7BJJCQoSjkB7iDQy0G1?= =?utf-8?q?iwI6Jw7OQLCwFhcre6dXCLAsGNWOuh4r5h4oPN1oraA+olXOsTQe/8S+hMZrjtl2L?= =?utf-8?q?epKaKo8BTqlj5VyH9bP59XLtQRRXIOH6rL5W0A1+f/IF2+LHgc8cD2sOCGhzmv0BT?= =?utf-8?q?8+USvSxKFNq3Q49GhOSDNolGNdaRq0HQZnUoJAuwAy2G60tBJt0AxoWf4eGbeE1ii?= =?utf-8?q?PYMm5bTQiExE26eizEGuqmelb092lCkmeHOPl17pEI1ezujO/mh7kN/6SyzNclP6c?= =?utf-8?q?0yXB+e4AgjgQJ1cFlR2sChXmK3bY8hntyZu0pAZz8CS9GbP/4FuH3NnvseMxW9uUa?= =?utf-8?q?BnUxxMoc2sbJx+r049xsyo9SUm3bxkg2uXpuioLjvNdVpYzvzXZqrwcOR913q24Kx?= =?utf-8?q?otBHprtzpIIbdGx4gkWw3SxPhQ0d07/WoDWMuCu82X24VfWWHPWpbmwcNaMtrAqo+?= =?utf-8?q?JconkQkIyuLr4uDferzJ6K76XPJI44VdUfy77gFwHOUz9a0cHv69OIAG9fNq1aWIy?= =?utf-8?q?KVDkqtVAbNMjeF2mNIyZ0dWrA8zB/y5C8aFyLwv+zOBgTs5gYi+O9qC72Crq5skSk?= =?utf-8?q?mH5mbbsteXnj7E6lD6pxzpDjxlzcMpndhU/o8xi+oxZYm2dM98HlVoVw0r6ynS1fH?= =?utf-8?q?o/aDO95aDCUq+T2lhois7xlI18eKrqyZGEaJdWoUQK9Dc3EQ04IPKYKMCha+o4n66?= =?utf-8?q?ZkfXhR5i1IIRScGiR43tGv/2YMqrzbzVMQeAs5Wd9cJKIid92kCu6Xa5kPrQACp7U?= =?utf-8?q?QjX0kcPIhUuqqhir/616oBy5F9KPVkNfNF0ORXBfbuLyVDa7/rqHvucGj0hQ5Sa8i?= =?utf-8?q?HoBa3/dNZcpLcxFvmqRg/EBjzKfFPgQb2XKAyskDnJb1Rbe3US+t1uH7d7AbRNN9x?= =?utf-8?q?1RwNUyblhejJhw1WJbMxthzzlV4UB24GoMbr0FdLU2ep3Iv5BlLPRYdhNAeT2HP3a?= =?utf-8?q?hjYwo2hWlqA+f2VBBpV8dMeETVxPcddfui8A5cVvQGIyO/ZPcrm0T7TZwwSeKkgxt?= =?utf-8?q?6YSbfbFJZ3yujs+TIb1+/ZYudi0pmykyelPkN1lRrT84tGVzvUsO2C0dQ82iw26Zj?= =?utf-8?q?otQhKQXtk2FIgE3d89Ear/n08i3QpIFKdT/2H3ux7JAKxY8plbuLVMJjXQkxqAjiO?= =?utf-8?q?jXm9baxxYNqsTWv+cImIhfgx39v6SEcGrlKwuMt3u7ZP7E5MvjP2hpuQM2hg300p1?= =?utf-8?q?lCWyXMZjLzJkU5048CyqCurwDxVtrelp0s1IbdMahLq9oIA34gZs/+THb31cyRok3?= =?utf-8?q?U87ESas9BWAHP94UsfuU5AjsfTfTvoZOCVJBN546NpFHLPmzWT6DBhx/DD0CYpCNu?= =?utf-8?q?zlSyFVMXdvQM+F0lHuwtSbQuDPqS3dKyjpej0aTUT1cw0CRBeexZsU2rXMRm75XWj?= =?utf-8?q?lXgILom2FUu4plzcZ7l22yXA7x9WH1ufwvIaC32gu7F8Xn0NqIf2Qx0=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ca57ec1-763c-44bb-e619-08dca023133d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2024 14:26:08.6339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q2RUq1romSoXg1RSkFbm838rFvVAlUGCaB5TTzF3pYmz5zwPsDvpSR91Xdnsm8Rr1OkTTnnUvgFlqShScthTpYIdcjz9auXijY4bviiOriSfoWbJHjTy6k1/pYi9jerL X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR07MB8459 Received-SPF: pass client-ip=80.78.11.84; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost3.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Clément Mathieu--Drif The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present. Fixes: 1b2b12376c8a ("intel-iommu: PASID support") Signed-off-by: Clément Mathieu--Drif Reviewed-by: Yi Liu Reviewed-by: Zhenzhong Duan Reviewed-by: Minwoo Im --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index f8cf99bddf..cbc4030031 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -267,7 +267,7 @@ /* For the low 64-bit of 128-bit */ #define VTD_FRCD_FI(val) ((val) & ~0xfffULL) #define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40) -#define VTD_FRCD_PP(val) (((val) & 0x1) << 31) +#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31) #define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48) /* DMA Remapping Fault Conditions */