diff mbox series

[v5,1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h

Message ID 20240626090528.812-2-chalapathi.v@linux.ibm.com
State New
Headers show
Series hw/ppc: SPI model | expand

Commit Message

Chalapathi V June 26, 2024, 9:05 a.m. UTC 
In this commit target specific dependency from include/hw/ppc/pnv_xscom.h
has been removed so that pnv_xscom.h can be included outside hw/ppc.

Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com>
---
 include/hw/ppc/pnv_xscom.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cédric Le Goater June 26, 2024, 9:09 a.m. UTC | #1 
On 6/26/24 11:05 AM, Chalapathi V wrote:
> In this commit target specific dependency from include/hw/ppc/pnv_xscom.h
> has been removed so that pnv_xscom.h can be included outside hw/ppc.
> 
> Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   include/hw/ppc/pnv_xscom.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index 6209e18492..c8dd42bffd 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -21,9 +21,9 @@
>   #define PPC_PNV_XSCOM_H
>   
>   #include "exec/memory.h"
> -#include "hw/ppc/pnv.h"
>   
>   typedef struct PnvXScomInterface PnvXScomInterface;
> +typedef struct PnvChip PnvChip;
>   
>   #define TYPE_PNV_XSCOM_INTERFACE "pnv-xscom-interface"
>   #define PNV_XSCOM_INTERFACE(obj) \
CALEB SCHLOSSIN June 26, 2024, 12:10 p.m. UTC | #2 
On 6/26/24 11:05 AM, Chalapathi V wrote:
> In this commit target specific dependency from include/hw/ppc/pnv_xscom.h
> has been removed so that pnv_xscom.h can be included outside hw/ppc.
>
> Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com>


Reviewed-by: Caleb Schlossin <calebs@linux.vnet.ibm.com>

Thanks,
Caleb Schlossin
diff mbox series

Patch

diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
index 6209e18492..c8dd42bffd 100644
--- a/include/hw/ppc/pnv_xscom.h
+++ b/include/hw/ppc/pnv_xscom.h
@@ -21,9 +21,9 @@ 
 #define PPC_PNV_XSCOM_H
 
 #include "exec/memory.h"
-#include "hw/ppc/pnv.h"
 
 typedef struct PnvXScomInterface PnvXScomInterface;
+typedef struct PnvChip PnvChip;
 
 #define TYPE_PNV_XSCOM_INTERFACE "pnv-xscom-interface"
 #define PNV_XSCOM_INTERFACE(obj) \