diff mbox series

[v3,1/3] tests/acpi: pc: allow DSDT acpi table changes

Message ID 20240607141809.1637137-2-ribalda@chromium.org
State New
Headers show
Series hw/i386/acpi: Pre-compute the _PRT table | expand

Commit Message

Ricardo Ribalda June 7, 2024, 2:17 p.m. UTC 
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 tests/qtest/bios-tables-test-allowed-diff.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Igor Mammedov June 28, 2024, 11:25 a.m. UTC | #1 
On Fri,  7 Jun 2024 14:17:24 +0000
Ricardo Ribalda <ribalda@chromium.org> wrote:

> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  tests/qtest/bios-tables-test-allowed-diff.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index dfb8523c8b..b2c2c10cbc 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1 +1,2 @@
>  /* List of comma-separated changed AML files to ignore */
> +"tests/data/acpi/pc/DSDT",

that's no enough, a lot more tables expected blobs are affected by
the next patch.

before posting, make sure that 'make check-qtest' passes fine
Ricardo Ribalda June 28, 2024, 5:06 p.m. UTC | #2 
Hi Igor



On Fri, 28 Jun 2024 at 13:25, Igor Mammedov <imammedo@redhat.com> wrote:
>
> On Fri,  7 Jun 2024 14:17:24 +0000
> Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> > ---
> >  tests/qtest/bios-tables-test-allowed-diff.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index dfb8523c8b..b2c2c10cbc 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1 +1,2 @@
> >  /* List of comma-separated changed AML files to ignore */
> > +"tests/data/acpi/pc/DSDT",
>
> that's no enough, a lot more tables expected blobs are affected by
> the next patch.
>

Sorry about that, I did not realise that the check was quitting after
the first different file was found.

will post a new version soon

Thanks!

>
> before posting, make sure that 'make check-qtest' passes fine
>
diff mbox series

Patch

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..b2c2c10cbc 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,2 @@ 
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT",