| Message ID | 20240430091329.2365053-1-vsementsov@yandex-team.ru |
|---|---|
| State | New |
| Headers | show |
| Series | iotests/pylintrc: allow up to 10 similar lines | expand |
On 30/4/24 11:13, Vladimir Sementsov-Ogievskiy wrote: > We want to have similar QMP objects in different tests. Reworking these > objects to make common parts by calling some helper functions doesn't > seem good. It's a lot more comfortable to see the whole QAPI request in > one place. > > So, let's increase the limit, to unblock further commit > "iotests: add backup-discard-source" > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > > Hi all! That's a patch to unblock my PR > "[PULL 0/6] Block jobs patches for 2024-04-29" > <20240429115157.2260885-1-vsementsov@yandex-team.ru> > https://patchew.org/QEMU/20240429115157.2260885-1-vsementsov@yandex-team.ru/ > > > tests/qemu-iotests/pylintrc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc > index de2e0c2781..05b75ee59b 100644 > --- a/tests/qemu-iotests/pylintrc > +++ b/tests/qemu-iotests/pylintrc > @@ -55,4 +55,4 @@ max-line-length=79 > > [SIMILARITIES] > > -min-similarity-lines=6 > +min-similarity-lines=10 Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 30.04.24 12:13, Vladimir Sementsov-Ogievskiy wrote: > We want to have similar QMP objects in different tests. Reworking these > objects to make common parts by calling some helper functions doesn't > seem good. It's a lot more comfortable to see the whole QAPI request in > one place. > > So, let's increase the limit, to unblock further commit > "iotests: add backup-discard-source" > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > > Hi all! That's a patch to unblock my PR > "[PULL 0/6] Block jobs patches for 2024-04-29" > <20240429115157.2260885-1-vsementsov@yandex-team.ru> > https://patchew.org/QEMU/20240429115157.2260885-1-vsementsov@yandex-team.ru/ > > > tests/qemu-iotests/pylintrc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc > index de2e0c2781..05b75ee59b 100644 > --- a/tests/qemu-iotests/pylintrc > +++ b/tests/qemu-iotests/pylintrc > @@ -55,4 +55,4 @@ max-line-length=79 > > [SIMILARITIES] > > -min-similarity-lines=6 > +min-similarity-lines=10 Hi! I hope it's OK, if I just apply this to my block branch, and resend "[PULL 0/6] Block jobs patches for 2024-04-29" which is blocked on this problem. Thanks for reviewing, applied to my block branch
Am 28.05.2024 um 14:49 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 30.04.24 12:13, Vladimir Sementsov-Ogievskiy wrote: > > We want to have similar QMP objects in different tests. Reworking these > > objects to make common parts by calling some helper functions doesn't > > seem good. It's a lot more comfortable to see the whole QAPI request in > > one place. > > > > So, let's increase the limit, to unblock further commit > > "iotests: add backup-discard-source" > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > > --- > > > > Hi all! That's a patch to unblock my PR > > "[PULL 0/6] Block jobs patches for 2024-04-29" > > <20240429115157.2260885-1-vsementsov@yandex-team.ru> > > https://patchew.org/QEMU/20240429115157.2260885-1-vsementsov@yandex-team.ru/ > > > > > > tests/qemu-iotests/pylintrc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc > > index de2e0c2781..05b75ee59b 100644 > > --- a/tests/qemu-iotests/pylintrc > > +++ b/tests/qemu-iotests/pylintrc > > @@ -55,4 +55,4 @@ max-line-length=79 > > [SIMILARITIES] > > -min-similarity-lines=6 > > +min-similarity-lines=10 > > > Hi! I hope it's OK, if I just apply this to my block branch, and > resend "[PULL 0/6] Block jobs patches for 2024-04-29" which is blocked > on this problem. Sorry, I only just returned from PTO and now have to catch up with things. But yes, if John doesn't have any objections, it's fine with me, too. Reviewed-by: Kevin Wolf <kwolf@redhat.com>
diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc index de2e0c2781..05b75ee59b 100644 --- a/tests/qemu-iotests/pylintrc +++ b/tests/qemu-iotests/pylintrc @@ -55,4 +55,4 @@ max-line-length=79 [SIMILARITIES] -min-similarity-lines=6 +min-similarity-lines=10
We want to have similar QMP objects in different tests. Reworking these objects to make common parts by calling some helper functions doesn't seem good. It's a lot more comfortable to see the whole QAPI request in one place. So, let's increase the limit, to unblock further commit "iotests: add backup-discard-source" Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> --- Hi all! That's a patch to unblock my PR "[PULL 0/6] Block jobs patches for 2024-04-29" <20240429115157.2260885-1-vsementsov@yandex-team.ru> https://patchew.org/QEMU/20240429115157.2260885-1-vsementsov@yandex-team.ru/ tests/qemu-iotests/pylintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)