| Message ID | 20240216145841.2099240-13-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi: Doc comment parsing & doc generation work | expand |
On Fri, Feb 16, 2024 at 03:58:36PM +0100, Markus Armbruster wrote: > We currently call QAPIDoc.check() only for definition documentation. > Calling it for free-form documentation as well is simpler. No change, > because it doesn't actually do anything there. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > scripts/qapi/schema.py | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index 6a836950a9..8ba5665bc6 100644 --- a/scripts/qapi/schema.py +++ b/scripts/qapi/schema.py @@ -95,10 +95,6 @@ def connect_doc(self, doc=None): for f in self.features: doc.connect_feature(f) - def check_doc(self): - if self.doc: - self.doc.check() - def _set_module(self, schema, info): assert self._checked fname = info.fname if info else QAPISchemaModule.BUILTIN_MODULE_NAME @@ -1223,9 +1219,10 @@ def check(self): for ent in self._entity_list: ent.check(self) ent.connect_doc() - ent.check_doc() for ent in self._entity_list: ent.set_module(self) + for doc in self.docs: + doc.check() def visit(self, visitor): visitor.visit_begin(self)
We currently call QAPIDoc.check() only for definition documentation. Calling it for free-form documentation as well is simpler. No change, because it doesn't actually do anything there. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- scripts/qapi/schema.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)