| Message ID | 20240212085142.523317-1-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Mon, 12 Feb 2024 at 08:51, Markus Armbruster <armbru@redhat.com> wrote: > > I offered Marc-André to do this pull request, and he accepted. > > The following changes since commit 5d1fc614413b10dd94858b07a1b2e26b1aa0296c: > > Merge tag 'migration-staging-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-02-09 11:22:20 +0000) > > are available in the Git repository at: > > https://repo.or.cz/qemu/armbru.git tags/pull-char-2024-02-12 > > for you to fetch changes up to 684d03acff6096b8ae79da0fcd6194238827c67e: > > qapi/char: Deprecate backend type "memory" (2024-02-12 09:39:38 +0100) > > ---------------------------------------------------------------- > Character device backend patches for 2024-02-12 > > ---------------------------------------------------------------- > Markus Armbruster (4): > chardev/parallel: Don't close stdin on inappropriate device > tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check > qapi/char: Make backend types properly conditional > qapi/char: Deprecate backend type "memory" The new test-char test fails on the x64-freebsd-13-build job: https://gitlab.com/qemu-project/qemu/-/jobs/6155393879 https://gitlab.com/qemu-project/qemu/-/jobs/6158373424 652/850 qemu:unit / test-char ERROR 0.14s killed by signal 6 SIGABRT ――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― stderr: ** ERROR:../tests/unit/test-char.c:1218:char_parallel_test: 'chr' should be NULL (test program exited with status code -6) thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Mon, 12 Feb 2024 at 08:51, Markus Armbruster <armbru@redhat.com> wrote: >> >> I offered Marc-André to do this pull request, and he accepted. >> >> The following changes since commit 5d1fc614413b10dd94858b07a1b2e26b1aa0296c: >> >> Merge tag 'migration-staging-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-02-09 11:22:20 +0000) >> >> are available in the Git repository at: >> >> https://repo.or.cz/qemu/armbru.git tags/pull-char-2024-02-12 >> >> for you to fetch changes up to 684d03acff6096b8ae79da0fcd6194238827c67e: >> >> qapi/char: Deprecate backend type "memory" (2024-02-12 09:39:38 +0100) >> >> ---------------------------------------------------------------- >> Character device backend patches for 2024-02-12 >> >> ---------------------------------------------------------------- >> Markus Armbruster (4): >> chardev/parallel: Don't close stdin on inappropriate device >> tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check >> qapi/char: Make backend types properly conditional >> qapi/char: Deprecate backend type "memory" > > The new test-char test fails on the x64-freebsd-13-build job: > https://gitlab.com/qemu-project/qemu/-/jobs/6155393879 > https://gitlab.com/qemu-project/qemu/-/jobs/6158373424 > > 652/850 qemu:unit / test-char ERROR 0.14s killed by signal 6 SIGABRT > ――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― > stderr: > ** ERROR:../tests/unit/test-char.c:1218:char_parallel_test: 'chr' should be NULL > (test program exited with status code -6) Hmm, I think I see where I screwed up. Thanks!
I offered Marc-André to do this pull request, and he accepted. The following changes since commit 5d1fc614413b10dd94858b07a1b2e26b1aa0296c: Merge tag 'migration-staging-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-02-09 11:22:20 +0000) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-char-2024-02-12 for you to fetch changes up to 684d03acff6096b8ae79da0fcd6194238827c67e: qapi/char: Deprecate backend type "memory" (2024-02-12 09:39:38 +0100) ---------------------------------------------------------------- Character device backend patches for 2024-02-12 ---------------------------------------------------------------- Markus Armbruster (4): chardev/parallel: Don't close stdin on inappropriate device tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check qapi/char: Make backend types properly conditional qapi/char: Deprecate backend type "memory" docs/about/deprecated.rst | 8 ++++++++ qapi/char.json | 28 +++++++++++++++++----------- include/qemu/osdep.h | 9 ++++++++- chardev/char-parallel.c | 7 +++++-- tests/unit/test-char.c | 25 +++++++++++++++++++++++-- chardev/meson.build | 4 +--- 6 files changed, 62 insertions(+), 19 deletions(-)