diff mbox series

[1/3] migration: Make threshold_size an uint64_t

Message ID 20240117075848.139045-2-peterx@redhat.com
State New
Headers show
Series migration: some small cleanups | expand

Commit Message

Peter Xu Jan. 17, 2024, 7:58 a.m. UTC 
From: Peter Xu <peterx@redhat.com>

It's always used to compare against another uint64_t.  Make it always clear
that it's never a negative.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Jan. 17, 2024, 8:09 a.m. UTC | #1 
On 17/1/24 08:58, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> It's always used to compare against another uint64_t.  Make it always clear
> that it's never a negative.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   migration/migration.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Fabiano Rosas Jan. 19, 2024, 1:26 p.m. UTC | #2 
peterx@redhat.com writes:

> From: Peter Xu <peterx@redhat.com>
>
> It's always used to compare against another uint64_t.  Make it always clear
> that it's never a negative.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>
diff mbox series

Patch

diff --git a/migration/migration.h b/migration/migration.h
index 17972dac34..a589ae8650 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -296,7 +296,7 @@  struct MigrationState {
      * this threshold; it's calculated from the requested downtime and
      * measured bandwidth, or avail-switchover-bandwidth if specified.
      */
-    int64_t threshold_size;
+    uint64_t threshold_size;
 
     /* params from 'migrate-set-parameters' */
     MigrationParameters parameters;