diff mbox series

hw/arm: add cache controller for Freescale i.MX6

Message ID 20231219105510.4907-1-n.ostrenkov@gmail.com
State New
Headers show
Series hw/arm: add cache controller for Freescale i.MX6 | expand

Commit Message

Nikita Ostrenkov Dec. 19, 2023, 10:55 a.m. UTC 
Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
---
 hw/arm/Kconfig    | 1 +
 hw/arm/fsl-imx6.c | 3 +++
 2 files changed, 4 insertions(+)

Comments

Peter Maydell Dec. 19, 2023, 4:08 p.m. UTC | #1 
On Tue, 19 Dec 2023 at 10:55, Nikita Ostrenkov <n.ostrenkov@gmail.com> wrote:
>
> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
> ---
>  hw/arm/Kconfig    | 1 +
>  hw/arm/fsl-imx6.c | 3 +++
>  2 files changed, 4 insertions(+)

Thanks for this patch; it looks fairly obviously right,
but I wanted to let you know I won't be able to do proper patch
review and take it into the arm queue until I get back from holidays
in January.

-- PMM
Nikita Ostrenkov Dec. 19, 2023, 7:05 p.m. UTC | #2 
thanks for letting me know! Enjoy your holidays.

вт, 19 дек. 2023 г., 19:08 Peter Maydell <peter.maydell@linaro.org>:

> On Tue, 19 Dec 2023 at 10:55, Nikita Ostrenkov <n.ostrenkov@gmail.com>
> wrote:
> >
> > Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
> > ---
> >  hw/arm/Kconfig    | 1 +
> >  hw/arm/fsl-imx6.c | 3 +++
> >  2 files changed, 4 insertions(+)
>
> Thanks for this patch; it looks fairly obviously right,
> but I wanted to let you know I won't be able to do proper patch
> review and take it into the arm queue until I get back from holidays
> in January.
>
> -- PMM
>
Philippe Mathieu-Daudé Jan. 4, 2024, 4:36 p.m. UTC | #3 
On 19/12/23 11:55, Nikita Ostrenkov wrote:

Per "i.MX 6Dual/6Quad Applications Processor Reference Manual, Rev. 4, 
09/2017", Chapter 2 "Memory Maps", 2.2 ARM Platform Memory Map,
Table 2-1. System memory map.

> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
> ---
>   hw/arm/Kconfig    | 1 +
>   hw/arm/fsl-imx6.c | 3 +++
>   2 files changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Peter Maydell Jan. 5, 2024, 4:24 p.m. UTC | #4 
On Tue, 19 Dec 2023 at 10:55, Nikita Ostrenkov <n.ostrenkov@gmail.com> wrote:
>
> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
> ---
>  hw/arm/Kconfig    | 1 +
>  hw/arm/fsl-imx6.c | 3 +++
>  2 files changed, 4 insertions(+)
>



Applied to target-arm.next, thanks.

-- PMM
diff mbox series

Patch

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 3ada335a24..386f06840c 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -536,6 +536,7 @@  config FSL_IMX6
     select IMX_I2C
     select IMX_USBPHY
     select WDT_IMX2
+    select PL310  # cache controller
     select SDHCI
 
 config ASPEED_SOC
diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
index 7dc42cbfe6..f56130a7a7 100644
--- a/hw/arm/fsl-imx6.c
+++ b/hw/arm/fsl-imx6.c
@@ -154,6 +154,9 @@  static void fsl_imx6_realize(DeviceState *dev, Error **errp)
         sysbus_connect_irq(SYS_BUS_DEVICE(&s->a9mpcore), i + smp_cpus,
                            qdev_get_gpio_in(DEVICE(&s->cpu[i]), ARM_CPU_FIQ));
     }
+    
+    /* L2 cache controller */
+    sysbus_create_simple("l2x0", FSL_IMX6_PL310_ADDR, NULL);
 
     if (!sysbus_realize(SYS_BUS_DEVICE(&s->ccm), errp)) {
         return;