| Message ID | 20231210220712.491494-10-ltaylorsimpson@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Hexagon (target/hexagon) Make generators object oriented | expand |
> -----Original Message----- > From: Taylor Simpson <ltaylorsimpson@gmail.com> > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain <bcain@quicinc.com>; Matheus Bernardino (QUIC) > <quic_mathbern@quicinc.com>; Sid Manning <sidneym@quicinc.com>; Marco > Liebel (QUIC) <quic_mliebel@quicinc.com>; richard.henderson@linaro.org; > philmd@linaro.org; ale@rev.ng; anjo@rev.ng; ltaylorsimpson@gmail.com > Subject: [PATCH v2 9/9] Hexagon (target/hexagon) Remove dead functions > from hex_common.py > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > These functions are no longer used after making the generators > object oriented. > > Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com> > --- > target/hexagon/hex_common.py | 51 ------------------------------------ > 1 file changed, 51 deletions(-) > > diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py > index ca5e9630c1..195620c7ec 100755 > --- a/target/hexagon/hex_common.py > +++ b/target/hexagon/hex_common.py > @@ -33,9 +33,6 @@ > overrides = {} # tags with helper overrides > idef_parser_enabled = {} # tags enabled for idef-parser > > -def bad_register(regtype, regid): > - raise Exception(f"Bad register parse: regtype '{regtype}' regid '{regid}'") > - > # We should do this as a hash for performance, > # but to keep order let's keep it as a list. > def uniquify(seq): > @@ -200,46 +197,6 @@ def get_tagimms(): > return dict(zip(tags, list(map(compute_tag_immediates, tags)))) > > > -def is_pair(regid): > - return len(regid) == 2 > - > - > -def is_single(regid): > - return len(regid) == 1 > - > - > -def is_written(regid): > - return regid[0] in "dexy" > - > - > -def is_writeonly(regid): > - return regid[0] in "de" > - > - > -def is_read(regid): > - return regid[0] in "stuvwxy" > - > - > -def is_readwrite(regid): > - return regid[0] in "xy" > - > - > -def is_scalar_reg(regtype): > - return regtype in "RPC" > - > - > -def is_hvx_reg(regtype): > - return regtype in "VQ" > - > - > -def is_old_val(regtype, regid, tag): > - return regtype + regid + "V" in semdict[tag] > - > - > -def is_new_val(regtype, regid, tag): > - return regtype + regid + "N" in semdict[tag] > - > - > def need_slot(tag): > if ( > "A_CVI_SCATTER" not in attribdict[tag] > @@ -280,14 +237,6 @@ def skip_qemu_helper(tag): > return tag in overrides.keys() > > > -def is_tmp_result(tag): > - return "A_CVI_TMP" in attribdict[tag] or "A_CVI_TMP_DST" in > attribdict[tag] > - > - > -def is_new_result(tag): > - return "A_CVI_NEW" in attribdict[tag] > - > - > def is_idef_parser_enabled(tag): > return tag in idef_parser_enabled > > -- > 2.34.1 Reviewed-by: Brian Cain <bcain@quicinc.com>
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py index ca5e9630c1..195620c7ec 100755 --- a/target/hexagon/hex_common.py +++ b/target/hexagon/hex_common.py @@ -33,9 +33,6 @@ overrides = {} # tags with helper overrides idef_parser_enabled = {} # tags enabled for idef-parser -def bad_register(regtype, regid): - raise Exception(f"Bad register parse: regtype '{regtype}' regid '{regid}'") - # We should do this as a hash for performance, # but to keep order let's keep it as a list. def uniquify(seq): @@ -200,46 +197,6 @@ def get_tagimms(): return dict(zip(tags, list(map(compute_tag_immediates, tags)))) -def is_pair(regid): - return len(regid) == 2 - - -def is_single(regid): - return len(regid) == 1 - - -def is_written(regid): - return regid[0] in "dexy" - - -def is_writeonly(regid): - return regid[0] in "de" - - -def is_read(regid): - return regid[0] in "stuvwxy" - - -def is_readwrite(regid): - return regid[0] in "xy" - - -def is_scalar_reg(regtype): - return regtype in "RPC" - - -def is_hvx_reg(regtype): - return regtype in "VQ" - - -def is_old_val(regtype, regid, tag): - return regtype + regid + "V" in semdict[tag] - - -def is_new_val(regtype, regid, tag): - return regtype + regid + "N" in semdict[tag] - - def need_slot(tag): if ( "A_CVI_SCATTER" not in attribdict[tag] @@ -280,14 +237,6 @@ def skip_qemu_helper(tag): return tag in overrides.keys() -def is_tmp_result(tag): - return "A_CVI_TMP" in attribdict[tag] or "A_CVI_TMP_DST" in attribdict[tag] - - -def is_new_result(tag): - return "A_CVI_NEW" in attribdict[tag] - - def is_idef_parser_enabled(tag): return tag in idef_parser_enabled
These functions are no longer used after making the generators object oriented. Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com> --- target/hexagon/hex_common.py | 51 ------------------------------------ 1 file changed, 51 deletions(-)