diff mbox series

hw/audio/virtio-snd-pci: fix the PCI class code

Message ID 20231107185034.6434-1-vr_qemu@t-online.de
State New
Headers show
Series hw/audio/virtio-snd-pci: fix the PCI class code | expand

Commit Message

Volker Rümelin Nov. 7, 2023, 6:50 p.m. UTC 
The virtio sound device is currently an unclassified PCI device.

~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Unclassified device [00ff]:
 Red Hat, Inc. Device [1af4:1059] (rev 01)
        Subsystem: Red Hat, Inc. Device [1af4:1100]

Set the correct PCI class code to change the device to a
multimedia audio controller.

~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Multimedia audio controller [0401]:
 Red Hat, Inc. Device [1af4:1059] (rev 01)
        Subsystem: Red Hat, Inc. Device [1af4:1100]

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
The two additional lines have been lost between v6 and v7 of
the "Add VIRTIO sound card" patch series.

 hw/audio/virtio-snd-pci.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Philippe Mathieu-Daudé Nov. 7, 2023, 6:57 p.m. UTC | #1 
On 7/11/23 19:50, Volker Rümelin wrote:
> The virtio sound device is currently an unclassified PCI device.
> 
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
>   Red Hat, Inc. Device [1af4:1059] (rev 01)
>          Subsystem: Red Hat, Inc. Device [1af4:1100]
> 
> Set the correct PCI class code to change the device to a
> multimedia audio controller.
> 
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Multimedia audio controller [0401]:
>   Red Hat, Inc. Device [1af4:1059] (rev 01)
>          Subsystem: Red Hat, Inc. Device [1af4:1100]
> 
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> The two additional lines have been lost between v6 and v7 of
> the "Add VIRTIO sound card" patch series.
> 
>   hw/audio/virtio-snd-pci.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Manos Pitsidianakis Nov. 7, 2023, 7:08 p.m. UTC | #2 
On Tue, 7 Nov 2023 at 20:50, Volker Rümelin <vr_qemu@t-online.de> wrote:
>
> The virtio sound device is currently an unclassified PCI device.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
>  Red Hat, Inc. Device [1af4:1059] (rev 01)
>         Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Set the correct PCI class code to change the device to a
> multimedia audio controller.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Multimedia audio controller [0401]:
>  Red Hat, Inc. Device [1af4:1059] (rev 01)
>         Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Alex Bennée Nov. 7, 2023, 7:33 p.m. UTC | #3 
Volker Rümelin <vr_qemu@t-online.de> writes:

> The virtio sound device is currently an unclassified PCI device.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
>  Red Hat, Inc. Device [1af4:1059] (rev 01)
>         Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Set the correct PCI class code to change the device to a
> multimedia audio controller.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff mbox series

Patch

diff --git a/hw/audio/virtio-snd-pci.c b/hw/audio/virtio-snd-pci.c
index 0f92e0752b..ab58c6410e 100644
--- a/hw/audio/virtio-snd-pci.c
+++ b/hw/audio/virtio-snd-pci.c
@@ -47,12 +47,14 @@  static void virtio_snd_pci_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     VirtioPCIClass *vpciklass = VIRTIO_PCI_CLASS(klass);
+    PCIDeviceClass *pcidevklass = PCI_DEVICE_CLASS(klass);
 
     device_class_set_props(dc, virtio_snd_pci_properties);
     dc->desc = "Virtio Sound";
     set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
 
     vpciklass->realize = virtio_snd_pci_realize;
+    pcidevklass->class_id = PCI_CLASS_MULTIMEDIA_AUDIO;
 }
 
 static void virtio_snd_pci_instance_init(Object *obj)