diff mbox series

[05/12] lasips2: LASI PS/2 devices are not user-createable

Message ID 20231014195719.151397-6-deller@kernel.org
State New
Headers show
Series target/hppa: Add emulation of a C3700 HP-PARISC workstation | expand

Commit Message

Helge Deller Oct. 14, 2023, 7:57 p.m. UTC 
From: Helge Deller <deller@gmx.de>

Those PS/2 ports are created with the LASI controller when
a 32-bit PA-RISC machine is created.

Mark them not user-createable to avoid showing them in
the qemu device list.

Signed-off-by: Helge Deller <deller@gmx.de>
Cc: qemu-stable@nongnu.org
---
 hw/input/lasips2.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

BALATON Zoltan Oct. 14, 2023, 8:33 p.m. UTC | #1 
On Sat, 14 Oct 2023, deller@kernel.org wrote:
> From: Helge Deller <deller@gmx.de>
>
> Those PS/2 ports are created with the LASI controller when
> a 32-bit PA-RISC machine is created.
>
> Mark them not user-createable to avoid showing them in
> the qemu device list.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> Cc: qemu-stable@nongnu.org
> ---
> hw/input/lasips2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c
> index ea7c07a2ba..93c9c887d3 100644
> --- a/hw/input/lasips2.c
> +++ b/hw/input/lasips2.c
> @@ -351,6 +351,8 @@ static void lasips2_port_class_init(ObjectClass *klass, void *data)
> {
>     DeviceClass *dc = DEVICE_CLASS(klass);
>
> +    /* Lasi devices can not be created by users */

That's what the next line says so this comment does not add any info. It 
should instead explain why, such as "part of LASI" or something like that.

Regards,
BALATON Zoltan

> +    dc->user_creatable = false;
>     dc->realize = lasips2_port_realize;
> }
>
> @@ -397,6 +399,8 @@ static void lasips2_kbd_port_class_init(ObjectClass *klass, void *data)
>     DeviceClass *dc = DEVICE_CLASS(klass);
>     LASIPS2PortDeviceClass *lpdc = LASIPS2_PORT_CLASS(klass);
>
> +    /* Lasi devices can not be created by users */
> +    dc->user_creatable = false;
>     device_class_set_parent_realize(dc, lasips2_kbd_port_realize,
>                                     &lpdc->parent_realize);
> }
>
diff mbox series

Patch

diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c
index ea7c07a2ba..93c9c887d3 100644
--- a/hw/input/lasips2.c
+++ b/hw/input/lasips2.c
@@ -351,6 +351,8 @@  static void lasips2_port_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
 
+    /* Lasi devices can not be created by users */
+    dc->user_creatable = false;
     dc->realize = lasips2_port_realize;
 }
 
@@ -397,6 +399,8 @@  static void lasips2_kbd_port_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
     LASIPS2PortDeviceClass *lpdc = LASIPS2_PORT_CLASS(klass);
 
+    /* Lasi devices can not be created by users */
+    dc->user_creatable = false;
     device_class_set_parent_realize(dc, lasips2_kbd_port_realize,
                                     &lpdc->parent_realize);
 }